dsengupta0628
05b4e3a1d9
Latest pulled in changes on 4/20 from upstream to push all together with latest from 4/16
...
Signed-off-by: dsengupta0628 <[email protected]
2026-04-20 14:21:16 +00:00
James Cherry
6e7ec45bc8
rm extra swig module dcls
...
Signed-off-by: James Cherry <[email protected]
2026-04-16 15:46:32 -07:00
dsengupta0628
9fbfcc4fcb
picked changes from upstream master, resolved conflict for levelized driververtices, parseBus for weird defs
...
Signed-off-by: dsengupta0628 <[email protected]
2026-04-16 21:37:37 +00:00
James Cherry
21848bcdd2
clang tidy
...
Signed-off-by: James Cherry <[email protected]
2026-04-15 09:38:10 -07:00
James Cherry
63efee64bf
tidy round1
2026-04-13 14:59:05 -07:00
Jaehyun Kim and Claude
616cb6234a
Fix report_checks -fields {nets} typo to {net} across test scripts
...
The valid field name is "net" (singular) per search/Search.tcl.
Using "nets" triggered Warning 168 (unknown field) silently in
29 test scripts. Fix the field name and regolden .ok files.
Co-Authored-By: Claude <[email protected] [email protected]
2026-04-06 14:41:40 +09:00
Jaehyun Kim and Claude
14af24bc93
Ignore SDF VERSION in diff_files to stabilize tests
...
Add (VERSION pattern to diff_files ignore parameter so SDF tests
don't break on every upstream version bump. Update golden .ok files
to reflect the now-clean diffs.
Co-Authored-By: Claude <[email protected] [email protected]
2026-03-31 22:05:59 +09:00
Jaehyun Kim and Claude
3ca78b11c8
Adapt test files to upstream API changes (string_view migration)
...
Update 16 test files to match upstream OpenSTA API refactoring:
- const char* → std::string/std::string_view across all test APIs
- EXPECT_STREQ → EXPECT_EQ for std::string/string_view returns
- nullptr → "" for string_view parameters (makeClock, makeClockGroups, etc.)
- PropertyValue("literal") → PropertyValue(std::string("literal")) to avoid
bool constructor overload resolution
- Method renames: relatedGroundPin→relatedGroundPort,
relatedPowerPin→relatedPowerPort, firstName→firstParam,
secondName→secondParam
- Constructor changes: OperatingConditions (5-arg → 1-arg + setters),
ModeDef::defineValue (3-arg → 1-arg + setSdfCond)
- LibertyAttrValue::floatValue returns std::pair<float,bool> now
- Filter API: separate args → single expression string + bool_props_as_int
- SDF version golden files: 3.0.1 → 3.1.0
All 6104 tests pass.
Co-Authored-By: Claude <[email protected] [email protected]
2026-03-31 16:34:40 +09:00
Jaehyun Kim
069de0498c
Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-03-31 15:27:01 +09:00
dsengupta0628
6ca7cb55a4
update test infra 2
...
Signed-off-by: dsengupta0628 <[email protected]
2026-03-30 21:49:10 +00:00
dsengupta0628
b5f647cb7f
update test infra to accomodate std::string instead of const char*
...
Signed-off-by: dsengupta0628 <[email protected]
2026-03-30 19:44:26 +00:00
dsengupta0628
5f46ad3dfb
Merge remote-tracking branch 'upstream/master' into sta_latest_merge_strings
2026-03-30 16:22:27 +00:00
James Cherry
6742692876
string squash
...
Signed-off-by: James Cherry <[email protected]
2026-03-28 19:13:35 -07:00
Jaehyun Kim and Claude
434246a8b4
Fix test suite for upstream API changes after merge
...
Adapt all C++ and Tcl tests for upstream API refactoring:
- Header rename: DelayFloat.hh -> Delay.hh
- PocvMode enum replacing boolean pocv (setPocvEnabled -> setPocvMode)
- setReportPathFields gains 8th parameter (report_src_attr)
- GateTableModel/CheckTableModel constructor wraps in TableModels
- gateDelay/checkDelay signature changes (bool -> MinMax/PocvMode)
- Unit::asString returns std::string instead of const char*
- ExceptionThru/To::asString removed, use to_string
- GroupPath/FilterPath/LoopPath::asString removed
- PathEnd::source_clk_delay -> source_clk_latency
- report_net -connections flag removed
- set_report_path_field_width removed
- MaxSkewCheck::skew() now requires sta parameter
- Remove tests that pass nullptr to PinIdHash-based maps (segfault)
- Remove tests for removed APIs (sigmaFactor, reportSigmas)
- Regolden .ok files for numerical precision and format changes
Co-Authored-By: Claude <[email protected] [email protected]
2026-03-21 19:23:36 +09:00
Jaehyun Kim
43bca8d224
Merge remote-tracking branch 'opensta/master' into secure-sta-test-by-opus
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-03-21 18:54:37 +09:00
dsengupta0628
af791b9974
Merge branch 'master' into sta_update_upstream_lvf_stuff
2026-03-20 19:50:24 +00:00
Jaehyun Kim
992a1dcec5
Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-03-20 21:56:12 +09:00
Vitor Bandeira
69e11bbd0d
Merge pull request #300 from The-OpenROAD-Project-staging/secure-sta-test-suite
...
test: Add test infrastructure and sample test cases
2026-03-18 08:54:06 -03:00
James Cherry
134b547501
use std::format squash
2026-03-16 15:01:38 -07:00
James Cherry
d6e7b4256c
lvf squish
...
Signed-off-by: James Cherry <[email protected]
2026-03-13 14:06:35 -07:00
Jaehyun Kim
e7b861051d
test: Fix post-merge build errors and regolden .ok files
...
After merging upstream changes, fix all build errors in C++ test files
and regolden Tcl test golden files to match updated code output.
Build fixes:
- dcalc/test/cpp/TestDcalc.cc: Fix const char* loop iterations, use
EXPECT_NEAR for uninitialized subnormal float comparison
- liberty/test/cpp/TestLibertyStaBasicsB.cc: Wrap tests using removed
LibertyBuilder() default constructor in #if 0
- liberty/test/cpp/TestLibertyStaCallbacks.cc: Fix LibertyBuilder()
call to use sta_->debug()/report(); wrap old visitor tests in #if 0
- search/test/cpp/TestSearchStaDesignB.cc: Fix pg->name() nullptr
comparison (now returns std::string&)
- search/test/cpp/TestSearchStaInit.cc: Fix 5 clkPinsInvalid/isIdealClock
tests to expect throw (API now requires linked network)
Tcl test fixes:
- Remove calls to removed APIs: report_path_end_header/footer, report_path_end2
from 6 search test scripts; regolden their .ok files
- Regolden .ok files for liberty (15), graph (1), network (8),
parasitics (3), sdc (3), util (2), verilog (8) modules to reflect
upstream format changes (timing arcs output, pin ordering, spacing)
All 6103 tests now pass.
Signed-off-by: Jaehyun Kim <[email protected]
2026-03-11 17:11:08 +09:00
Jaehyun Kim
a5f8e9c3ab
test: Fix test failures after master merge
...
Update test code to match API changes from upstream master:
- TestGraph.cc: Fix makeScenes() call to pass reference instead of pointer
- TestLibertyClasses.cc: Fix ScaleFactorType wire_res/wire_cap name mapping;
fix TablePtr usage by calling .get() where const TableModel* is expected
- TestLibertyClasses.cc: Update liberty_read_nangate.ok for new timing arc output
- TestPower.cc: Replace PwrActivityOrigin::defaulted with ::unknown;
fix isSet() expectations (unknown origin returns false)
- TestSdcClasses.cc, TestSdf.cc, TestUtil.cc, TestSpice.cc:
Fix RiseFall::to_string() expected values from short form ("^"/"v")
to long form ("rise"/"fall")
- TestUtil.cc: Remove tests for deleted StringVector/split/TokenParser
and StringSet::deleteContents (removed from master)
- TestSpice.cc: Replace StdStringSeq with StringSeq
- helpers.tcl: Use pwd-based result_dir so module tests write results
to their own test/results/ directory
- verilog_bus.ok: Update golden file for new port ordering from master
Signed-off-by: Jaehyun Kim <[email protected]
2026-03-11 10:16:27 +09:00
Jaehyun Kim
d4ad9312ea
Merge origin/master into secure-sta-test-suite
...
Resolve add/add conflict in test/helpers.tcl by merging both versions:
- Keep master's report_file, report_file_filter, sort_objects functions
- Keep branch's diff_files, diff_files_sorted functions
- Use master's result_dir setup with branch's mkdir logic in make_result_file
Resolve content conflict in test/regression by keeping branch's
bash/ctest launcher over master's Tcl regression script.
Signed-off-by: Jaehyun Kim <[email protected]
2026-03-11 09:48:28 +09:00
James Cherry
981f44db68
update copyright
...
Signed-off-by: James Cherry <[email protected]
2026-03-10 14:57:45 -07:00
James Cherry
741bf4d561
rm using std::
...
Signed-off-by: James Cherry <[email protected]
2026-03-02 12:13:13 -08:00
Jaehyun Kim
92bb9b8ec9
test: Add comprehensive test infrastructure and test cases across all OpenSTA modules
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-02-27 12:59:25 +09:00
Jaehyun Kim
55259b894b
test: Add save_ok script
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-02-27 11:12:27 +09:00
Jaehyun Kim
9bbac53157
test: Make ctest run C++ unit tests
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-02-27 09:51:10 +09:00
Jaehyun Kim and Claude Opus 4.6
8adbcc0d6d
Merge upstream STA update and adapt all tests to new API
...
Major upstream refactoring: Corner→Scene, Mode architecture, warning
format change (Warning ID:), command renames, and many API signature
changes. Adapted all C++ test files and TCL test scripts/expected
output files to pass with the new API. 6159/6159 tests pass.
Co-Authored-By: Claude Opus 4.6 <[email protected] [email protected]
2026-02-23 23:05:29 +09:00
Jaehyun Kim and Claude Opus 4.6
7173c10cc1
test: strengthen assertions, add sorted SDC diff, and clean up tests
...
- Split oversized test files to stay under 5,000 lines per file:
TestSdc.cc → TestSdcClasses.cc, TestSdcStaInit.cc, TestSdcStaDesign.cc
TestSearchStaDesign.cc → TestSearchStaDesign.cc, TestSearchStaDesignB.cc
TestLibertyStaBasics.cc → TestLibertyStaBasics.cc, TestLibertyStaBasicsB.cc
TestNetwork.cc → TestNetwork.cc, TestNetworkB.cc
- Replace ~200+ (void) casts with proper EXPECT_* assertions across all
C++ test files (dcalc, liberty, network, sdc, search, power, spice, util)
- Remove ~55 SUCCEED() and EXPECT_TRUE(true) no-op assertions
- Fix 6 load-only Tcl tests by adding diff_files verification with
22 new .sdcok golden reference files
- Delete 7 orphan .ok files with no matching .tcl tests
- Add how_to_write_good_tests.md and TODO6.md documenting test quality rules
Co-Authored-By: Claude Opus 4.6 <[email protected] [email protected]
2026-02-23 17:36:45 +09:00
Jaehyun Kim and Claude Opus 4.6
e57c8043cd
test: Apply review feedback - part3
...
Remove unnecessary catch blocks from Tcl test files across all modules,
add report_checks after each set_wire_load_model in liberty_wireload,
rewrite liberty_sky130_corners for actual multi-corner timing analysis
with define_corners, and expand C++ tests (TestSearchIncremental 8→36,
TestPower 71→96, TestSpice 98→126 tests).
Co-Authored-By: Claude Opus 4.6 <[email protected]
2026-02-20 13:05:07 +09:00
Jaehyun Kim and Claude Opus 4.6
547737f71e
test: Apply review feedback - part2
...
- Remove stale line-number coverage comments (# Targets: line NNN, hit=0)
- Remove useless file-existence checks from verilog/sdf tests
- Delete 21 orphaned dcalc Tcl tests (C++ tests already cover them)
- Rename liberty_ccsn_ecsm -> liberty_ccsn (no ECSM libs available)
- Fix liberty_sky130_corners to use define_corners/-corner for real multi-corner testing
- Add report_checks per wireload model in liberty_wireload
- Fix test/regression to work from test/ directory (label mismatch)
- Refactor all module CMakeLists.txt with sta_module_tests() macro
Co-Authored-By: Claude Opus 4.6 <[email protected]
2026-02-20 01:13:42 +09:00
Jaehyun Kim
6799b1909a
test: Apply review feedback - part1
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-02-19 23:30:23 +09:00
Jaehyun Kim
b77779f7a6
test: Refactoring. Standardize Google Test naming conventions by removing R#_ prefixes, improve temporary file creation with mkstemp, etc
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-02-13 20:36:42 +09:00
Jaehyun Kim
d6c09372ba
test: Initial upload
...
Signed-off-by: Jaehyun Kim <[email protected]
2026-02-13 19:19:09 +09:00
James Cherry
33e480a6c1
liberty memory management
...
Signed-off-by: James Cherry <[email protected]
2026-02-04 18:33:04 -07:00
James Cherry
d42b821c00
rel 3.0
...
Signed-off-by: James Cherry <[email protected]
2026-01-13 09:36:45 -07:00
James Cherry
8287aec5f6
Verilog make pins for liberty pg_pins resolves #326
...
commit b4a89c93965c49a8685fd41cb6aee10635d7a7f3
Author: James Cherry <[email protected] [email protected] [email protected] [email protected] [email protected]
2025-11-07 11:55:43 -07:00
James Cherry
3620d7a259
liberty min_period timing group support resolves #275
...
Signed-off-by: James Cherry <[email protected]
2025-07-27 18:12:26 -07:00
James Cherry
71bdfb9904
rm using std::string from headers
...
Signed-off-by: James Cherry <[email protected]
2025-05-22 09:25:56 -07:00
James Cherry
91651796c2
report_annotated_delay -list_annotated -> -report_annotated
...
Signed-off-by: James Cherry <[email protected]
2025-05-08 17:49:46 -07:00
James Cherry
1cc9df8804
remove using std from headers
...
Signed-off-by: James Cherry <[email protected]
2025-04-11 16:59:48 -07:00
James Cherry
932525bd87
name, asString -> to_string, const
...
commit d122d05822e02dcc08c665ac6ec7513791dd7209
Author: James Cherry <[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
2025-03-30 15:27:53 -07:00
Christian Costa
bee31c7d68
Messages: Generates messages ids during build and stop in case of duplicate and fix duplicate messages ids ( #210 )
...
* msg: Turn warnings into errors with more explicit meaning and make script returns an error code.
Signed-off-by: Christian Costa <[email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
2025-02-12 09:33:13 -08:00
James Cherry
398a22e97d
LibExpr/spef/saif c++ parsers
...
commit a686a6f77e555513adc40228471c1ad1af4646b3
Author: James Cherry <[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
2025-02-01 14:49:30 -08:00
Matt Liberty
41d1d1bb7b
Avoid parallel build conflicts ( #198 )
...
The Liberty, Sdf, and Verilog parsers were writing to the same files
causing random failures in parallel builds. position.hh and stack.hh
are removed by switching to 3.0 to 3.2 in the require statement.
location.hh is renamed per-parser with api.location.file.
Signed-off-by: Matt Liberty <[email protected]
2025-01-30 19:08:36 -08:00
James Cherry
fb6e7f9fa7
liberty parser c++
...
commit 1abf72bc3430d34a51d82992f1c753f0274a662a
Author: James Cherry <[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
2025-01-27 08:33:35 -07:00
James Cherry
c9a8726707
c++ sdf reader
...
commit da9f267cbb3ed711bff3d2e2c1470fa12f7de26c
Author: James Cherry <[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
2025-01-25 11:34:04 -07:00
James Cherry
2a4fd08211
update copyright
...
Signed-off-by: James Cherry <[email protected]
2025-01-21 18:54:33 -07:00
James Cherry
b2646a96d0
power use density instead of activity
...
commit f9ac0ee51e238b30c4ace2d925344da612ccccee
Author: James Cherry <[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
2025-01-17 13:02:13 -07:00
dsengupta0628
James Cherry
Jaehyun KimandClaude
Vitor Bandeira
Christian Costa
Matt Liberty