* Making the indentation even across the whole file
* Use dynamic linking on macOS and fix its pkg-config usage in the
process. This should render openFPGALoader agnostic to the
location of Homebrew's prefix, and solve compatibility issues with
MacPorts
The following compiler warnings are resolved by adding appropriate override specifiers:
In file included from openFPGALoader/src/ice40.cpp:6:
openFPGALoader/src/ice40.hpp:26:8: warning: 'dumpFlash' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
bool dumpFlash(uint32_t base_addr, uint32_t len);
^
openFPGALoader/src/device.hpp:46:16: note: overridden virtual function is here
virtual bool dumpFlash(uint32_t base_addr, uint32_t len) {
^
In file included from openFPGALoader/src/ice40.cpp:6:
openFPGALoader/src/ice40.hpp:34:7: warning: 'spi_put' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
int spi_put(uint8_t cmd, uint8_t *tx, uint8_t *rx,
^
openFPGALoader/src/spiInterface.hpp:65:14: note: overridden virtual function is here
virtual int spi_put(uint8_t cmd, uint8_t *tx, uint8_t *rx,
^
In file included from openFPGALoader/src/ice40.cpp:6:
openFPGALoader/src/ice40.hpp:39:7: warning: 'spi_put' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
int spi_put(uint8_t *tx, uint8_t *rx, uint32_t len) {
^
openFPGALoader/src/spiInterface.hpp:75:14: note: overridden virtual function is here
virtual int spi_put(uint8_t *tx, uint8_t *rx, uint32_t len) = 0;
^
In file included from openFPGALoader/src/ice40.cpp:6:
openFPGALoader/src/ice40.hpp:43:7: warning: 'spi_wait' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
int spi_wait(uint8_t cmd, uint8_t mask, uint8_t cond,
^
openFPGALoader/src/spiInterface.hpp:85:14: note: overridden virtual function is here
virtual int spi_wait(uint8_t cmd, uint8_t mask, uint8_t cond,
^
4 warnings generated.
Build instructions from source for debian-based distros fixed
- a git clone line was added to clarify when and where source should be
- tested on Debian GNU/Linux 11 (bullseye) / WSL2
Stephan Ruloff
Gwenhael Goavec-Merou
Jean THOMAS
Stéphane Chevigny
Rod Whitby
RGD2
Pepijn de Vos