Merge branch 'master' into netgen-1.5

VERSION

@@ -1 +1 @@
-1.5.313
+1.5.307

base/flatten.c

@@ -300,6 +300,8 @@ int flattenInstancesOf(char *name, int fnum, char *instance)
       return 0;
     }
   }
+  /* Placeholder cells must not be flattened */
+  if (ThisCell->flags & CELL_PLACEHOLDER) return 0;
 
   FreeNodeNames(ThisCell);
 
@@ -337,10 +339,6 @@ int flattenInstancesOf(char *name, int fnum, char *instance)
 	   LastObj = ParentParams;
 	   continue;
       }
-      if (ChildCell->flags & CELL_PLACEHOLDER) {
-	   LastObj = ParentParams;
-	   continue;	// Placeholder cells must not be flattened
-      }
       if (ChildCell == ThisCell) {
 	   LastObj = ParentParams;
 	   continue;	// Avoid infinite loop
@@ -1755,8 +1753,8 @@ PrematchLists(char *name1, int file1, char *name2, int file2)
 		    Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
 				" makes a better match\n", ecomp->cell1->name,
 				name1, file1);
-		    if (flattenInstancesOf(name1, file1, ecomp->cell1->name) > 0)
-			modified1++;
+		    flattenInstancesOf(name1, file1, ecomp->cell1->name); 
+		    modified1++;
 		}
 		else if (ecomp->cell1 && (ecomp->num1 > 0)) {
 		    Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
@@ -1768,8 +1766,8 @@ PrematchLists(char *name1, int file1, char *name2, int file2)
 		    Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
 				" makes a better match\n", ecomp->cell2->name,
 				name2, file2);
-		    if (flattenInstancesOf(name2, file2, ecomp->cell2->name) > 0)
-			modified2++;
+		    flattenInstancesOf(name2, file2, ecomp->cell2->name); 
+		    modified2++;
 		}
 		else if (ecomp->cell2 && (ecomp->num2 > 0)) {
 		    Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
@@ -1863,8 +1861,8 @@ PrematchLists(char *name1, int file1, char *name2, int file2)
 		    	Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
 				" makes a better match\n", ecomp->cell2->name,
 				name2, file2);
-		    	if (flattenInstancesOf(name2, file2, ecomp->cell2->name) > 0)
-			    modified2++;
+		    	flattenInstancesOf(name2, file2, ecomp->cell2->name); 
+		    	modified2++;
 		    }
 		    else if (ecomp->cell2) {
 			Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
@@ -1934,8 +1932,8 @@ PrematchLists(char *name1, int file1, char *name2, int file2)
 		    	Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
 				" makes a better match\n", ecomp->cell1->name,
 				name1, file1);
-		    	if (flattenInstancesOf(name1, file1, ecomp->cell1->name) > 0)
-			    modified1++;
+		    	flattenInstancesOf(name1, file1, ecomp->cell1->name); 
+		        modified1++;
 		    }
 		    else if (ecomp->cell1) {
 			Fprintf(stdout, "Flattening instances of %s in cell %s (%d)"
@@ -2297,12 +2295,11 @@ PrematchLists(char *name1, int file1, char *name2, int file2)
 				    Fprintf(stdout, "Flattening instances of %s in cell"
 						" %s (%d) makes a better match\n",
 						ecompX0->cell1->name, name1, file1);
-				    if (flattenInstancesOf(name1, file1,
-						ecompX0->cell1->name) > 0) {
-					ecompX0->num1 = 0;
-					ecomp0X->num1 += ecompX0->num1;
-					modified1++;
-				    }
+				    flattenInstancesOf(name1, file1,
+						ecompX0->cell1->name); 
+				    ecompX0->num1 = 0;
+				    ecomp0X->num1 += ecompX0->num1;
+				    modified1++;
 				}
 				else
 				{
@@ -2334,12 +2331,11 @@ PrematchLists(char *name1, int file1, char *name2, int file2)
 				    Fprintf(stdout, "Flattening instances of %s in cell"
 						" %s (%d) makes a better match\n",
 						ecomp0X->cell2->name, name2, file2);
-				    if (flattenInstancesOf(name2, file2,
-						ecomp0X->cell2->name) > 0) {
-					ecomp0X->num2 = 0;
-					ecompX0->num2 += ecomp0X->num2;
-					modified2++;
-				    }
+				    flattenInstancesOf(name2, file2,
+						ecomp0X->cell2->name); 
+				    ecomp0X->num2 = 0;
+				    ecompX0->num2 += ecomp0X->num2;
+				    modified2++;
 				}
 				else {
 				    Fprintf(stdout, "Flattening instances of %s in "

base/netcmp.c

@@ -24,7 +24,6 @@ the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
 #include <stdarg.h>
 #include <setjmp.h>
 #include <signal.h>
-#include <strings.h> /* for strncasecmp() */
 #include <time.h>    /* for time() as a seed for random number generator */
 #include <limits.h>
 #include <math.h>    /* for fabs() */
@@ -3582,7 +3581,7 @@ int FlattenUnmatched(struct nlist *tc, char *parent, int stoplevel, int loclevel
 				tc->name, parent, tc->file);
       changed = flattenInstancesOf(parent, tc->file, tc->name);
       Fprintf(stdout, "(%d instance%s)\n", changed, ((changed == 1) ? "" : "s"));
-      return (changed != 0);
+      return 1;
    }
 
    if (tc->cell == NULL) return 0;
@@ -7544,11 +7543,6 @@ struct nlist *addproxies(struct hashlist *p, void *clientdata)
 	     }
 	     else {
 		lob = ob;
-		if (ob == NULL) {
-		    Fprintf(stdout, "Error:  Premature end of pin list on "
-			"instance %s.\n", firstpin->instance.name);
-		    break;
-		}
 		ob->type = i++;
 		ob = ob->next;
 	     }

base/netgen.c

@@ -25,8 +25,6 @@ the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
 #include <stdio.h>
 #include <stdlib.h>	/* for strtof() */
 #include <stdarg.h>
-#include <string.h>
-#include <strings.h>
 #include <ctype.h>	/* toupper() */
 #ifdef IBMPC
 #include <alloc.h>

base/spice.c

@@ -21,9 +21,6 @@ the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
 #include "config.h"
 
 #include <stdio.h>
-#include <string.h>
-#include <strings.h>
-#include <ctype.h>
 #if 0
 #include <stdarg.h>  /* what about varargs, like in pdutils.c ??? */
 #endif

base/verilog.c

@@ -76,8 +76,7 @@ struct hashdict verilogparams;
 // Global storage for verilog definitions
 struct hashdict verilogdefs;
 // Record file pointer that is associated with the hash tables
-int hashfilep = -1;	/* for parameters */
-int hashfiled = -1;	/* for definitions */
+int hashfile = -1;
 
 // Global storage for wire buses
 struct hashdict buses;
@@ -157,8 +156,7 @@ struct expr_stack {
 //-------------------------------------------------------------------------
 // Evaluate an expression for an array bound.  This is much like
 // ReduceOneExpression() in netgen.c, but only handles basic integer
-// arithmetic (+,-,*,/), grouping by parentheses, bit shifts, and
-// if-else operators.
+// arithmetic (+,-,*,/) and grouping by parentheses.
 //
 // Returns 1 if successful, 0 on error.
 // Evaluated result is placed in the integer pointed to by "valptr".
@@ -222,39 +220,6 @@ int EvalExpr(struct expr_stack **stackptr, int *valptr)
 	    }
 	}
 
-	/* Reduce (a << b) and (a >> b) */
-
-	for (texp = start; texp; texp = texp->next) {
-	    if ((texp->last != NULL) && (texp->next != NULL) && (texp->oper != '\0')) {
-		if ((texp->last->oper == '\0') && (texp->next->oper == '\0')) {
-		    if (texp->oper == '<') {
-			/* Left shift */
-			texp->last->value <<= texp->next->value;
-			/* Remove two items from the stack */
-			tmp = texp;
-			texp = texp->last;
-			texp->next = tmp->next->next;
-			if (tmp->next->next) tmp->next->next->last = texp;
-			FREE(tmp->next);
-			FREE(tmp);
-			modified = TRUE;
-		    }
-		    if (texp->oper == '>') {
-			/* Right shift */
-			texp->last->value >>= texp->next->value;
-			/* Remove two items from the stack */
-			tmp = texp;
-			texp = texp->last;
-			texp->next = tmp->next->next;
-			if (tmp->next->next) tmp->next->next->last = texp;
-			FREE(tmp->next);
-			FREE(tmp);
-			modified = TRUE;
-		    }
-		} 
-	    }
-	}
-
 	/* Reduce (a * b) and (a / b) */
 
 	for (texp = start; texp; texp = texp->next) {
@@ -330,39 +295,6 @@ int EvalExpr(struct expr_stack **stackptr, int *valptr)
 	    }
 	}
 
-	/* Reduce (a ? b : c) */
-
-	for (texp = start; texp; texp = texp->next) {
-	    /* There must be at least five objects on the stack */
-	    if ((texp->last != NULL) && (texp->next != NULL) && (texp->oper != '\0')
-			&& (texp->next->next != NULL)
-			&& (texp->next->next->next != NULL)) {
-		if ((texp->last->oper == '\0') && (texp->next->oper == '\0')
-			&& (texp->next->next->next->oper == '\0')) {
-		    if ((texp->oper == '?') && (texp->next->next->oper == ':')) {
-			/* If-Else conditional */
-			if (texp->last->value)
-			    texp->last->value = texp->next->value;
-			else
-			    texp->last->value = texp->next->next->next->value;
-
-			/* Remove four items from the stack */
-			tmp = texp;
-			texp = texp->last;
-			texp->next = tmp->next->next->next->next;
-			if (tmp->next->next->next->next)
-			    tmp->next->next->next->next->last = texp;
-			FREE(tmp->next->next->next);
-			FREE(tmp->next->next);
-			FREE(tmp->next);
-			FREE(tmp);
-
-			modified = TRUE;
-		    }
-		} 
-	    }
-	}
-
 	/* Reduce (a) */
 
 	for (texp = start; texp; texp = texp->next) {
@@ -441,15 +373,8 @@ int ParseIntegerExpression(char *expr, int *iptr)
 
 	if (match(sptr, "+") || match(sptr, "-")
 	    	|| match(sptr, "*") || match(sptr, "/")
-	    	|| match(sptr, "(") || match(sptr, ")")
-	    	|| match(sptr, "<<") || match(sptr, ">>")
-	    	|| match(sptr, "?") || match(sptr, ":")) {
+	    	|| match(sptr, "(") || match(sptr, ")")) {
 	    newexp = (struct expr_stack *)MALLOC(sizeof(struct expr_stack));
-	    /* Note that "oper" is one character and that "<<" and ">>"
-	     * become '<' and '>', respectively.  The less-than and greater-
-	     * than operators are not (yet) handled but will need to be
-	     * recast to some other character in "oper".
-	     */
 	    newexp->oper = *sptr;
 	    newexp->value = 0;
 	    newexp->next = NULL;
@@ -464,7 +389,7 @@ int ParseIntegerExpression(char *expr, int *iptr)
 	if ((result = sscanf(sptr, "%d", &value)) != 1) {
 
 	    // Is name in the parameter list?
-	    kl = (struct property *)HashLookup(sptr, &verilogparams);
+	    kl = (struct property *)HashLookup(nexttok, &verilogparams);
 	    if (kl == NULL) {
 		Printf("Value %s in expression is not a number or a parameter.\n",
 				sptr);
@@ -477,29 +402,27 @@ int ParseIntegerExpression(char *expr, int *iptr)
 		    if (result != 1) {
 		        Printf("Parameter %s has value %s that cannot be parsed"
 				" as an integer.\n",
-				sptr, kl->pdefault.string);
+				nexttok, kl->pdefault.string);
 		    	value = 0;
 			break;
 		    }
 		}
 		else if (kl->type == PROP_INTEGER) {
 		    value = kl->pdefault.ival;
-		    result = 1;		// Assert valid result
 		}
 		else if (kl->type == PROP_DOUBLE) {
 		    value = (int)kl->pdefault.dval;
 		    if ((double)value != kl->pdefault.dval) {
 		        Printf("Parameter %s has value %g that cannot be parsed"
 				" as an integer.\n",
-				sptr, kl->pdefault.dval);
+				nexttok, kl->pdefault.dval);
 		    	value = 0;
 			break;
 		    }
-		    result = 1;		// Assert valid result
 		}
 		else {
 		    Printf("Parameter %s has unknown type; don't know how"
-				" to parse.\n", sptr);
+				" to parse.\n", nexttok);
 		    value = 0;
 		    break;
 		}
@@ -593,8 +516,7 @@ int GetBusTok(struct bus *wb)
 	    }
 	    else if (match(nexttok, "+") || match(nexttok, "-")
 	    		|| match(nexttok, "*") || match(nexttok, "/")
-	    		|| match(nexttok, "(") || match(nexttok, ")")
-	    		|| match(nexttok, "<<") || match(nexttok, ">>")) {
+	    		|| match(nexttok, "(") || match(nexttok, ")")) {
 		newexp = (struct expr_stack *)MALLOC(sizeof(struct expr_stack));
 		newexp->oper = *nexttok;
 		newexp->value = 0;
@@ -1957,8 +1879,7 @@ skip_endmodule:
 	// Allowed uses of "assign" for netlists:
 	//    "assign a = b" joins two nets.
 	//    "assign a = {b, c, ...}" creates a bus from components.
-	//    "assign" using if-else constructs or bit shifts.
-	//   ("assign" using any other boolean arithmetic is not structural verilog.)
+	//    "assign" using any boolean arithmetic is not structural verilog.
 	//    "assign a = {x{b}}" creates a bus by repeating a component.
 
 	if (nexttok && match(nexttok, "=")) {
@@ -2219,19 +2140,6 @@ nextinst:
 	 }
 	 SkipTokComments(VLOG_DELIMITERS);
       }
-      else if (loop.loopvar != NULL) {
-	 /* Instances created within a generate block for loop have an
-	  * implicit array
-	  */
-	 int loopval;
-	 struct property *klr;
-
-	 klr = (struct property *)HashLookup(loop.loopvar, &verilogparams);
-	 loopval = klr->pdefault.ival;
-
-         arraystart = arrayend = loopval;
-         sprintf(instancename + strlen(instancename), "[%d]", loopval);
-      }
 
       if (match(nexttok, "(")) {
 	 char savetok = (char)0;
@@ -2294,8 +2202,7 @@ nextinst:
 			 strcat(new_wire_bundle, nexttok);
 			 FREE(wire_bundle);
 			 wire_bundle = new_wire_bundle;
-			 if (!strcmp(nexttok, "}"))
-			    break;
+			 if (!strcmp(nexttok, "}")) break;
 			 SkipTokComments(VLOG_PIN_CHECK_DELIMITERS);
 		     }
 		     if (!nexttok) {
@@ -2671,7 +2578,6 @@ nextinst:
 	 char *brackptr;
 	 int j;
 	 char locinst[MAX_STR_LEN];
-	 int arraypos = (arraystart > arrayend) ? arraymax - i : i;
 
          if (i != -1)
 	    sprintf(locinst, "%s[%d]", instancename, i);
@@ -2721,14 +2627,7 @@ nextinst:
 	       else if (GetBus(scan->net, &wb) == 0) {
 		   char *bptr2;
 		   char *scanroot;
-		   int isbundle = FALSE;
-		   /* Skip over a bundle delimiter */
-		   if (*scan->net == '{') {
-		      scanroot = strsave(scan->net + 1);
-		      isbundle = TRUE;
-		   }
-		   else
-		      scanroot = strsave(scan->net);
+		   scanroot = strsave(scan->net);
 		   brackptr = strvchr(scanroot, '[');
 		   if (brackptr) *brackptr = '\0';
 
@@ -2761,7 +2660,6 @@ nextinst:
 		   else {
 		       // Instance must be an array
 		       char netname[MAX_STR_LEN];
-		       char *spos = scanroot;
 		       int slice, portlen, siglen;
 
 		       /* Get the array size of the port for bit slicing */
@@ -2773,49 +2671,27 @@ nextinst:
 		       if (siglen < 0) siglen = -siglen;
 		       siglen++;
 
-		       // If this is a bundle, then count out to the current
-		       // slice and read off the index.  NOTE:  Need to
-		       // handle multiple bits per bundle entry!
-		       if (isbundle) {
-			   int j;
-			   if (brackptr) *brackptr = '[';
-			   for (j = 0; j < arraypos * portlen; j++) {
-			       spos = strvchr(spos, ',');
-			       if (spos == NULL) break;
-			       spos++;
-			   }
-			   if (spos != NULL) {
-			       brackptr = strvchr(spos, '[');
-			       *brackptr = '\0';
-			       sscanf(brackptr + 1, "%d", &slice);
-			   }
-			   else spos = scanroot;  /* should emit an error here */
+		       // If signal array is smaller than the portlength *
+		       // length of instance array, then the signal wraps.
+
+		       if (wb2.start >= wb2.end && arraystart >= arrayend) {
+			   slice = wb.start - (arraystart - i) * portlen;
+			   while (slice < wb2.end) slice += siglen;
 		       }
-		       else {	/* not a bundle */
-
-		          // If signal array is smaller than the portlength *
-		          // length of instance array, then the signal wraps.
-
-		          if (wb2.start >= wb2.end && arraystart >= arrayend) {
-			      slice = wb.start - (arraystart - i) * portlen;
-			      while (slice < wb2.end) slice += siglen;
-		          }
-		          else if (wb2.start < wb2.end && arraystart > arrayend) {
-			      slice = wb.start + (arraystart - i) * portlen;
-			      while (slice > wb2.end) slice -= siglen;
-		          }
-		          else if (wb2.start > wb2.end && arraystart < arrayend) {
-			      slice = wb.start - (arraystart + i) * portlen;
-			      while (slice < wb2.end) slice += siglen;
-		          }
-		          else { // (wb2.start < wb2.end && arraystart < arrayend)
-			      slice = wb.start + (arraystart + i) * portlen;
-			      while (slice > wb2.end) slice -= siglen;
-		          }
-			  spos = scanroot;
+		       else if (wb2.start < wb2.end && arraystart > arrayend) {
+			   slice = wb.start + (arraystart - i) * portlen;
+			   while (slice > wb2.end) slice -= siglen;
+		       }
+		       else if (wb2.start > wb2.end && arraystart < arrayend) {
+			   slice = wb.start - (arraystart + i) * portlen;
+			   while (slice < wb2.end) slice += siglen;
+		       }
+		       else { // (wb2.start < wb2.end && arraystart < arrayend)
+			   slice = wb.start + (arraystart + i) * portlen;
+			   while (slice > wb2.end) slice -= siglen;
 		       }
 
-		       sprintf(netname, "%s[%d]", spos, slice);
+		       sprintf(netname, "%s[%d]", scanroot, slice);
 	               if (LookupObject(netname, CurrentCell) == NULL) Node(netname);
 	               join(netname, obptr->name);
 		   }
@@ -3000,25 +2876,18 @@ char *ReadVerilogTop(char *fname, int *fnum, int blackbox)
      hashfunc = hashcase;
   }
 
-  if ((hashfilep != -1) && (hashfilep != *fnum)) {
-      /* Started a new file, so remove all the parameters */
+  if ((hashfile != -1) && (hashfile != *fnum)) {
+      /* Started a new file, so remove all the parameters and definitions */
       RecurseHashTable(&verilogparams, freeprop);
       HashKill(&verilogparams);
-      hashfilep = -1;
-  }
-  if ((hashfiled != -1) && (hashfiled != *fnum)) {
-      /* Started a new file, so remove all the definitions */
       RecurseHashTable(&verilogdefs, freeprop);
       HashKill(&verilogdefs);
-      hashfiled = -1;
+      hashfile = -1;
   }
-  if (hashfilep == -1) {
+  if (hashfile == -1) {
       InitializeHashTable(&verilogparams, OBJHASHSIZE);
-      hashfilep = filenum;
-  }
-  if (hashfiled == -1) {
       InitializeHashTable(&verilogdefs, OBJHASHSIZE);
-      hashfiled = filenum;
+      hashfile = *fnum;
   }
   definitions = &verilogdefs;
 

scripts/defs.mak.in

@@ -68,7 +68,6 @@ LIB_SPECS              = @LIB_SPECS@
 LIB_SPECS_NOSTUB       = @LIB_SPECS_NOSTUB@
 WISH_EXE	       = @WISH_EXE@
 TCL_LIB_DIR	       = @TCL_LIB_DIR@
-EXTRA_CFLAGS	       =
 
 CC                     = @CC@
 CPP                    = @CPP@
@@ -77,7 +76,7 @@ CXX                    = @CXX@
 CPPFLAGS               = -I. -I${NETGENDIR} @CPPFLAGS@
 DFLAGS                 = @extra_defs@ @stub_defs@ @DEFS@ -DSHDLIB_EXT=\"@SHDLIB_EXT@\" -DNDEBUG
 DFLAGS_NOSTUB          = @extra_defs@ @DEFS@ -DSHDLIB_EXT=\"@SHDLIB_EXT@\" -DNDEBUG
-CFLAGS                 = @CFLAGS@ @SHLIB_CFLAGS@ @INC_SPECS@ ${EXTRA_CFLAGS}
+CFLAGS                 = @CFLAGS@ @SHLIB_CFLAGS@ @INC_SPECS@
 
 DEPEND_FILE            = Depend
 DEPEND_FLAG            = @DEPEND_FLAG@

tcltk/netgen.tcl.in

@@ -429,7 +429,7 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} {
          set file1 $name1
          set cell1 $name1
       }
-      puts stdout "Reading netlist file $file1 for $name1"
+      puts stdout "Reading netlist file $file1"
       set fnum1 [netgen::readnet $file1]
    } else {
       set cell1 [lindex $flist1 0]
@@ -446,7 +446,7 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} {
          set file2 $name2
          set cell2 $name2
       }
-      puts stdout "Reading netlist file $file2 for $name2"
+      puts stdout "Reading netlist file $file2"
       set fnum2 [netgen::readnet $file2]
    } else {
       set cell2 [lindex $flist2 0]
@@ -461,7 +461,7 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} {
    }
 
    set clist1 [cells list $fnum1]
-   set cidx [lsearch -exact $clist1 $cell1]
+   set cidx [lsearch -regexp $clist1 ^$cell1$]
    if {$cidx < 0} {
       puts stderr "Cannot find cell $cell1 in file $file1"
       return
@@ -469,7 +469,7 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} {
       set cell1 [lindex $clist1 $cidx]
    }
    set clist2 [cells list $fnum2]
-   set cidx [lsearch -exact $clist2 $cell2]
+   set cidx [lsearch -regexp $clist2 ^$cell2$]
    if {$cidx < 0} {
       puts stderr "Cannot find cell $cell2 in file $file2"
       return
@@ -516,14 +516,6 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} {
 	    }
 	 }
 	 close $fsetup
-      	 if {$command != {}} {
-	    # Incomplete command.  Evaluate it to get a meaningful error message
-	    if {[catch {uplevel 1 [list namespace eval netgen $command]} msg]} {
-		set msg [string trimright $msg "\n"]
-		puts stderr "Error $setupfile:$sline (ignoring), $msg"
-		incr perrors
-	    }
-	 }
       } else {
 	 puts stdout "Error:  Cannot read the setup file $setupfile"
       }

tcltk/tclnetgen.c

@@ -21,8 +21,6 @@ the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
 #include <stdio.h>
 #include <stdlib.h>	/* for getenv */
 #include <string.h>
-#include <strings.h>
-#include <stdarg.h>	/* for va_list */
 
 #include <tcl.h>
 
@@ -45,10 +43,6 @@ the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
 #define FALSE 0
 #endif
 
-#if TCL_MAJOR_VERSION < 9
-typedef int Tcl_Size;
-#endif
-
 /*-----------------------*/
 /* Tcl 8.4 compatibility */
 /*-----------------------*/
@@ -289,7 +283,7 @@ GetTopCell(int fnum)
 int
 CommonGetFilenameOrFile(Tcl_Interp *interp, Tcl_Obj *fobj, int *fnumptr)
 {
-    int result;
+    int result, llen;
     int fnum, ftest;
     char *filename;
     struct nlist *tp;
@@ -372,8 +366,7 @@ CommonParseCell(Tcl_Interp *interp, Tcl_Obj *objv,
 	struct nlist **tpr, int *fnumptr)
 {
     Tcl_Obj *tobj, *fobj;
-    int result;
-    Tcl_Size llen;
+    int result, llen;
     int fnum, ftest, index;
     char *filename, *cellname;
     struct nlist *tp, *tp2;
@@ -1023,7 +1016,7 @@ _netgen_flatten(ClientData clientData,
     Tcl_Interp *interp, int objc, Tcl_Obj *const objv[])
 {
    char *repstr, *file;
-   int result, filenum;
+   int result, llen, filenum;
    struct nlist *tp, *tp2, *tptop;
 
    if ((objc < 2) || (objc > 4)) {
@@ -2121,7 +2114,7 @@ _netcmp_compare(ClientData clientData,
    int fnum1, fnum2, dolist = 0;
    int dohierarchy = FALSE;
    int assignonly = FALSE;
-   int argstart = 1, qresult, result;
+   int argstart = 1, qresult, llen, result;
    int hascontents1, hascontents2;
    struct Correspond *nextcomp;
    struct nlist *tp1 = NULL, *tp2 = NULL;
@@ -2835,7 +2828,7 @@ _netcmp_global(ClientData clientData,
     Tcl_Interp *interp, int objc, Tcl_Obj *const objv[])
 {
    char *filename, *cellname, *pattern;
-   int numchanged = 0, p, fnum, result;
+   int numchanged = 0, p, fnum, llen, result;
    struct nlist *tp;
 
    if (objc < 2) {
@@ -2932,8 +2925,7 @@ _netcmp_equate(ClientData clientData,
    struct ElementClass *saveEclass = NULL;
    struct NodeClass *saveNclass = NULL;
    int file1, file2;
-   int i, dolist = 0, doforce = 0, dounique = 0;
-   Tcl_Size l1, l2, lent, ltest;
+   int i, l1, l2, ltest, lent, dolist = 0, doforce = 0, dounique = 0;
    Tcl_Obj *tobj1, *tobj2, *tobj3;
 
    while (objc > 1) {
@@ -3434,11 +3426,10 @@ int
 _netcmp_property(ClientData clientData,
     Tcl_Interp *interp, int objc, Tcl_Obj *const objv[])
 {
-    int fnum, i;
+    int fnum, i, llen;
     struct nlist *tp;
     struct property *kl, *kllast, *klnext;
     Tcl_Obj *tobj1, *tobj2, *tobj3;
-    Tcl_Size llen;
     double dval;
     int ival, argstart;
 
@@ -4494,14 +4485,14 @@ void tcl_vprintf(FILE *f, const char *fmt, va_list args_in)
 
 void tcl_stdflush(FILE *f)
 {   
-   Tcl_InterpState state;
+   Tcl_SavedResult state;
    static char stdstr[] = "::flush stdxxx";
    char *stdptr = stdstr + 11;
     
-   state = Tcl_SaveInterpState(netgeninterp, TCL_OK);
+   Tcl_SaveResult(netgeninterp, &state);
    strcpy(stdptr, (f == stderr) ? "err" : "out");
    Tcl_Eval(netgeninterp, stdstr);
-   Tcl_RestoreInterpState(netgeninterp, state);
+   Tcl_RestoreResult(netgeninterp, &state);
 }
 
 /*------------------------------------------------------*/
@@ -4570,7 +4561,7 @@ int Tclnetgen_Init(Tcl_Interp *interp)
    /* Remember the interpreter */
    netgeninterp = interp;
 
-   if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL) return TCL_ERROR;
+   if (Tcl_InitStubs(interp, "8.5", 0) == NULL) return TCL_ERROR;
   
    for (n = 0; netgen_cmds[n].name != NULL; n++) {
       sprintf(keyword, "netgen::%s", netgen_cmds[n].name);