This commit refactors the Dartu-Menezes-Pileggi (DMP) effective capacitance
algorithm solver to use the Eigen library, and implements a Determinant Guarded
solver to handle singular and near-singular Jacobians safely and efficiently.
Key changes:
1. Refactored the DMP solver to use Eigen stack-based data structures,
replacing the custom Crout LU decomposition and solver.
2. Extracted the linear solver logic into a dedicated helper function
DmpAlg::solveNewtonStep.
3. Implemented a "Determinant Guarded" solver:
- Manually checks the determinant of the Jacobian (safety guard).
- Throws a DmpError if the determinant is dangerously close to zero (|det| < 1e-12),
safely triggering the lumped capacitance fallback.
- Otherwise, solves using Eigen's highly optimized analytical inverse (fast path).
4. Added documentation in the comments on how to easily swap back to LU
decomposition with partial pivoting (PartialPivLU) if any numerical
precision issues arise in the future.
Benchmark Results (Optimized Release Build, 5,288 DMP calls):
| Test Case | Calls | 1. Original (Crout LU) | 2. Eigen (PartialPivLU) | 3. Eigen (Determinant Guarded) | Speedup (3 vs 1) | Speedup (3 vs 2) |
| :--- | :---: | :---: | :---: | :---: | :---: | :---: |
| power | 2,608 | 1.8822 ms | 1.6791 ms | 1.2702 ms | +32.5% | +24.4% |
| power_vcd | 2,608 | 1.8729 ms | 1.6704 ms | 1.2768 ms | +31.8% | +23.6% |
| spef_parasitics | 24 | 0.0193 ms | 0.0187 ms | 0.0140 ms | +27.5% | +25.1% |
| mcmm3 | 48 | 0.0728 ms | 0.0756 ms | 0.0817 ms | -12.2% | -8.1% |
| Total DMP Time | 5,288 | 3.8472 ms | 3.4438 ms | 2.6427 ms | +31.3% | +23.3% |
* Change DmpAlg to use preallocated arrays
DmpAlg isn't called with nr_order_ > 3 so this change saves 9 news and 9
frees for each construction and destruction of the class.
* Remove nr_order size check in DmpAlg constructor
Signed-off-by: Drew Lewis <cannada@google.com>
---------
Signed-off-by: Drew Lewis <cannada@google.com>
commit be70d30ae05665021254b0d7e69fb8d2f0a82890
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 17:04:49 2023 -0700
cmp
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 4d4ef96948afe3d6a00c4521aeb5bc74274f5737
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 16:08:50 2023 -0700
rvo, const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit bb584e4264af2bea867b17d07e8d38c0e9eb0025
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 15:05:00 2023 -0700
const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit a08fe558bca6b769b2728882258bd85aed990a27
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 14:57:33 2023 -0700
LibertyPortPair no ptrs
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 4d3bd60c109d1ce9d0589d746f4968fa7bebd90d
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 14:13:07 2023 -0700
cleanup
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit dc25ff77771cfbe26f9318bad2b3c45879614783
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 14:06:13 2023 -0700
const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 06e81586ce11a0cc06948ed78fef99353077d69e
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 14:01:10 2023 -0700
sortByName
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 9d8592aff5b246f83e47e1b94490e3cef8d8e119
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 11:57:17 2023 -0700
sort pred
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 462a8e14df8b561ddfc842addc62c4b8435b6347
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 11:09:57 2023 -0700
const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 69f71505b684e88b22d395510429497e87bf1015
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 10:45:14 2023 -0700
flush ConstPortSeq
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 6429d578b78eac3fe7e99fcd67a120789932b2eb
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 09:19:15 2023 -0700
rm ConstNetSet
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit f247930b16e40560b957a36af68947249ed1ef04
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 17 08:50:50 2023 -0700
sortPathNames
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 4ca2b0e0af7252c7bcbc65cf141d0ce40634d329
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 16 10:14:05 2023 -0700
const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 3d18640d2ebc4aae3098c7e7242a554fcb64fd42
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 16 09:41:27 2023 -0700
set_input/ouput_delay -reference_pin
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit d4a0854dd2102f46f96a94fb9eb8749f1593a85f
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 16 09:13:46 2023 -0700
PinPairSet no malloc
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit a6f1583fc6a856c5ecc0dcb15a1d8b1f61e30718
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 16 08:53:33 2023 -0700
no malloc for EdgePins
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit c8e4b92e8b619109d6aa3c141c720646067ccb4b
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 16 06:31:08 2023 +0000
leak
commit abab99e0fc3e466d914f6c1705aa08cdc204df51
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 16 06:07:36 2023 +0000
leaks
commit d1913b554bb6e98b89673d80d2295f552eb4ffca
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 19:48:39 2023 -0700
LibertyCell::checkCornerCell
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit bcc172237d48deed647374f9592bac70bd2d5425
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 18:19:47 2023 -0700
rvo
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 8ef9800b87f5e5548055a13afc21397f28a6bcf7
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 18:07:46 2023 -0700
sdc net id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit d7235abed04ced4e2d84e91bf9968e621268567d
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 16:00:27 2023 -0700
range iter
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit a22f91a3c54c644574339d1126821d9bc8045bd6
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 15:52:50 2023 -0700
range iter
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 762615ce3de91d950eeaaa4680549a45b13e0e0a
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 15:42:19 2023 -0700
range iter
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 7e0c531613d343d23f064c24873bf5a498f6f4ce
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 12:26:49 2023 -0700
rm removeLoadCaps, removeNetLoadCaps
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit f2e88c6082e2d4605e9849348008bf4065401fc8
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 12:21:03 2023 -0700
sdc rm map ptrs
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit b5939666188c0b94dfe957e22bbd8a92f4786125
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 11:36:16 2023 -0700
sdc rm map ptrs
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit a435081bafe10260743319f53a59cbe2ed0388b7
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 08:43:37 2023 -0700
sdc rm map ptrs
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit acfb247559db7b726d47f203613488df0f7add53
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 08:38:07 2023 -0700
sdc rm map ptrs
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 7541b71da92ea15085615988a1e6ea1d4d53d8d6
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 08:00:55 2023 -0700
sdc rm map ptrs
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit d033210132656ea68fa834228575b9def1d02d90
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 07:52:03 2023 -0700
sdc rm map ptrs
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit ca6e9ecb7821b83ab024c4fee6df8f7fc8fc2ce2
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 07:38:12 2023 -0700
instance_pvt_maps_
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 631e4209b596386f5818045d521784db5239f58d
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 07:26:42 2023 -0700
rm GroupPathIterator
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 059c32afa87617fff530c9afa1ef8005a136739d
Author: James Cherry <cherry@parallaxsw.com>
Date: Sat Jan 14 20:07:44 2023 -0700
rm ClockIterator
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit c65fe873a6a6696220bbb44c4ecac87d5ca978ac
Author: James Cherry <cherry@parallaxsw.com>
Date: Sat Jan 14 19:45:58 2023 -0700
rvo
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit ce15c9a0cc78915acddc2f03749573d989ae96d6
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 15 01:04:03 2023 +0000
leaks
commit f97955a0c7e70b65ceb3f697ff47c0524a9b3cd4
Author: James Cherry <cherry@parallaxsw.com>
Date: Sat Jan 14 01:17:58 2023 +0000
leaks
commit 7cdd65684adeb14e02827f5d93e7fab3b19af5dd
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 16:07:47 2023 -0700
leaks
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit ee97c7e50394a3927458e7ef09c5dbeb27719d15
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 11:52:48 2023 -0700
swig rm Tmp collections
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit c49935da8704e41459280971b7645fccd97e3d13
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 11:18:36 2023 -0700
swig rm Tmp types
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 4320b00ce700914843006f592126cd8cc1c4657a
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 10:55:10 2023 -0700
swig rm TmpPinSet, TmpPinSeq
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit ff6004910980c9b09b41f63a553a4481404cc539
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 10:45:06 2023 -0700
swig rm Tmp collections
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 9a5bf5c1a3e5a6d2996b3ab327fa2f3015f2ff20
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 10:15:29 2023 -0700
swig rm one TmpPinSet
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit f441116b56e23849485b2393b30e7086c33165a8
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 09:16:56 2023 -0700
leak
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 050b08df8618340b568d9cd41fd3d5f052e2c680
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 09:10:53 2023 -0700
leak
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit be8c17f3a715ab53140748dc1d94698209965cf9
Author: James Cherry <cherry@parallaxsw.com>
Date: Fri Jan 13 08:59:06 2023 -0700
leak
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit e43b82f8fb52eaeda90e3c7e76cf350ae6735ebd
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 18:57:49 2023 -0700
range iter
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 8db56209de7805ac2574fd2f76170bf68afd156d
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 18:08:54 2023 -0700
GroupPathSet net id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit cb7917f9827c2ea3afebd735cd4508405a0d77d4
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 12:00:15 2023 -0700
DataCheckLess net id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit d9da3c62d7a76699c6ad62cebb1f5c39f89722fa
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 11:42:27 2023 -0700
rm hashPtr uses
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 5bbea162bb1e023aba813598c7992c740ddf9d0b
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 11:30:12 2023 -0700
EdgePins has use net id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit df38405e2ebaabdd7bbf99f3b19d78b25bd95720
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 09:51:38 2023 -0700
ExceptionPath hash use net id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 9a6dcfa54c54c9f50b14248a2449c70c20a0d977
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 08:56:49 2023 -0700
ClockInsertion, ClockLatency net id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit dbb6dc0b8c93812458df31e93f08e0dbd74e8105
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 08:34:03 2023 -0700
ExceptionStateSet obj id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 70b8721c48ec0816289ee09b664c332ee095875f
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 08:14:37 2023 -0700
ClockGroups cmp
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 4c6c4ca191a99cd8541e106fec3202ee14968f39
Author: James Cherry <cherry@parallaxsw.com>
Date: Thu Jan 12 07:38:17 2023 -0700
ClockGroup typedef to ClockSet
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 66f425315e16deee5f00b05c0a505766e7afbf01
Author: James Cherry <cherry@parallaxsw.com>
Date: Wed Jan 11 20:32:38 2023 -0700
set cmps
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit a94866c7828af5b6714e3e4fffc13bdaf5155c0e
Author: James Cherry <cherry@parallaxsw.com>
Date: Wed Jan 11 19:08:09 2023 -0700
net use id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 6348320908f42ebb5262117182e13d0024f65537
Author: James Cherry <cherry@parallaxsw.com>
Date: Wed Jan 11 11:52:13 2023 -0700
exception id cmp
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 0edfca41b6d6408ac17f8dfe10e697c55146c1ef
Author: James Cherry <cherry@parallaxsw.com>
Date: Wed Jan 11 10:47:02 2023 -0700
range iter
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 44ad77985da9f0b9e7f4780e3f233c8d94fa7db7
Author: James Cherry <cherry@parallaxsw.com>
Date: Wed Jan 11 08:27:58 2023 -0700
non-ptr set cmp
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 36de7d88c3fa683465604a9e16b2fc1f6bc5fdd0
Author: James Cherry <cherry@parallaxsw.com>
Date: Wed Jan 11 08:00:54 2023 -0700
range iteration
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 4a31a2c8d9bdae58b09af8c05a64702ea3ac6c15
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 10 16:43:54 2023 -0700
tcl types
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 056a7447b494a4c8ecc9764650d78a5bed3d87e8
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 10 16:10:36 2023 -0700
tcl types
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 97239554c7625ba50ee729260f08eda7dec02365
Author: James Cherry <cherry@parallaxsw.com>
Date: Tue Jan 10 13:10:42 2023 -0700
use RVO
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit c3247d8937d483102e3e1f2b69d7ac1d331ba9d4
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 22:41:20 2023 -0700
swig template seq's
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 5431c06feb256adb46858819fcf5d513cfa6b5ec
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 20:50:24 2023 -0700
swig set in template
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 592ad641bf01d3beb862314a0d8986f66e258642
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 17:27:25 2023 -0700
network return containers
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit c95f8b77e0d6bd5ffa5ba8102413c70883c756e1
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 12:15:37 2023 -0700
PinSeq const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 702e7f9ba2f901066a38f32e67b35602b6c7bbdf
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 12:02:29 2023 -0700
InstanceSeq const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 44fc25ba4a15e4ae570d74af27c9435872a126e0
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 12:01:45 2023 -0700
NetSeq const
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 03b2725c81f5d52c33c875b55056c11d482144f1
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 11:33:18 2023 -0700
rm PortPair
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 3fb82a7344dc053171c9883a113764ba691ab827
Author: James Cherry <cherry@parallaxsw.com>
Date: Mon Jan 9 11:20:53 2023 -0700
PinSet id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 3dd31f027e15d40d62a11d0a88ef2a115f01fb73
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 8 15:03:33 2023 -0700
InstanceSet id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit a91dea5cc0af3bede36b3faed13adb05239ff907
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 8 11:40:15 2023 -0700
NetSet id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit b91e4b6410134eccae7969ddcfb0b27933b2e746
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 8 10:44:47 2023 -0700
CellSet, PortSet id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 6f891f77fae5a6b19c1454a1a4b4e3dfae0b5c50
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 8 10:29:25 2023 -0700
network object sets
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit eb8c627a57ecc6e7c5846a01d62b090ff91c08bf
Author: James Cherry <cherry@parallaxsw.com>
Date: Sun Jan 8 10:09:00 2023 -0700
PinSet1
Signed-off-by: James Cherry <cherry@parallaxsw.com>
commit 8e864ecbdf87000fbb3c3097c39f06173c941e35
Author: James Cherry <cherry@parallaxsw.com>
Date: Sat Jan 7 17:13:03 2023 -0700
concrete network object id
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Drew Lewis
James Cherry
Drew Lewis