Commit Graph

1544 Commits

Author SHA1 Message Date
Wilson Snyder 7db7d3df0d Misc style cleanups 2020-02-23 20:18:02 -05:00
Wilson Snyder af84c975f1 Misc style cleanup. 2020-02-23 19:57:28 -05:00
Wilson Snyder 784e39131b Merge from master 2020-02-23 19:38:27 -05:00
Wilson Snyder 28e19cef90 Fix undeclared VL_SHIFTR_WWQ, #2114. 2020-02-23 19:33:37 -05:00
Yutetsu TAKATSUKASA be04672add single entry point for V3SplitVar 2020-02-16 15:42:29 +09:00
Tobias Wölfel 18f8cd0529
Allow assert disable (#2168)
* Add +verilator+noassert flag

This allows to disable the assert check per simulation argument.

* Add AssertOn check for assert

Insert the check AssertOn to allow disabling of asserts.
Asserts can be disabled by not using the `--assert` flag or by calling
`AssertOn(false)`, or passing the "+verilator+noassert" runtime flag.
Add tests for this behavior.
Bad tests check that the assert still causes a stop.
Non bad tests check that asserts are properly disabled and cause no stop
of the simulation.

Fixes #2162.

Signed-off-by: Tobias Wölfel <tobias.woelfel@mailbox.org>

* Correct file location

Signed-off-by: Tobias Wölfel <tobias.woelfel@mailbox.org>

* Add description for single test execution

Without this description it is not obvious how to run a single test from
the regression test suite.

Signed-off-by: Tobias Wölfel <tobias.woelfel@mailbox.org>
2020-02-15 18:17:23 -06:00
Yutetsu TAKATSUKASA 241e54e7b3 Tested with all existing cases after changing the code to split everything.
The following tests fail. Explanation is here.

- Failure because extra warnings
    - vlt/t_a1_first_cc: %Error: Exec of perl failed: No stack.
        make -j && test_regress/t/t_a1_first_cc.pl  --vlt
    - vlt/t_a2_first_sc: %Error: Exec of perl failed: No stack.
        make -j && test_regress/t/t_a2_first_sc.pl  --vlt
    - vlt/t_flag_debugi9: %Error: Exec of perl failed: Starting Verilator 4.029 devel rev v4.028-114-g8e707db3 (mod)
        make -j && test_regress/t/t_flag_debugi9.pl  --vlt
- Failures because the statistics changes
    - vlt/t_split_var_0: %Error: File_grep: obj_vlt/t_split_var_0/Vt_split_var_0__stats.txt: Got='26' Expected='23' in regexp: (?^i:SplitVar,\s+Split unpacked arrays\s+(\d+))
        make -j && test_regress/t/t_split_var_0.pl  --vlt
    - vlt/t_split_var_1_bad: %Error: Line 1 mismatches; obj_vlt/t_split_var_1_bad/vlt_compile.log != t/t_split_var_1_bad.out
        make -j && test_regress/t/t_split_var_1_bad.pl  --vlt
    - vlt/t_split_var_2_trace: %Error: VCD miscompare obj_vlt/t_split_var_2_trace/simx.vcd t/t_split_var_2_trace.out
        make -j && test_regress/t/t_split_var_2_trace.pl  --vlt
    - vlt/t_unopt_combo_isolate: %Error: File_grep: obj_vlt/t_unopt_combo_isolate/Vt_unopt_combo_isolate__stats.txt: Regexp not found: (?^i:Optimizations, isolate_assignments blocks\s+5)
        make -j && test_regress/t/t_unopt_combo_isolate.pl  --vlt
    - vlt/t_unopt_combo_isolate_vlt: %Error: File_grep: obj_vlt/t_unopt_combo_isolate_vlt/Vt_unopt_combo_isolate_vlt__stats.txt: Regexp not found: (?^i:Optimizations, isolate_assignments blocks\s+5)
        make -j && test_regress/t/t_unopt_combo_isolate_vlt.pl  --vlt
    - vlt/t_xml_tag: %Error: Line 26 mismatches; obj_vlt/t_xml_tag/Vt_xml_tag.xml != t/t_xml_tag.out
        make -j && test_regress/t/t_xml_tag.pl  --vlt
- SplitVar changed error message by other pass.
    - vlt/t_bitsel_wire_array_bad: %Error: Line 1 mismatches; obj_vlt/t_bitsel_wire_array_bad/vlt_compile.log != t/t_bitsel_wire_array_bad.out
        make -j && test_regress/t/t_bitsel_wire_array_bad.pl  --vlt
    - vlt/t_lint_multidriven_bad: %Error: Line 9 mismatches; obj_vlt/t_lint_multidriven_bad/vlt_compile.log != t/t_lint_multidriven_bad.out
        make -j && test_regress/t/t_lint_multidriven_bad.pl  --vlt
    - vlt/t_gen_forif: %Error: Exec of perl failed: %Warning-CLKDATA: t/t_gen_forif.v:35: Clock used as data (on rhs of assignment) in sequential block 't.Result'
        make -j && test_regress/t/t_gen_forif.pl  --vlt
    - vlt/t_unoptflat_simple_2_bad: %Error: Exec of perl ok, but expected to fail
        make -j && test_regress/t/t_unoptflat_simple_2_bad.pl  --vlt
- Because of other issue https://github.com/verilator/verilator/issues/1008#issuecomment-581078519
    - vlt/t_select_bound1: %Error: Exec of perl failed: %Error: t/t_select_bound1.v:23: Unsupported: 4-state numbers in this context
        make -j && test_regress/t/t_select_bound1.pl  --vlt
2020-02-12 09:41:44 +09:00
Wilson Snyder 39119b88d3 Code style changes. No functional change. 2020-02-09 18:58:48 -05:00
Wilson Snyder ac552b0efb Format standardizations (capitals/spaces), no logical change. 2020-02-09 18:27:04 -05:00
Wilson Snyder d201ce40a0 Use newer warning format. 2020-02-09 18:08:19 -05:00
Wilson Snyder 1c3b8229b4 Merge from master. 2020-02-09 17:39:23 -05:00
Wilson Snyder 0d6ebf21b3 Suggest svSetScope, #2152. 2020-02-07 17:59:02 -05:00
Todd Strader 77f1b3eef4 Support parameter access from arrays of interfaces, #2155. 2020-02-06 19:19:23 -05:00
Wilson Snyder 20cc4e57d5 tests: Driver style fix. 2020-02-03 18:43:56 -05:00
Yutetsu TAKATSUKASA d151a9bd22 Merge remote-tracking branch 'upstream/master' into split_var0 2020-02-03 23:28:29 +09:00
Wilson Snyder 2576c136f6 Fix `pragma pedantic check to work with -E. 2020-02-01 22:03:18 -05:00
Yutetsu TAKATSUKASA 50fb7fc8b4
Tests: Resolve self assignment in t_unoptflat_simple_2, Closes #2149. 2020-02-01 19:07:02 -05:00
Wilson Snyder 2d195ebae5 Cleanup IEEE references. 2020-01-30 20:23:57 -05:00
Yutetsu TAKATSUKASA 3abd3cb648 Merge branch 'master' into split_var0 2020-01-30 21:00:11 +09:00
Wilson Snyder d218f1746c Add warning on genvar in normal for loop, #2143. 2020-01-29 21:16:44 -05:00
Yutetsu TAKATSUKASA 8d8eb1b9f3
Tests: Resolve racing among initial blocks in t_display_signed.v, #2144. 2020-01-29 17:07:45 -05:00
Wilson Snyder d4614c290e Fix WIDTH warning on </<= of narrower value, #2141. 2020-01-28 20:10:10 -05:00
Tobias Rosenkranz 027cce35c0 Support enum.next(k) with constant k > 1, #2125. 2020-01-27 17:25:25 -05:00
Wilson Snyder 9fd81b2c6b Support string character access via indexing. 2020-01-26 16:38:22 -05:00
Wilson Snyder 5430e4ac9b Cleanup more errors showing data types. 2020-01-26 15:54:57 -05:00
Wilson Snyder 619214b48f Support $sampled. 2020-01-26 13:38:15 -05:00
Wilson Snyder 68fa82fb14 Support $typename, and use to cleanup error messages. 2020-01-26 13:21:25 -05:00
Wilson Snyder cac50282eb Fix pattern replication without key. 2020-01-26 11:38:34 -05:00
Wilson Snyder b50ef9ff39 Tests: Disabled test for 5.9. 2020-01-26 11:23:52 -05:00
Wilson Snyder 8a8f1135b7 Support type(expression) operator, #1650. 2020-01-26 10:28:13 -05:00
Wilson Snyder 708fd36563 Tests: Show entering/exit so goto-error works on compile errors. 2020-01-24 22:40:19 -05:00
Wilson Snyder a4e8d39932 Spelling fixes 2020-01-24 20:10:44 -05:00
Wilson Snyder 8f0e8e0696 Fix FST tracing of enums inside structs. 2020-01-24 19:46:46 -05:00
Pieter Kapsenberg 957c1d606b Add detailed XML location to cell elements, #2134, #2122.
This was accidentally omitted from the previous PR #2122.
2020-01-22 07:18:50 -05:00
Stefan Wallentowitz 22088c907f
Set maximum number width (#2128)
Adjust the maximum number width to 64K. Add --max-num-width option to
adjust this setting.

Closes #2082
2020-01-21 12:17:31 +01:00
Pieter Kapsenberg 4a122fd0f2 Add detailed location to XML output (#2122)
* Add detailed location to XML output

* Fixing build failures

* less cryptic regulary expressions

* correcting typo in test

* Adding file letter to the location attribute, and cleaning up the regular expression in the tests.

* Add remaining test expected output files for XML changes

* spacing fix, adding documentation on changes
2020-01-20 14:08:13 -05:00
Yutetsu TAKATSUKASA 34a6499218
Merge branch 'master' into split_var0 2020-01-19 07:04:10 +09:00
Yutetsu TAKATSUKASA 74edc5cff4 When split unpacked arrays, use SplitUnpackedVarVisitor just once 2020-01-18 22:43:56 +09:00
Wilson Snyder 7024ea8cb6 Cleaner tristate error. #2117. 2020-01-18 07:56:50 -05:00
Wilson Snyder 16f4ceb5ba Internals: Create VL_DO_DANGLING. No functional change intended. 2020-01-18 07:44:40 +09:00
Yutetsu TAKATSUKASA a31a942586 Add a test for unpacked_array[small:big] case. 2020-01-18 07:42:48 +09:00
Yutetsu TAKATSUKASA e73f00ed9a Update per PR comments. 2020-01-18 07:42:07 +09:00
Wilson Snyder 623c4ec103 Internals: Create VL_DO_DANGLING. No functional change intended. 2020-01-16 20:17:11 -05:00
Yutetsu TAKATSUKASA 6f051c7a6b fix tests 2020-01-16 08:02:52 +09:00
Yutetsu TAKATSUKASA fad2f6748b update t_split_var_2_trace 2020-01-16 00:23:01 +09:00
Yutetsu TAKATSUKASA e9fcd6eb25 split_var supports assignment of unpacked arrays. 2020-01-16 00:18:14 +09:00
Pieter Kapsenberg 4443ab34fd Support left justified . Closes #2101. 2020-01-15 07:32:45 -05:00
Wilson Snyder 81e8127168 Add parameter values in XML. #2110. 2020-01-14 18:51:20 -05:00
Yutetsu TAKATSUKASA a1b3d57fe2
Merge branch 'master' into split_var0 2020-01-15 08:45:49 +09:00
Wilson Snyder 47803c3591 Tests: Better message for contributors. 2020-01-14 17:49:04 -05:00