Commit Graph

9062 Commits

Author SHA1 Message Date
Brian Taylor 2c6434aec9 Example for 7490a Pspice subckt. This exercises jkff, logicexp, and pindly conversions to XSPICE. 2023-07-24 11:00:32 -07:00
Brian Taylor 49f5f5134a Prevent crashes in udevices.c when malformed U* instances are present. This would happen with incorrectly written U* gates, ff, latches which do not conform to the PSpice specs. Instead, ERROR messages are output which, hopefully, will help a user to debug their subckt. 2023-07-21 16:33:03 -07:00
Brian Taylor 37cfc47ef9 Merge branch 'pre-master' into bt_dev 2023-07-21 14:50:14 -07:00
Giles Atkinson 3f3c4dc6aa Allow netlist lines to grow during parameter substitution,
removing a 25-character limit on the size of string parameters.
2023-07-21 08:47:10 +02:00
Giles Atkinson 1876e59aaf Fix the NAND and NOR variants of XSPICE code model multi_input_pwl
and add an example of its use with the E-source NAND variant.
2023-07-21 08:47:04 +02:00
Giles Atkinson 53b1bf1800 Fix Bug 584 - "XSPICE dac_bridge model shows incorrect output timing."
Remove reliance on exact breakpoint timing and tidy code.
2023-07-21 08:46:54 +02:00
Holger Vogt ef38b54d3c Change message from Circuit2 to Parse 2023-07-21 08:40:26 +02:00
Brian Taylor 50b9a55392 Simplify expression nesting depth. 2023-07-11 09:48:16 +02:00
Brian Taylor 1e58692e6d The channel data needs to be freed for some 2D Cider devices. This shows up with some of the examples/cider/parallel circuits. 2023-07-11 09:48:10 +02:00
Brian Taylor 5c11814f9e Simplify expression nesting depth. 2023-07-09 16:30:00 -07:00
Brian Taylor 5d305c3064 The channel data needs to be freed for some 2D Cider devices. This shows up with some of the examples/cider/parallel circuits. 2023-07-05 15:58:15 -07:00
Brian Taylor eddb775fc7 Merge branch 'pre-master' into bt_dev. Resolve conflicts. 2023-07-04 07:04:20 -07:00
Holger Vogt c6edbe44db Move extern declaration to the top, out of any function.
Thus remove VC2022 compiler warnings.
2023-07-04 12:07:41 +02:00
Brian Taylor f3b83fd4e4 Tidy up sp_shutdown with Cider. 2023-07-04 11:46:40 +02:00
Brian Taylor b63f6e7905 When Cider models are present, a normal batch mode sp_shutdown (for example, ngspice -b cmosinv.cir) will call com_quit(NULL). This cleans up so that valgrind will find no leaks in Cider devices after sp_shutdown. To disable this feature, set the environment variable CIDER_COM_QUIT="OFF". Even though it really does not matter that Cider memory is cleared just before exit, it makes it cleaner for valgrind checks. 2023-07-04 11:46:35 +02:00
Holger Vogt 486b74f728 Prevent a crash if p==NULL (due to buggy input) 2023-07-04 11:45:27 +02:00
Brian Taylor a13e08b8b0 Tidy up sp_shutdown with Cider. 2023-07-03 16:19:13 -07:00
Brian Taylor 1b433a32ba When Cider models are present, a normal batch mode sp_shutdown (for example, ngspice -b cmosinv.cir) will call com_quit(NULL). This cleans up so that valgrind will find no leaks in Cider devices after sp_shutdown. To disable this feature, set the environment variable CIDER_COM_QUIT="OFF". Even though it really does not matter that Cider memory is cleared just before exit, it makes it cleaner for valgrind checks. 2023-07-03 15:22:38 -07:00
Brian Taylor a2ca37401b Merge branch 'pre-master' into bt_dev 2023-07-03 13:31:00 -07:00
dwarning 4c4a9c78ec ifft: in case input array is smaller then output array - fill in the rest with zero to prevent uninitialzed plot variables 2023-07-03 10:07:32 +02:00
dwarning e83fae11bc same array size for in- and output in inverse fft function from fftw3 2023-07-02 16:16:51 +02:00
Brian Taylor 40a89b16e6 Fix the Cider memory leaks from setupContacts. TWOdestroy needed to free the contact nodes. 2023-06-30 11:03:53 +02:00
Brian Taylor 92dcb76251 Add DEVmodDelete functions to reduce memoory leaks in Cider models. The model memory was not freed during remcirc or quit. In the future, some of the code duplication could be refactored. The cmosinv.cir is now down to just 1 memory leak. 2023-06-30 11:03:42 +02:00
Brian Taylor fe26418374 Fix the Cider memory leaks from setupContacts. TWOdestroy needed to free the contact nodes. 2023-06-29 17:43:34 -07:00
Brian Taylor ec895536a6 Add DEVmodDelete functions to reduce memoory leaks in Cider models. The model memory was not freed during remcirc or quit. In the future, some of the code duplication could be refactored. The cmosinv.cir is now down to just 1 memory leak. 2023-06-28 22:11:11 -07:00
Brian Taylor 61a2c168dd Merge branch 'pre-master' into bt_dev 2023-06-28 20:50:35 -07:00
Brian Taylor cbda9ab7b5 The CONTACT statement does not apply to 1D devices. 2023-06-25 21:25:26 +02:00
Brian Taylor 42a8bafd10 Fix some more memory leaks in the CIDER 1D and 2D destroy functions. 2023-06-25 21:24:57 +02:00
Brian Taylor b6ae618233 The CONTACT statement does not apply to 1D devices. 2023-06-25 08:42:31 -07:00
Brian Taylor 00740ea126 Fix some more memory leaks in the CIDER 1D and 2D destroy functions. 2023-06-24 18:25:29 -07:00
Brian Taylor 56362529ba Merge branch 'pre-master' into bt_dev 2023-06-24 17:34:02 -07:00
Giles Atkinson d4c4ac7937 Fix sluggish output of the "Reference value" progress indicator on Linux
after it switched from stderr to stdout (28a3413).  Add fflush().
2023-06-24 17:24:21 +02:00
Giles Atkinson b62c9b1ef3 Make the returned status of the "shell" command available as interpreter
variable "shellstatus".  Also change the default shell to /bin/sh
as csh is now rare.
2023-06-24 17:24:15 +02:00
Giles Atkinson e0cc583669 Set default colours for the button box in the X11 plot window that
match the default dark background of the plot.
2023-06-24 17:24:09 +02:00
Brian Taylor 0f15c1ab96 Add missing FREE to reduce some of the Cider memory leaks. 2023-06-20 22:57:34 +02:00
Brian Taylor 1ffa456328 Add missing FREE to reduce some of the Cider memory leaks. 2023-06-20 11:34:07 -07:00
Brian Taylor 1c1ceb4d9d Merge branch 'pre-master' into bt_dev 2023-06-20 11:12:34 -07:00
Giles Atkinson 22b5a859d0 Further fix for PWL bugs introduced by 9c71db3 (Fix for Bug #607) and
partially fixed by 79c69e0 and 9c75367.  This also fixes Bug #468 -
"Bugs in src/spicelib/devices/vsrc/vsrcacct.c for PWL source."
2023-06-20 20:01:51 +02:00
Giles Atkinson 1a056f935c Add an option to the iplot command: -d sets the number of simulation
steps before the window is shown.  The value can be chosen to
limit rapid resizing when starting and that is used in the PLL examples.
2023-06-20 20:01:41 +02:00
Giles Atkinson 8ce190e7d6 Improve commands for vector scales. "setscale" can now change
or clear the scale of an individual vector and "compose" can
explicitly create a vector from XSPICE event node history.
2023-06-20 20:01:31 +02:00
Holger Vogt 64cbf224b5 Error print output consistenly only to stderr.
Replace out_printf by fprint(stderr, ...
2023-06-20 19:56:55 +02:00
Holger Vogt 3fd7bd2183 Prevent crash when ControlledExit* is not initialized
in ngspice shared library.
2023-06-18 10:32:01 +02:00
Holger Vogt 8d9695d7d6 Fix bug 637
Prevent crash when external current source is used.
2023-06-18 10:29:43 +02:00
Holger Vogt 82796a6fa6 Prevent crash if EXTERNAL voltage source is used
Fixes
98763c0ad ("Note: ix: dc value used for op instead of transient time=0 value Former warning message or note only issued when dc value and value at transient time=0 differ.", 2022-09-20)
2023-06-14 15:34:45 +02:00
Holger Vogt 5761b71ecd improve comment 2023-06-13 20:06:27 +02:00
Holger Vogt a244e023c4 Prevent crash if *line == NULL 2023-06-13 20:05:49 +02:00
Holger Vogt 818bd19798 Revert "Prevent crash if *line == NULL"
This reverts commit b72f9516ac.
2023-06-13 20:02:27 +02:00
Holger Vogt 216e5cb58b Skip title line when resorting .params, .meas, .temp 2023-06-13 19:57:19 +02:00
Holger Vogt b72f9516ac Prevent crash if *line == NULL 2023-06-13 19:56:07 +02:00
Giles Atkinson 2740d9a79b Fix Bug #635 - "Starting ngspice with HOME env variable unset causes segfault". 2023-06-13 19:54:49 +02:00