a5a1029998
d_source: Use STATIC_VAR_TABLE to save memory
2012-08-25 13:39:27 +02:00
3d7ab6a297
cleanup keyword databases on proram termination
2012-08-23 21:19:15 +02:00
80bc975e33
plug a memory leak in inp_spsource/inp_nutsource (deck title string)
2012-08-23 21:13:44 +02:00
84283b43d4
cleanup ivars() related globals on program termination
2012-08-23 21:09:25 +02:00
f4ad29a17c
d_source: allow multiple instances
2012-08-22 23:14:26 +02:00
83c99bece4
cleanup wallace arrays on program termination
2012-08-22 22:21:33 +02:00
590fc543f8
avoid error messages when finally closing the display device.
...
these messages creeped in with commit
2012-08-19 18:58:31
"plug memory leak in x11.c"
when the "printf" device Close and Update
functions might be invoked on program termination.
use the silent "nop" implementation
instead of the error reporting "nodev" implementation
2012-08-20 21:26:08 +02:00
7191fdce63
d_source cfunc.mod: plug memory leaks
2012-08-20 08:54:26 +02:00
488bc6a8c8
bug no. 3456221: new d_source model
2012-08-19 21:36:33 +02:00
b5b0ec7302
cleanup, white space changes
2012-08-19 21:36:31 +02:00
6c01089be1
plug memory leak in x11.c
...
try to obey the Xt toolkit protocol when closing widgets and application
2012-08-19 19:18:34 +02:00
cb42989204
mifgetvalue.c: need a copy to allow freeing token
2012-08-19 15:49:24 +02:00
789edee376
rewrite inp_list() avoid duplicate code
2012-08-19 14:04:37 +02:00
c9e2a21a9c
reimplement tcl_vfprintf()
2012-08-19 12:53:55 +02:00
c4d0feb6cc
bug fix, out_send() erroneously interpreting printf %-style sequences
2012-08-19 12:20:33 +02:00
b9b9f6fd1c
cleanup (checked for code invariance)
2012-08-19 12:14:22 +02:00
5ca213b481
part of temperature level=3 model
2012-08-18 21:10:48 +02:00
67132108ad
out_printf() is not supposed to be a preprocessor macro
2012-08-18 18:40:45 +02:00
0af75f3bd9
subckt.c, mif_inp2.c: plug XSPICE setup memory leaks
2012-08-18 18:31:23 +02:00
d4ced47e8e
drop out_pbuf, which was an ancient workaround
...
obviously an old implementation of out_printf()
has been unreliable.
2012-08-18 18:27:13 +02:00
0825c10471
bug fix, print complex yet real valued frequency
...
when printing a complex frequency vector, yet with real value
some left over nonsens was printed instead of the actual real value.
this bug was introduced in commit:
Date: Thu Jan 15 21:08:09 2009 +0000
Improvements in vector derivative computation and new functions to
compute group delay and moving average. From espice (A. Roldan).
2012-08-18 17:10:06 +02:00
b02a497490
mif_inp2.c, subckt.c: plug memory leaks at XSPICE setup
2012-08-15 23:11:07 +02:00
9390a9a9ec
rewrite com_quit()
...
emphasize user confirmation
and if we are going to remove dangling circuits,
then do so unconditionally
2012-08-15 20:15:15 +02:00
be183407cd
cleanup (checked for code invariance)
2012-08-15 19:18:15 +02:00
ae6a16e3e4
plug a memory leak when executing `shell'
2012-08-14 21:00:21 +02:00
fa81e9d007
plug a memory leak when (un)setting variables
2012-08-14 20:39:11 +02:00
64139a243c
spiceif.c, cleanup (checked for code invariance)
2012-08-14 20:38:25 +02:00
0c230b2970
spiceif.c, cleanup (checked for code invariance)
2012-08-12 20:28:42 +02:00
10a9ae32c5
options.c cleanup
2012-08-12 12:48:27 +02:00
a2f58da0d0
options.c, whitespace
2012-08-12 12:43:09 +02:00
e93960f9ed
cleanup, if_options() will copy() anyway
2012-08-12 12:25:00 +02:00
7126dd6f1d
display.c, cleanup
2012-08-08 18:54:52 +02:00
0beb95757f
cancer of the semicolon
2012-08-07 21:20:36 +02:00
d50ffdd987
swallow warnings
2012-08-06 19:50:23 +02:00
1a2477bdcc
avoid `meas' syntax error causing segfault
...
Invalid meas crashes ngspice with SIGSEV - ID: 3554330
http://sourceforge.net/tracker/?func=detail&aid=3554330&group_id=38962&atid=423915
2012-08-06 19:42:49 +02:00
46980f2cc6
plotit.c #9/9, whitespace
2012-08-05 21:41:25 +02:00
4803d8bba2
plotit.c #8/9, braces
2012-08-05 21:41:25 +02:00
6a334da2b4
plotit.c #7/9, braces
2012-08-05 21:41:25 +02:00
f587553217
plotit.c #6/9, braces
2012-08-05 21:41:25 +02:00
088e88d9b2
plotit.c #5/9, localize
2012-08-05 21:41:25 +02:00
5f1387892c
plotit.c #4/9, line wrap
2012-08-05 21:41:25 +02:00
ed4ad1c0dd
plotit.c #3/9, drop some comments
2012-08-05 21:41:25 +02:00
5c43e8f2fc
plotit.c #2/9, emphasize maximize/minimize
2012-08-05 21:41:25 +02:00
406fc29007
plotit.c #1/9, think positive
2012-08-05 21:41:25 +02:00
11ae043c3d
com_measure2.c: enable 'meas dc' without 'from' and 'to' given
...
measure.c: no error printout during autostop
2012-08-05 20:03:00 +02:00
d6ba5e5b3f
cleanup free_struct_variable()
2012-08-05 12:22:47 +02:00
75c59a26fa
variable.c, cleanup (mostly whitespace)
2012-08-05 12:22:47 +02:00
99b167b272
correct alter of mos geometries for binned models
2012-08-05 12:11:16 +02:00
51271d2a0b
cp_oddcomm(), plug a memory leak
2012-08-04 22:27:04 +02:00
acfc7a2a27
remove memory leaks
2012-08-04 19:09:13 +02:00
2516a118a3
indentation
2012-08-04 16:24:38 +02:00
713091ea22
wlist #3/3, whitespace
2012-08-04 11:40:35 +02:00
fe5ac28b92
wlist #2/3, cleanup
2012-08-04 11:40:35 +02:00
406dcc3519
wlist #1/3, cleanup
2012-08-04 11:40:35 +02:00
05437b1d48
inpcom.c: safely uncomment unused subcircuits (top level only)
...
if they contain further nested subcircuits
2012-08-03 22:42:33 +02:00
9ed7ce4e9e
wlist.c, `const' ness
2012-08-03 21:46:13 +02:00
e4c7a8df32
use wl_find()
2012-08-03 20:48:11 +02:00
cf2a0f3df3
cleanup, linewrap
2012-08-03 20:43:12 +02:00
191ae9ea90
cleanup, char 0
2012-08-03 20:43:10 +02:00
5a69b9efc4
cleanup, void return
2012-08-03 20:43:06 +02:00
ef37252155
lexical, use wl_append_word()
2012-08-03 20:24:58 +02:00
62a4ee77d5
lexical #6/6, whitespace
2012-08-03 20:20:18 +02:00
ea558fbc7f
lexical #5/6, cleanup
2012-08-03 20:18:17 +02:00
aa188c0766
lexical #4/6, parentheses and braces
2012-08-03 20:16:47 +02:00
c73c0f4318
lexical #3/6, rewrite
2012-08-03 20:12:58 +02:00
5656203a6c
lexical #2/6, linewrap
2012-08-03 20:12:19 +02:00
5d245c9dab
lexical #1/6, cleanup
2012-08-03 20:09:34 +02:00
96d2ff96e0
alloc.c: exlude controlled_exit if not MS Windows
...
not available in some tests in cmaths and executable like ngproc2mod
2012-08-03 08:28:50 +02:00
64d00a6b43
lexical #3/3, collapse append(NULL) into cp_ccom()
...
the sequence
orig_wlist = wlist;
append(NULL);
cp_ccom(wlist, ...);
is transformed.
expressions to care about in cp_ccom()
C1 := (wlist->wl_next != NULL)
C2 := (wlist->wl_word != NULL)
C3 := wl_length(wlist)
D1 := (orig_wlist != NULL)
D2 := (orig_wlist->wl_word != NULL)
D3 := wl_length(orig_wlist);
cases and their significance in cp_ccom():
orig_wlist = NULL;
wlist = wl_cons(NULL, NULL);
C1 == false
D1 == false
C2,C3 dont care
orig_wlist = wl_cons(E1, wl_cons(E2, ... wl_cons(En, NULL)))
wlist = wl_cons(E1, wl_cons(E2, .... wl_cons(En, wl_cons(NULL, NULL))))
C1 == true
D1 == true
C2 === D2
C3 === D3 + 1
2012-08-02 18:55:54 +02:00
fec5b00a0d
lexical #2/3, fix memory leaks
2012-08-02 18:55:54 +02:00
042311d0c3
lexical #1/3, move append(NULL) invokations into position
2012-08-02 18:55:54 +02:00
67e0cf0608
undo controlled_exit: not compatible with ancient tests in cmath under LINUX
2012-08-01 22:10:13 +02:00
1195498978
lexical #19/19, rewrite
2012-07-31 20:49:34 +02:00
5b67ecda79
lexical #18/19, rewrite
...
`cw' won't be looked at, thus the append + removal can be dropped
`wl_word' is already NULL
2012-07-31 20:49:34 +02:00
f990e517b5
lexical #17/19, rewrite
2012-07-31 20:49:34 +02:00
fa9be4336a
lexical #16/19, transform append --> append(word)
2012-07-31 20:49:34 +02:00
43a6d59c72
lexical #15/19, drop `delayed' which is never zero ...
2012-07-31 20:49:33 +02:00
47b5e9576d
lexical #14/19, drop `delayed = 0' wherever its effect isn't visible
...
without effect, because we return or will overwrite it anyway
2012-07-31 20:49:33 +02:00
01df4e9437
lexical #13/19, delay `append'
...
delay its execution, until
either `wlist' or `cw' will be accessed,
or
a return or goto nloop is inevitable
2012-07-31 20:49:33 +02:00
cff6188fe3
lexical #12/19, use `append'
...
some `assumption' are no longer valid
2012-07-31 20:49:32 +02:00
5ad8382cf1
lexical #11/19, aproach `append' here
2012-07-31 20:49:32 +02:00
d61f3c10a0
lexical #10/19, split off `append' from `newword'
2012-07-31 20:49:32 +02:00
af0a0c2c03
lexical #9/19, aproach the `append'
...
cw has never been NULL here,
because we used to survive an update of cw->wl_next here
wlist hasn't been NULL either,
because there is no place where wlist becomes NULL without
setting cw to NULL as well. yet cw isn't NULL (see above)
aproach the `append'
2012-07-31 20:49:31 +02:00
74cc38f67a
lexical #8/19, express where `wlist' and `cw' start being != NULL
2012-07-31 20:49:31 +02:00
3cbc4b0773
lexical #7/19, express verbosely where `wlist' and `cw' are NULL
2012-07-31 20:49:31 +02:00
ecb2eec279
lexical #6/19, express cp_ccom() property
2012-07-31 20:49:31 +02:00
3b575d5e3d
lexical #5/19, collapse into `newword'
2012-07-31 20:49:30 +02:00
348dc2d7d1
lexical #4/19, the `else' can take that job (unconditionally)
2012-07-31 20:49:30 +02:00
80191f3d44
lexical #3/19, attach and instantly remove a NULL wl_word here
...
this modification is faithful iff cw != NULL and cw->wl_next == NULL
cw != NULL because we have just survived an update of cw->wl_word
cw->wl_next == NULL is witnessed by:
1) cw either NULL or pointing to a wl_cons(,NULL)
2) cw not being modified, and no wl_next being modified
3) check of all function invocations with wlist/cw argument
not to modify any wl_next slot
which are:
1) cp_ccom(wlist, ...)
2) wl_free() always followed by goto nloop, which does a cw = wl_cons(,NULL)
and cp_ccom() doesn't modify any wl_next slot
the first part of the patch is intentionally similar to newword
`i' and `buf' can be modified here, because we will inevitably `goto done'
attach and instantly remove a NULL wl_word here
2012-07-31 20:49:30 +02:00
ddebb63425
lexical #2/19, rewrite the `else if'
2012-07-31 20:49:29 +02:00
f2f43bcce7
lexical #1/19, use wl_cons
2012-07-31 20:49:29 +02:00
f36772419a
Revert "cleanup, use wl_cons()"
...
This reverts parts of commit 7a7250cdbd
2012-07-31 20:48:01 +02:00
b85f6bbc7d
controlled_exit() instead of exit()
2012-07-31 17:54:51 +02:00
207adefcda
evtprint.c: no node data: error message instead of seg fault
2012-07-30 23:32:54 +02:00
64b8dfc570
use wl_delete_slice()
2012-07-29 13:11:43 +02:00
cdef8aa10e
implement wl_delete_slice()
2012-07-29 13:11:42 +02:00
d793dd6a61
variable xtrtol may override the XSPICE reduction of trtol
2012-07-29 12:53:31 +02:00
26468839d4
plotit(), cleanup wordlist processing
2012-07-28 19:55:09 +02:00
608e0473d3
copy(), allow NULL argument
2012-07-28 19:53:55 +02:00
b808fcec8a
fix typo in the commit `use wl_find()'
2012-07-28 14:52:17 +02:00
3c3ba4c731
inpgmod.c: correct the range check to prevent overlap
2012-07-28 13:44:33 +02:00
fd85e8fd42
indentation
2012-07-28 13:39:00 +02:00
891d99497d
use wl_find()
2012-07-28 12:29:23 +02:00
e2be942b72
implement wl_find()
2012-07-28 12:29:22 +02:00
60398d113c
plotit.c, prepare for usage of wl_find()
2012-07-28 12:29:19 +02:00
7a7250cdbd
cleanup, use wl_cons()
2012-07-27 21:50:05 +02:00
1754427bee
enhtrans.c: indentations
2012-07-25 23:05:28 +02:00
20429eec4d
message "OpenMP: %d threads are requested..." removed
2012-07-25 23:04:13 +02:00
9b122d30a3
enhtrans.c, improved error meassage upon non 'Exxx poly' line bug
2012-07-24 22:04:31 +02:00
12e60822fb
measure.c: indentations
2012-07-23 23:26:20 +02:00
ed5491c179
measure.c: Update on error message for .meas
2012-07-23 23:23:42 +02:00
d1d2ff94e4
measure, error message updated and return(NAN) in case of measure failure
...
test for failure with isnan()
2012-07-23 22:57:32 +02:00
05e5854268
plotit.c, whitespace cleanup
2012-07-23 19:17:25 +02:00
512644ca34
rewrite using wl_ functions
2012-07-22 11:58:29 +02:00
cd2cab2a94
bug fix, cp_ioreset(): fclosing an already closed stream
...
causing memory corruption when using `>&' stderr redirection
2012-07-22 11:56:25 +02:00
4d0d0fafb9
repair broken ternary function in B-Source
...
failed if parameters were included in function.
fixed by finding nested parens in gettok_char()
2012-07-21 22:23:49 +02:00
c3141d94e0
table: prevent crashes upon wrong inputs, allow time, temper, hertz as part of device or node name (e.g. Rtime), remove some memory leaks
2012-07-21 21:18:24 +02:00
1e65ea9e80
rewrite using wl_ functions
...
this fixed following bug as well:
echo "echo abra ; ; echo kadabra" | ngspice -p
building a circular list and looping forever
2012-07-21 18:22:10 +02:00
561d30e5bf
implement wl_chop()
2012-07-21 14:42:18 +02:00
87c80b842c
gettok_char(), return(NULL) if substring not found
2012-07-19 23:16:15 +02:00
fee664bc19
untabify
2012-07-19 20:26:13 +02:00
31ee05ceef
mw_coms.c, fix the cleanup using wl_cons()
2012-07-19 20:25:06 +02:00
8d0306c27a
cpif.c, whitespace, indentation, cleanups
2012-07-19 20:15:33 +02:00
75d6f6da5e
cpitf.c, cleanup using wl_ functions
2012-07-19 20:15:30 +02:00
3062e25184
mw_comms.c, whitespace, indentation, cleanups
2012-07-19 18:49:27 +02:00
95978d3697
mw_coms.c, cleanup using wl_cons()
2012-07-19 18:49:25 +02:00
2b859633a1
fix the fix wl_reverse() for empty lists
2012-07-15 19:42:09 +02:00
a890a55937
fix wl_reverse() for empty lists
2012-07-14 12:39:13 +02:00
5859f1a61d
comments for wl_cons(), wl_append_word() and wl_chop_rest()
2012-07-14 12:39:02 +02:00
9655b9885a
cleanup, use wl_cons(), wl_append_word() and wl_chop_rest()
2012-07-14 10:23:51 +02:00
d9ddaec784
implement wl_cons(), wl_append_word() and wl_chop_rest()
2012-07-14 09:18:39 +02:00
8defa56cf6
remove second call to tmpfile()
2012-07-14 00:10:21 +02:00
2a22c1b23c
bug fix, missing update of a wordlist's wl_prev pointer
2012-07-12 20:44:53 +02:00
e1f8033f1c
bug fix, incorrect update of a wordlist's wl_prev pointer
2012-07-12 18:49:01 +02:00
4ca6e56863
printf() ---> out_printf(): allow output redirection into file
2012-07-11 18:56:19 +02:00
9b34d99e51
emphasize the adms3 `U' device hijack
2012-07-07 20:13:05 +02:00
84b58ebd3b
don't mess with libtools --enable-static / --enable-shared
...
tie libspice to -shared
ngspice et al to -static
and use $(STATIC) elsewhere
which is governed by configure.ac
2012-07-07 14:51:43 +02:00
cb0a48801d
introduce AM_CFLAGS = $(STATIC)
2012-07-07 14:51:39 +02:00
a0b64a8624
spfactor.c, indentations
2012-07-07 10:04:21 +02:00
2bff8985e3
Adding TD to the fopen() is sufficient in MS Windows
...
to reliably unlink the temporary file
2012-07-07 09:53:35 +02:00
c9b729032d
no double count of area for capacitances
2012-07-04 22:41:56 +02:00
dcc22ada60
new scalable diode model including tunnel component
2012-07-04 08:14:33 +02:00
cc44d34f70
tmpfile() on MS Windows
...
create temporary files with Microsoft specific fopen() flags "TD"
and (propably redundant) remove them with an atexit() handler
see bug report #3535348
"sp*.tmp file created, but not deleted when Windows UAC is en"
https://sourceforge.net/tracker/?func=detail&atid=423915&aid=3535348&group_id=38962
2012-07-03 18:38:30 +02:00
3a603cf17c
Visual Studio: isatty --> _isatty
2012-07-02 19:45:43 +02:00
14914025c0
measure_at(), allow real valued data for meas ac
2012-06-26 23:43:50 +02:00
0207dc7239
no exchange of ' ' by { } inside .control section
2012-06-26 23:28:31 +02:00
188acd0060
correct usage of `unlink()' error return value -1
2012-06-25 15:13:02 +02:00
4a75ce744d
dioload.c, diosetup.c, correct knee current parameter defaults
2012-06-25 07:43:27 +02:00
a7ffb7d69f
dio/dioload.c, whitespace change
2012-06-25 07:31:03 +02:00
f661a1032d
bug fix, ltra and tra, (initial conditions)
...
reported in
https://sourceforge.net/tracker/?func=detail&atid=423915&aid=3535544&group_id=38962
bug was introduced in this commit:
Date: Wed Dec 31 17:02:46 2003 +0000
Cleaned up LTRA, TRA and URC code and updated DEVICES file.
2012-06-16 13:06:28 +02:00
9648238ed7
call omp_set_num_threads once in central place instead in model routines
2012-06-15 23:14:08 +02:00
b398d39772
xpsice, use the CFLAGS when linking .cm code models
2012-06-13 19:15:28 +02:00
9ea4897d06
use unified macro USE_OMP and nthreads is set in setup once - not in load as clause
2012-06-13 19:15:27 +02:00
fde8c46356
add ac and dc simulation to memristor model
2012-06-13 19:15:25 +02:00
f53eb5cf78
memristor code model in extradev
2012-06-13 19:15:24 +02:00
7bfd4edefc
FABS() --> fabs()
2012-06-13 19:15:23 +02:00
ff11ccda20
In B source the argument to 'log' may be 0 upon start of simulation, allow recovery like in function 'ln'
2012-06-13 19:15:22 +02:00
0a087a47c8
enable B source debugging in behavioral models, exit on error if variable strict_errorhandling is set
2012-06-13 19:15:21 +02:00
07727f74f0
commands.c: 'options' equivalent to 'option' and allow 'loadsnap' and 'savesnap'
...
which have been EXPERIMENTAL_CODE so far
2012-06-13 19:15:14 +02:00
1c4f960b45
update `bsim3soi' aka `b4soi'
2012-06-13 19:15:07 +02:00
5bb4c56165
outitf.c, cleanup
2012-06-12 21:26:31 +02:00
05fd5a03d6
outitf.c, cleanup cancer of the semicolon
2012-06-12 21:26:31 +02:00
4202354704
outitf.c, cleanup comment
2012-06-12 21:26:31 +02:00
ccea57570e
outitf.c, cleanup return
2012-06-12 21:26:31 +02:00
486ffc9429
outitf.c, whitespace
2012-06-12 21:26:31 +02:00
c78d71c363
.nodeset all = value added to set all voltage nodes at once
2012-06-12 21:26:31 +02:00
a34cbdbeab
tiny cleanup
2012-06-12 21:26:30 +02:00
b1cbebaa99
fix tcl module compilation
...
test programs don't compile when compiling for TCL_MODULE
due to redefinition of fprintf()
2012-06-12 21:26:30 +02:00
6ae6223250
misccoms.c, com_quit(), implement exitcode
2012-06-12 21:26:30 +02:00
5436de5bab
misccoms.c, tiny rewrite
2012-06-12 21:26:30 +02:00
8dcf132199
misccoms.c, shrink scope
2012-06-12 21:26:30 +02:00
cc32eae60b
misccoms.c, collect byemessage()
2012-06-12 21:26:30 +02:00
b9c0159cd6
misccoms.c, noask
2012-06-12 21:26:30 +02:00
41de8d95ff
misccoms.c, collapse strings
2012-06-12 21:26:30 +02:00
11878ee4ad
misccoms.c, use strncasecmp()
2012-06-12 21:26:30 +02:00
5f3b453a30
misccoms.c, indentation and whitespace cleanup
2012-06-12 21:26:30 +02:00
f65cdd2f84
Changed line ending of several files from DOS to UNIX
2012-06-12 21:26:29 +02:00
3d34b22ebf
fix file modes
2012-06-12 21:26:29 +02:00
a212be67bc
Exit with error if file not found: fgets() cannot read from NULL
2012-06-12 21:26:29 +02:00
14f884729c
raw_write() always fopen("wb"), even on windows use "\n" line termination
2012-06-12 21:26:29 +02:00
10e5dbfbcc
raw_read() always fopen("rb") even on windows, always swallow "\r"
2012-06-12 21:26:29 +02:00
e598598d70
Reverting "NUMDdump(): add binary mode"
...
This reverts commit 40e8f868da
2012-06-12 21:26:29 +02:00
d8105873db
remove error.h, use fteext.h for controlled_exit()
2012-06-12 21:26:29 +02:00
a9eb96e164
avoid `ambiguous else' Warning
2012-06-12 21:26:29 +02:00
023374fa79
update `making xspice' within actual ngspice
2012-06-12 21:26:27 +02:00
40e8f868da
NUMDdump(): add binary mode
...
fopen() with wb
write operating point (external state) for true binary output
2012-06-12 21:26:27 +02:00
80ca57eb76
beautify code
2012-06-12 21:26:27 +02:00
d65259fd45
error return only if variable `error' is set
2012-06-12 21:26:27 +02:00
ca8e9b2d2d
prevent false outputs of @dev[param], when not defined in ac simulation
2012-06-12 21:26:27 +02:00
fe86d3d5c7
Enable ctrl-c to interrupt a simulation also for Windows GUI
2012-06-12 21:26:27 +02:00
a820a7cba8
Independent variable `temper' now returns the temperature in degree C
2012-06-12 21:26:27 +02:00
a51953d93e
allow `time', `temper', and `hertz' in expressions of behavioral R,L,C devices
2012-06-12 21:26:27 +02:00
bde3536ecc
subckt.c, doit(): fix another memory leak
2012-06-12 21:26:27 +02:00
e3402554f0
subckt.c, doit(): fix a memory leak
2012-06-12 21:26:27 +02:00
dcde15afd2
exclude circuits with XSPICE 'A' devices from using 'savesnap'
...
XSPICE data storage is not yet implemented
2012-06-12 21:26:26 +02:00
58b0614467
fix memory leaks in ASRC and in INPgetTree()
...
implement a reference counter `usecnt' for the elements
of the `INPparseTree'
2012-06-12 21:26:26 +02:00
4fb75fbd51
INPgetTree(), express the live range of some globals
2012-06-12 21:26:26 +02:00
d21b3a3cd5
mkfnode(), minor rewrite
2012-06-12 21:26:26 +02:00
e889c821d1
configure.ac, fix `NO_X' and `has_no_help'
...
drop configure options `--enable-x' and `--disable-x'
use `--with-x' and `--without-x' provided by AC_PATH_X
bug tracker item:
[ngspice-Bugs-3515015] Startup error message without x11
https://sourceforge.net/tracker/index.php?func=detail&aid=3515015&group_id=38962&atid=423915
2012-04-06 16:19:49 +02:00
7641450b29
inpptree.c, fix differentiation of PTF_FLOOR PTF_CEIL and PTF_POW
2012-04-05 21:55:44 +02:00
149345068f
update bison generated files
2012-04-05 21:33:54 +02:00
3bb2bd8e05
fix memory leak in PTparse()
2012-04-05 21:30:41 +02:00
15bda2b9e0
fix memory leak in PPparse()
2012-04-05 21:30:05 +02:00
76336fa21b
fix memory leak in cp_vset()
2012-04-05 21:25:04 +02:00
9a75774e36
inpptree.c, polish comments
2012-04-05 21:24:48 +02:00
42653f7c3d
inpptree.c, fix premature memory allocation
2012-04-05 21:24:25 +02:00
3375e1b976
fix a memory leak in parse_line()
...
This has a HUGE affect on memory usage
2012-04-05 20:49:09 +02:00
8b780fa42b
bug_fix: R,L,C instantiations, tc1, tc2, numbers followed by `:'
...
Ternary function was not recognized in R, C, or L lines
if no voltage or current node was part of the expression,
because then B-Source is not used.
In these cases now inp_fix_ternary_operator_str() is called explicitly.
tc1, tc2 were sometimes recognized falsely,
if part of a token e.g. tc1end.
R, C, and L models are never commented out,
because their names may be token no. 4 or 5 in an R, C, or L line,
and will not be recognized if 5.
INPevaluate() will now correctly evaluate a number if followed by ':'
(number may be part of the ternary function).
2012-03-31 23:42:37 +02:00
232270cbc4
bug fix, inp_bsource_compat(): `tc1=' `tc2=' `reciproctc=' `}'
...
don't substitute `tc1=' `tc2=' `reciproctc='
don't fail when processing tokens followed by `}' chars
2012-03-30 22:56:15 +02:00
e91e3c4ec7
lingrid(), avoid buffer overflow
...
Bug ID: `Buffer overflow detected - ID: 3510521'
reported by Zsolt Makaró
The variable `mag3' sometimes seems to take
unexpected values
(for example log10 can be -Inf, which will be casted to 0x80000000)
and seems then to have overflown a buffer buf[LABEL_CHARS]
2012-03-27 21:07:12 +02:00
6e829f7cc4
rewrite subckt.c
...
transform doit() into a true recursive version,
drop usage of global variables
reduce scope of many variables
cleanup and readability
FIXME,
an opportunity to plug a memory leak is visible now.
2012-03-25 20:19:42 +02:00
da06afb895
bug fix, numnodes()
...
in response to the `ex-41.cir' test case
distilled from a Dietmar Warning Bug report in
"Subject: Re: subckt, param"
translate() is called recursively and depends on
`num of nodes' provided by numnodes().
numnodes() depends on availability of `su_numargs'.
But the processing allows non-processing of subckt instantiations
in inner recursions (which will be processed later)
which means `su_numargs' is not always available.
2012-03-25 18:54:10 +02:00
a1ea1b3193
round to next nearest integer for the rise, fall and cross arguments of `measure'
...
Simon Guan reported
Bug item #3509528 , `Meas goes wrong when put in a while loop'
In a .control block a `let' variable was passed to the `measure' command.
The value of this variable would have been a plain integer,
yet it was converted internally to an internal ascii representation
with exponential representation (203 ==> 2.03e2)
and then processed by `ft_numparse()' where it was converted back to
double floating point.
Because the intermediate 2.03 has
no exact representation in the space of double floating point numbers
this conversion was lossy and resulted in a non-integer value.
This non-integer was then truncated towards minus infinity in com_measure
yielding an error of -1
This commit implements round to nearest in com_measure2
to avoid the problem.
FIXME,
the internal intermediate conversion of double floating point machine
values to ascii representations must be dropped,
or replaced with an exact/lossless ascii representation.
(for example GNU printf/scanf %a or 64bit hexadecimal representation)
2012-03-25 11:08:48 +02:00
b4516b08ca
bug fix, iplot(): Buffer overflow
...
Thanks to Zsolt Makaró for the bug report in
Buffer overflow detected - ID: 3510521
http://sourceforge.net/tracker/?func=detail&aid=3510521&group_id=38962&atid=423915
2012-03-24 18:29:36 +01:00
0a2e031cb1
bug fix, inp_fix_subckt(): problem when parsing a .subckt line
...
this worked
.subckt psub a b p2 = {p1*2-1} p1 = 1
but this failed
.subckt psub a b p2 = { p1 * 2 - 1 } p1 = 1
thanks to Ivan Riis Nielsen for the report in Message
[Ngspice-devel] parsing problem (ngspice-24 tarball)
2012-03-24 18:29:36 +01:00
4b1abe0a18
tclspice.c: new functions to get start and final time of a transient simulation
2012-03-24 18:29:36 +01:00
787a6a3581
inp_fix_subckt(): allow spaces in an expression which acts as a parameter
2012-03-17 16:56:30 +01:00
1938041e10
1. Correct the list of binable models. 2. Fix a problem with wrong MOS level entries.
2012-03-01 20:33:06 +01:00
9f017ea557
.gitignore files
2012-02-26 16:19:58 +01:00
80a039983e
dummy functions
2012-02-19 16:38:33 +00:00
70e9907415
Add reciprocal temperature behaviour for B sources
2012-02-19 12:55:54 +00:00
8f3f757813
command mrdump
2012-02-19 11:11:31 +00:00
dffe4ed156
command mdump
2012-02-19 10:23:56 +00:00
862f10dce3
Add temperature coefficients for B sources
2012-02-11 19:52:04 +00:00
d9561123f9
Add temperature coefficients for B sources
2012-02-11 19:45:25 +00:00
1a7fa85e3c
reading incs, libs etc.
2012-02-11 13:14:34 +00:00
fc7692a896
outheap removed
2012-02-11 12:50:44 +00:00
5d101f46f9
updates tcl for Windows
2012-02-11 11:59:12 +00:00
848b0c2158
update bison generated files
2012-02-11 08:18:57 +00:00
6ea91d2834
upgrade INPgetTree()
2012-02-11 08:17:12 +00:00
37940c9133
search for tclspinit in `cwd' as well
2012-02-10 16:59:33 +00:00
86ea7c5290
NG_IGNORE something
2012-02-10 16:57:21 +00:00
d041b7b503
Typo in parameter name
2012-02-10 16:12:39 +00:00
d0f5ad49d1
make use of TMALLOC()
2012-02-09 20:46:12 +00:00
2e4d4a0e02
unuse srandom() and random()
2012-02-09 20:39:24 +00:00
fce7548bd2
#4/4 finish the switch from ngcomplex* args to ngcomplex
2012-02-07 19:55:20 +00:00
a056ea3065
#3/4 switch realpart() and imagpart() args from ngcomplex* to ngcomplex
2012-02-07 19:53:12 +00:00
94e3abd847
#2/4 switch cph() and cmag() args from ngcomplex* to ngcomplex
2012-02-07 19:49:31 +00:00
50aea0be0c
#1/4 drop cast (enable compiler type check)
2012-02-07 19:46:34 +00:00
891e4fdef1
fix varags usage, tcl_printf(), tcl_fprintf(), tcl_vfprintf()
2012-02-07 19:22:02 +00:00
f38aa32b5f
adms3, fix some types
2012-02-07 18:43:57 +00:00
e396b15104
use type `struct ccom'
2012-02-07 17:45:41 +00:00
f70fd8ea1b
use type `runDesc'
2012-02-07 17:43:07 +00:00
5df8e981e5
struct runDesc forward declaration
2012-02-07 17:28:27 +00:00
c3741ae6a1
comment/pinpoint a local misuse of a structure element
2012-02-07 17:25:55 +00:00
bfb8cb259c
drop some (char*) casts
2012-02-06 20:23:55 +00:00
d04f0948d6
preserve const'ness of some casts
2012-02-06 20:21:47 +00:00
c54d3a617e
drop (void*) cast of the dispose() argument
2012-02-06 20:18:26 +00:00
8864048692
drop tgetstr() return value cast
2012-02-06 20:15:45 +00:00
cc7afb7abb
drop (char*) cast in the third argument of ioctl()
2012-02-06 20:13:35 +00:00
d5f6bcbedf
drop some more casts
2012-02-06 20:11:10 +00:00
d03d5dfa2d
drop some casts
2012-02-06 20:07:43 +00:00
e800751d3e
drop some (char*) casts
2012-02-06 20:03:50 +00:00
a716572233
rewrite INPlookMod(), return INPmodel*/NULL instead of int 1/0
2012-02-06 17:49:19 +00:00
f285dd0aa8
use strchr() instead of index()
2012-02-06 17:46:33 +00:00
d2f9fe7379
tlevc=1 correction
2012-01-30 19:57:57 +00:00
b4424c9d2c
define NAN for non C99 environments
2012-01-28 11:57:43 +00:00
131e40dab9
prevent crash upon 'reset' (MS Windows only)
2012-01-28 10:35:04 +00:00
0511b35114
tlevc=1 correction
2012-01-24 22:47:06 +00:00
49815fce99
bug fix, a numerical problem in the hisim2 an hisimhv models
2012-01-15 17:19:35 +00:00
7ad22c41f4
add missing .cvsignore file
2012-01-13 17:21:57 +00:00
dc2938812b
revert last commit, simply insane
2012-01-13 16:47:32 +00:00
8b4cbf05c9
wrap isnan declaration, isnan is a macro on modern systems
2012-01-11 19:17:51 +00:00
467c9381a6
fix printf/scanf format strings to match `unsigned long long' arguments
2012-01-11 19:12:15 +00:00
757bf30cc9
bug during loading ascii rawfile removed
2012-01-09 22:44:40 +00:00
a74eba86c5
update bison generated files
2012-01-08 18:26:33 +00:00
4b9eca2b38
bug fix, broken vdb() vph()
2012-01-08 18:22:07 +00:00
f17b14102c
bug fix, incorrect '%le' printf format specifier
2012-01-08 10:26:36 +00:00
f7f454c0a1
bug fix, fix the guard for device generated internal nodes (via CKTmkVolt())
2012-01-07 18:38:05 +00:00
33764b1f91
cleanup, muffle compiler warning
2012-01-07 14:48:55 +00:00
30abcd3c32
bug fix, CKTcurJob, make sure this is either up do date or NULL
2012-01-07 10:53:10 +00:00
60adbdc716
bjt missing model message
2012-01-05 22:25:18 +00:00
393da34c66
undo change from 1.1.12: no reset enforcement
2012-01-03 20:59:46 +00:00
29442c91c8
cleanup, muffle compiler warning
2012-01-02 19:43:02 +00:00
4aa17534fb
xspice bug fix, invoke EVTsetup(ckt) only when `reset'
2012-01-02 13:04:14 +00:00
92063d602a
controlled_exit() shall not block waiting for a keyboard press
2012-01-02 12:52:56 +00:00
598238f46a
conditionally compile PSS analysis
2012-01-02 12:31:22 +00:00
cf793b3760
fix tarball, spinit.in was missing
2012-01-01 18:19:34 +00:00
2784ae5aa9
enforce reset
2012-01-01 16:21:49 +00:00
d2f9faf66b
.lib handling
2012-01-01 13:58:03 +00:00
4d35b4ce7b
partially undo commit 2011-12-27 Holger Vogt
2011-12-30 19:53:26 +00:00
7d4802c369
memory leak, struct bsim3v32SizeDependParam
2011-12-30 19:20:57 +00:00
7a2b51b485
memory leaks reduced
2011-12-30 18:54:44 +00:00
f1b516f1b1
cleanup, drop `s_lower'
2011-12-30 18:08:48 +00:00
62d3847c8a
cleanup scope of `y' and `z'
2011-12-30 17:50:17 +00:00
ebc01fc265
cleanup scope of `keep_char' and `s_lower', drop `s_ptr'
2011-12-30 17:48:55 +00:00
9f10f87dd9
cleanup, drop variable `found_library'
2011-12-30 17:46:37 +00:00
79436a3bb8
cleanup scope of variable `newfp'
2011-12-30 17:44:52 +00:00
aedbc6b7be
cleanup scope of variable `big_buff2'
2011-12-30 17:43:41 +00:00
01b87ac2c6
cleanup scope of variable `dir_name_flag'
2011-12-30 17:40:45 +00:00
d2f2456ce7
bug fix, copys not always valid
2011-12-30 17:38:56 +00:00
6382f60644
remove a bug in inc. handling
2011-12-30 17:06:10 +00:00
c7ddee5923
remove CVS `Id',`log' etc. keyword incantations
2011-12-30 15:52:45 +00:00
171e8896b1
.csparam
2011-12-30 09:32:17 +00:00
7e96dcc639
remove memory leaks
2011-12-30 08:59:03 +00:00
127213bff0
reduce memory leaks for run - reset
2011-12-29 19:31:14 +00:00
4aa91d22a5
install headers in $(pkdatadir)/include/ngspice
2011-12-29 15:21:53 +00:00
0d5e569aca
cleanup src/Makefile.am
2011-12-29 14:35:45 +00:00
69031273fb
generate spinit and tclspinit at `make' time
2011-12-29 14:29:44 +00:00
4755e416e3
install codemodels in $(pkglibdir)
2011-12-29 14:25:21 +00:00
fe11eae0ce
reduce memory leaks
2011-12-28 14:11:08 +00:00
829fbafb85
reduce memory leaks
2011-12-28 12:43:40 +00:00
323bceb33b
#5/6 config.h --> ngspice/config.h, some more -I include paths
2011-12-27 12:09:21 +00:00
d3c3741f43
#4/6 config.h --> ngspice/config.h, AM_CPPFLAGS
2011-12-27 12:07:52 +00:00
afa1371746
#3/6 config.h --> ngspice/config.h, AM_CPPFLAGS
2011-12-27 12:05:51 +00:00
4ca58067a2
#2/6 config.h --> ngspice/config.h, #include's
2011-12-27 11:33:01 +00:00
ee48c0952a
#1/6 config.h --> ngspice/config.h, configure.ac
2011-12-27 11:31:10 +00:00
3e98e15a20
cleanup
2011-12-27 11:12:51 +00:00
b32f935e8b
.lib error messages
2011-12-27 08:46:19 +00:00
75767fcc3d
floor(), ceil() added
2011-12-26 11:34:21 +00:00
9bbf9bc549
remove 'params:' from x and .subckt lines of input deck
2011-12-25 13:01:45 +00:00
94e9f07b90
Gxxx n1 n2 TABLE {expression} = (x0, y0) (x1, y1) (x2, y2)
2011-12-21 21:33:47 +00:00
d6e616a310
remove CVS `Id',`log' etc. keyword incantations
2011-12-17 18:35:11 +00:00
0d7f64657c
move stringutil.h --> src/include/ngspice
2011-12-17 17:16:29 +00:00
33d8e0ce9d
Gxxx n1 n2 value={equation}
2011-12-17 15:22:20 +00:00
af03c472af
adms3, use -ldl instead of -lltdl, fix include path
2011-12-17 13:45:39 +00:00
0e1f5a29f7
type fixes
2011-12-17 13:41:04 +00:00
bcc23c1f78
exit on all circuit parsing errors if var strict_errorhandling is set
2011-12-17 11:33:30 +00:00
54501d90e0
beautify code
2011-12-16 21:55:28 +00:00
f7ea50c287
new: configure --enable-adms3
2011-12-15 20:44:45 +00:00
47aea417dd
fixed pointer assignment: from SPICEadmsdev* to SPICEdev*
2011-12-15 20:24:22 +00:00
bab7e17a6a
added SPICEadmsdev - a super structure of SPICEdev used to build dynamic device libraries
2011-12-15 15:34:50 +00:00
83b3487c9c
renamed premint.xml to prengspice.xml.
2011-12-14 22:21:58 +00:00
66b6674f6b
xml file that does preformating of verilog files.
2011-12-14 22:17:58 +00:00
f8f1e1f974
add routine load_vadev to public definitions.
2011-12-14 22:03:56 +00:00
65458e3c80
add routine load_vadev for dynamic loading of modules.
2011-12-14 22:01:10 +00:00
d674333db9
add dynamic loading of models. shared libs should be libNAME.so.
2011-12-14 21:50:15 +00:00
102cf08670
use u instance as dynamically defined models in --adms mode
2011-12-14 21:42:02 +00:00
0b5042e7da
remove CVS `Id',`log' etc. keyword incantations
2011-12-13 19:57:45 +00:00
7d75ebcb81
unify OUTpBeginPlot() invocation
2011-12-13 19:10:34 +00:00
c09058038c
unify OUTpBeginPlot() usage of ckt->CKTcurJob
2011-12-13 19:08:15 +00:00
a7ac45c9cb
rename various analysis vars --> `job'
2011-12-13 18:04:28 +00:00
dea9c539c2
auxiliary define `job' --> local variable `job'
2011-12-13 18:02:14 +00:00
ef04192ec0
auxiliary define (ANALYSIS*) anal --> `job'
2011-12-13 18:00:23 +00:00
5333ab2a4b
switch --adms3 over to the new adms3va directories
2011-12-13 17:48:28 +00:00
206769d241
undo `2011-12-12 Laurent Lemaitre' which broke --adms in favour of --adms3
2011-12-13 17:45:57 +00:00
5449731860
copy old amds .va files to a new directory `adms3va'
2011-12-13 17:40:29 +00:00
0779816dbb
remove CVS `Id' and `log' keyword incantations
2011-12-12 21:59:21 +00:00
55a87d1b81
Make veriloga models compliant with Language Reference Manual. They will not compile with --adms flag.
2011-12-12 21:02:18 +00:00
e117c389b3
Set name of model C routines unique - make linker happy.
2011-12-12 20:46:25 +00:00
88374b8c70
#4/4 #include <ngspice/...> --> #include "ngspice/..." for adms3
2011-12-11 18:17:39 +00:00
225f5aef19
#3/4 #include <ngspice/...> --> #include "ngspice/..." for adms
2011-12-11 18:16:09 +00:00
4e3cc188d9
#2/4 #include <ngspice/...> --> #include "ngspice/..."
2011-12-11 18:12:36 +00:00
10346e055c
#1/4 #include <ngspice/...> --> #include "ngspice/..."
2011-12-11 18:05:00 +00:00
87d9383971
use a macro to update ckt->CKTstat->STAT..
2011-12-11 14:50:18 +00:00
fd9dec37a3
auxiliary define `job' --> local variable `job'
2011-12-11 11:37:07 +00:00
f8f4e32875
auxiliary define (ANALYSIS*) ckt->CKTcurJob --> `job'
2011-12-11 11:34:38 +00:00
56d000f77b
variable rename `sen_info' `cv' `pzan' `sen_info' --> `job'
2011-12-11 11:31:37 +00:00
a463c761d8
similiarity dctran.c versus dcpss.c
2011-12-11 11:28:20 +00:00
e8a55e807f
add dynamic loading feature
2011-12-10 09:05:35 +00:00
513bf853a9
cleanup, aiming for higher similarity of dctran.c and dcpss.c
2011-12-03 10:40:23 +00:00
8f09de4e4a
bug fix, parameter assignment was broken for expressions containing one of '<=' '>=' or '!='
2011-12-03 09:10:07 +00:00
03c098d4a0
bug fix, parameter processing was broken for nested .subckt
2011-11-30 18:02:27 +00:00
f82ec99542
command 'remcir' to remove a circuit updated
2011-11-27 10:29:44 +00:00
0ea3e30805
wrdata now prints complex variables and recognizes 'appendwrite'
2011-11-25 23:04:09 +00:00
68b99db7e9
some docu added
2011-11-13 14:44:00 +00:00
e065e1c290
reordering, fcn prototypes
2011-11-13 12:04:15 +00:00
9dbb7654eb
beautify code: indentations etc.
2011-11-13 11:11:09 +00:00
7152c01751
xspice/icm/GNUmakefile.in, add missing `uninstall' target
2011-11-03 17:05:38 +00:00
e42fa8ba06
swallow warnings
2011-10-31 10:53:51 +00:00
04c0e0c6b5
swallow warnings in hisimhv and hisim2 code
2011-10-31 10:51:33 +00:00
e6c7a506ec
Fix the source/drain typo for overlap cap's, for mos2 as well
2011-10-31 10:48:27 +00:00
304417112b
Fix the source/drain typo for overlap cap's
2011-10-30 21:03:38 +00:00
e3fa1bf7b4
Update to actual hisimhv model version 1.2.2
2011-10-30 20:59:47 +00:00
0589d22cf9
update bison generated files
2011-10-16 15:25:02 +00:00
c139875468
bug fix, allow special nodenames "/Node" and "Node-4" in `B' expressions
2011-10-16 15:22:56 +00:00
f2626d48e0
multiple .model section in altermod
2011-10-02 08:29:03 +00:00
893fbe1264
warning 'real ac' removed
2011-09-18 09:08:40 +00:00
c858975529
faster Greens's fft, altermod command
2011-09-18 09:03:55 +00:00
ccd115c6e2
Error message on exceeding resolution limit
2011-09-11 12:55:30 +00:00
cd639a007c
psp102 module name change
2011-08-28 09:11:47 +00:00
15c4c12755
mextram name change
2011-08-24 19:27:51 +00:00
41c14d7df4
adms, fix an extra backslash
2011-08-24 16:12:03 +00:00
aaf3f9da1b
prototypes, and avoid a NULL dereference when PZDEBUG is active
2011-08-21 18:04:33 +00:00
146069952d
avoid segfault when printing aout a nonexistant `ReferenceValue' (pzan)
2011-08-21 17:33:48 +00:00
4cbfbad8b5
type long --> int
2011-08-21 10:43:07 +00:00
026a471d51
use unlink() instead of remove()
2011-08-21 08:55:58 +00:00
1a9ef50edf
#7/7 use a subdirectory "ngspice" for includes to create a uniq namespace
2011-08-20 17:51:14 +00:00
884ed12334
#6/7 use a subdirectory "ngspice" for includes to create a uniq namespace
2011-08-20 17:49:37 +00:00
028915d9ae
#5/7 use a subdirectory "ngspice" for includes to create a uniq namespace
2011-08-20 17:47:44 +00:00
5a4f4ada5c
#3/7 use a subdirectory "ngspice" for includes to create a uniq namespace
2011-08-20 17:45:23 +00:00
738d3813b8
#2/7 use a subdirectory "ngspice" for includes to create a uniq namespace
2011-08-20 17:43:07 +00:00
d26015586c
#1/7 use a subdirectory "ngspice" for includes to create a uniq namespace
2011-08-20 17:27:09 +00:00
bc8a0d4f24
update bison generated files
2011-08-20 15:34:31 +00:00
73c9cce851
the i() and v() function application have special semantics
2011-08-20 15:33:26 +00:00
53ac5a888a
remove maths/fft/fftext.h
2011-08-20 08:24:36 +00:00
220cc83458
fft calculation with type double (instead of float)
2011-08-19 20:46:23 +00:00
56229ce907
improved error message
2011-08-19 20:30:18 +00:00
6a1f801038
code beautified
2011-08-19 20:06:29 +00:00
ee5de05933
postsc.c, swallow warnings
2011-08-14 13:54:09 +00:00
83abdaac55
devhelp prints headers when asked for a single parameter.
2011-08-14 07:28:44 +00:00
0cf889d590
twoprint.c, swallow warnings
2011-08-13 16:13:16 +00:00
f360d06d18
update bison generated files
2011-08-13 16:10:41 +00:00
830829ba56
bison files, swallow warnings
2011-08-13 16:08:16 +00:00
cca4047f8f
adms, fix parallel execution when using make -j
2011-08-12 19:30:56 +00:00
afb4ad7921
pull two -adms3 fixes into -adms
2011-08-12 15:18:41 +00:00
f8e41f9fb5
remove second incarnation of `grid.h'
2011-08-12 09:31:52 +00:00
1cbe685d4c
include path for error.h
2011-08-11 16:39:37 +00:00
57c9b44c73
inproved error messages in pipe mode
2011-08-10 16:39:46 +00:00
890d049a5b
uic to end of line in pss
2011-08-09 19:58:40 +00:00
h_vogt
rlar
dwarning
Michael Woodworth
r29173
pnenzi