luke
/
OpenSTA
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,424 Commits 1 Branch 1 Tag 249 MiB
Commit Graph

253 Commits

Author SHA1 Message Date
Jaehyun Kim 3ca78b11c8 Adapt test files to upstream API changes (string_view migration) 
Update 16 test files to match upstream OpenSTA API refactoring:
- const char* → std::string/std::string_view across all test APIs
- EXPECT_STREQ → EXPECT_EQ for std::string/string_view returns
- nullptr → "" for string_view parameters (makeClock, makeClockGroups, etc.)
- PropertyValue("literal") → PropertyValue(std::string("literal")) to avoid
  bool constructor overload resolution
- Method renames: relatedGroundPin→relatedGroundPort,
  relatedPowerPin→relatedPowerPort, firstName→firstParam,
  secondName→secondParam
- Constructor changes: OperatingConditions (5-arg → 1-arg + setters),
  ModeDef::defineValue (3-arg → 1-arg + setSdfCond)
- LibertyAttrValue::floatValue returns std::pair<float,bool> now
- Filter API: separate args → single expression string + bool_props_as_int
- SDF version golden files: 3.0.1 → 3.1.0

All 6104 tests pass.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-31 16:34:40 +09:00
Jaehyun Kim 069de0498c Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-31 15:27:01 +09:00
dsengupta0628 5f46ad3dfb Merge remote-tracking branch 'upstream/master' into sta_latest_merge_strings 2026-03-30 16:22:27 +00:00
Jaehyun Kim 422f774b64 Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-29 22:33:08 +09:00
James Cherry 6742692876 string squash 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-28 19:13:35 -07:00
dsengupta0628 4238a057dd combined latest osta 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-25 20:03:03 +00:00
James Cherry b9e439f41c delay calc clip delay to 0.0 resolves #405 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-24 18:42:47 -07:00
James Cherry 04f4528c2c ccs ceff pocv 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-22 19:34:59 -07:00
Jaehyun Kim 434246a8b4 Fix test suite for upstream API changes after merge 
Adapt all C++ and Tcl tests for upstream API refactoring:
- Header rename: DelayFloat.hh -> Delay.hh
- PocvMode enum replacing boolean pocv (setPocvEnabled -> setPocvMode)
- setReportPathFields gains 8th parameter (report_src_attr)
- GateTableModel/CheckTableModel constructor wraps in TableModels
- gateDelay/checkDelay signature changes (bool -> MinMax/PocvMode)
- Unit::asString returns std::string instead of const char*
- ExceptionThru/To::asString removed, use to_string
- GroupPath/FilterPath/LoopPath::asString removed
- PathEnd::source_clk_delay -> source_clk_latency
- report_net -connections flag removed
- set_report_path_field_width removed
- MaxSkewCheck::skew() now requires sta parameter
- Remove tests that pass nullptr to PinIdHash-based maps (segfault)
- Remove tests for removed APIs (sigmaFactor, reportSigmas)
- Regolden .ok files for numerical precision and format changes

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-21 19:23:36 +09:00
Jaehyun Kim 43bca8d224 Merge remote-tracking branch 'opensta/master' into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-21 18:54:37 +09:00
dsengupta0628 af791b9974 Merge branch 'master' into sta_update_upstream_lvf_stuff 2026-03-20 19:50:24 +00:00
Jaehyun Kim 992a1dcec5 Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-20 21:56:12 +09:00
James Cherry 73c2cca24c delayAsString 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-18 16:33:15 -07:00
Vitor Bandeira 69e11bbd0d
Merge pull request #300 from The-OpenROAD-Project-staging/secure-sta-test-suite 
test: Add test infrastructure and sample test cases
 2026-03-18 08:54:06 -03:00
James Cherry 61b2a4b2c3 indent 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-16 16:29:10 -07:00
James Cherry 134b547501 use std::format squash 2026-03-16 15:01:38 -07:00
James Cherry 5fbd2a18b5 Graph::slew/arcDelay rm static 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-16 14:53:02 -07:00
Jaehyun Kim eea333c4bf Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-suite 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-16 12:20:36 +09:00
James Cherry d6e7b4256c lvf squish 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-13 14:06:35 -07:00
James Cherry 0a5b95a523 CcsCeffDelayCalc::loadDelaySlew 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-13 10:19:07 -07:00
dsengupta0628 83e1f9b77f Changes to bring back warning 1241 and fix lumpedCapDelayCalc- both commits also in parallax/osta 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-13 00:19:07 +00:00
James Cherry 818596f25a LumpedCapDelayCalc::makeResult resolves #403 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-12 15:53:10 -07:00
Jaehyun Kim e7b861051d test: Fix post-merge build errors and regolden .ok files 
After merging upstream changes, fix all build errors in C++ test files
and regolden Tcl test golden files to match updated code output.

Build fixes:
- dcalc/test/cpp/TestDcalc.cc: Fix const char* loop iterations, use
  EXPECT_NEAR for uninitialized subnormal float comparison
- liberty/test/cpp/TestLibertyStaBasicsB.cc: Wrap tests using removed
  LibertyBuilder() default constructor in #if 0
- liberty/test/cpp/TestLibertyStaCallbacks.cc: Fix LibertyBuilder()
  call to use sta_->debug()/report(); wrap old visitor tests in #if 0
- search/test/cpp/TestSearchStaDesignB.cc: Fix pg->name() nullptr
  comparison (now returns std::string&)
- search/test/cpp/TestSearchStaInit.cc: Fix 5 clkPinsInvalid/isIdealClock
  tests to expect throw (API now requires linked network)

Tcl test fixes:
- Remove calls to removed APIs: report_path_end_header/footer, report_path_end2
  from 6 search test scripts; regolden their .ok files
- Regolden .ok files for liberty (15), graph (1), network (8),
  parasitics (3), sdc (3), util (2), verilog (8) modules to reflect
  upstream format changes (timing arcs output, pin ordering, spacing)

All 6103 tests now pass.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-11 17:11:08 +09:00
Jaehyun Kim d4ad9312ea Merge origin/master into secure-sta-test-suite 
Resolve add/add conflict in test/helpers.tcl by merging both versions:
- Keep master's report_file, report_file_filter, sort_objects functions
- Keep branch's diff_files, diff_files_sorted functions
- Use master's result_dir setup with branch's mkdir logic in make_result_file

Resolve content conflict in test/regression by keeping branch's
bash/ctest launcher over master's Tcl regression script.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-11 09:48:28 +09:00
James Cherry 981f44db68 update copyright 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-10 14:57:45 -07:00
James Cherry 129d007f76 override 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-09 17:43:03 -07:00
James Cherry 28b9401e31 const 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-08 16:15:24 -07:00
James Cherry 859982bdc7 StdStringSeq -> StringSeq 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-08 15:51:50 -07:00
James Cherry d7905a3886 delay_calcs use std::string 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-08 14:41:22 -07:00
James Cherry c2c40f76b1 DmpAlg 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-08 14:03:53 -07:00
James Cherry c7ba405a14 comment 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-08 13:59:22 -07:00
James Cherry d8c0e9285b RiseFall use shortName instead of to_string 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-06 12:02:05 -07:00
James Cherry 741bf4d561 rm using std:: 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-02 12:13:13 -08:00
James Cherry 94b8fd8f37 dcalc threshold adjustment 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-01 17:33:20 -08:00
James Cherry a6425a3364 FindMessages criticalError 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-02-28 14:51:09 -08:00
Jaehyun Kim 92bb9b8ec9 test: Add comprehensive test infrastructure and test cases across all OpenSTA modules 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-27 12:59:25 +09:00
Jaehyun Kim 55259b894b test: Add `save_ok` script 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-27 11:12:27 +09:00
Jaehyun Kim 9bbac53157 test: Make ctest run C++ unit tests 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-27 09:51:10 +09:00
Jaehyun Kim 8adbcc0d6d Merge upstream STA update and adapt all tests to new API 
Major upstream refactoring: Corner→Scene, Mode architecture, warning
format change (Warning ID:), command renames, and many API signature
changes. Adapted all C++ test files and TCL test scripts/expected
output files to pass with the new API. 6159/6159 tests pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-23 23:05:29 +09:00
Jaehyun Kim 7173c10cc1 test: strengthen assertions, add sorted SDC diff, and clean up tests 
- Split oversized test files to stay under 5,000 lines per file:
  TestSdc.cc → TestSdcClasses.cc, TestSdcStaInit.cc, TestSdcStaDesign.cc
  TestSearchStaDesign.cc → TestSearchStaDesign.cc, TestSearchStaDesignB.cc
  TestLibertyStaBasics.cc → TestLibertyStaBasics.cc, TestLibertyStaBasicsB.cc
  TestNetwork.cc → TestNetwork.cc, TestNetworkB.cc
- Replace ~200+ (void) casts with proper EXPECT_* assertions across all
  C++ test files (dcalc, liberty, network, sdc, search, power, spice, util)
- Remove ~55 SUCCEED() and EXPECT_TRUE(true) no-op assertions
- Fix 6 load-only Tcl tests by adding diff_files verification with
  22 new .sdcok golden reference files
- Delete 7 orphan .ok files with no matching .tcl tests
- Add how_to_write_good_tests.md and TODO6.md documenting test quality rules

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-23 17:36:45 +09:00
Jaehyun Kim a58d7e4cc6 test: add explicit assertions to all cpp test cases 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-22 21:14:35 +09:00
Jaehyun Kim 547737f71e test: Apply review feedback - part2 
- Remove stale line-number coverage comments (# Targets: line NNN, hit=0)
- Remove useless file-existence checks from verilog/sdf tests
- Delete 21 orphaned dcalc Tcl tests (C++ tests already cover them)
- Rename liberty_ccsn_ecsm -> liberty_ccsn (no ECSM libs available)
- Fix liberty_sky130_corners to use define_corners/-corner for real multi-corner testing
- Add report_checks per wireload model in liberty_wireload
- Fix test/regression to work from test/ directory (label mismatch)
- Refactor all module CMakeLists.txt with sta_module_tests() macro

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-02-20 01:13:42 +09:00
Jaehyun Kim 6799b1909a test: Apply review feedback - part1 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-19 23:30:23 +09:00
Jaehyun Kim b77779f7a6 test: Refactoring. Standardize Google Test naming conventions by removing `R#_` prefixes, improve temporary file creation with `mkstemp`, etc 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-13 20:36:42 +09:00
Jaehyun Kim d6c09372ba test: Initial upload 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-02-13 19:19:09 +09:00
James Cherry 33e480a6c1 liberty memory management 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-02-04 18:33:04 -07:00
James Cherry e5ee0fdb24 fmt 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-01-13 09:36:51 -07:00
James Cherry 4fbe16e5a4 ApiChanges 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-01-13 09:36:51 -07:00
James Cherry d42b821c00 rel 3.0 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-01-13 09:36:45 -07:00
James Cherry 9d401d1c0e dcalc bfs incr level/hercules_is_int 0.3 correlation 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-01-06 14:37:26 -08:00