luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 10:03:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix bounds checking in non-inlined function (#6677)

Browse Source
This commit is contained in:
Geza Lore
2025-11-11 06:47:49 -05:00
committed by GitHub
parent eb40c24b78
commit c5f8656aa0
3 changed files with 25 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Unknown.cpp
+12 -8
View File
@@ -65,6 +65,16 @@ class UnknownVisitor final : public VNVisitor {
// METHODS
void addVar(AstVar* varp) {
if (m_ftaskp) {
varp->funcLocal(true);
varp->lifetime(VLifetime::AUTOMATIC_EXPLICIT);
m_ftaskp->stmtsp()->addHereThisAsNext(varp);
} else {
m_modp->stmtsp()->addHereThisAsNext(varp);
}
}
void replaceBoundLvalue(AstNodeExpr* nodep, AstNodeExpr* condp) {
// Spec says a out-of-range LHS SEL results in a NOP.
// This is a PITA. We could:
@@ -113,7 +123,7 @@ class UnknownVisitor final : public VNVisitor {
} else {
AstVar* const varp
= new AstVar{fl, VVarType::MODULETEMP, m_lvboundNames.get(prep), prep->dtypep()};
m_modp->addStmtsp(varp);
addVar(varp);
AstNode* stmtp = prep->backp(); // Grab above point before we replace 'prep'
while (!VN_IS(stmtp, NodeStmt)) stmtp = stmtp->backp();
@@ -137,13 +147,7 @@ class UnknownVisitor final : public VNVisitor {
AstVar* createAddTemp(const AstNodeExpr* const nodep) {
AstVar* const varp = new AstVar{nodep->fileline(), VVarType::XTEMP,
m_xrandNames->get(nodep), nodep->dtypep()};
if (m_ftaskp) {
varp->funcLocal(true);
varp->lifetime(VLifetime::AUTOMATIC_EXPLICIT);
m_ftaskp->stmtsp()->addHereThisAsNext(varp);
} else {
m_modp->stmtsp()->addHereThisAsNext(varp);
}
addVar(varp);
return varp;
}