Commit Graph

7253 Commits

Author SHA1 Message Date
Brian Taylor c3fa6328a1 Fix bug in the LOGICEXP scan_gates optimizer. Some gates with an inverting output were generated with bad logic which gave incorrect simulation results. 2024-03-29 17:29:49 +01:00
Holger Vogt 415d94bee0 Bug 665: enable compiling the code models with link time optimization.
Fix provided by Giles Atkinson.
Still the build of ngspice fails (tested with Cygwin) at the linking stage.
2024-03-29 17:27:43 +01:00
Holger Vogt ce8bce7947 Define the members of the struct in the correct sequence. 2024-03-29 17:23:59 +01:00
Holger Vogt cac87d9dd0 Improve response to error: reporting the error when
detecting an expression, not simply move on with a
wrong meas result.
2024-03-29 17:21:38 +01:00
Holger Vogt e561249e9b fix a bug in the ={par({...})} function.
The replacement did not happen correctly.
2024-03-29 17:19:48 +01:00
Holger Vogt ee39b2600b Add a evaluation function which truly removes also the
scale factor from the token when gobble=0 before
moving on.
2024-03-29 17:16:41 +01:00
Holger Vogt 49951cd197 Bug 664: Report an error if token in meas statement is not a vector and
cannot be evaluated as a number.
2024-03-26 20:08:08 +01:00
dwarning a1210a257d use only magnitudes in ac noise analysis even if openvaf compiled models deliver negative noise contributions 2024-03-26 19:59:23 +01:00
dwarning 7722c3dc6b only access to CKTkluMODE if KLU configured 2024-03-25 09:20:51 +01:00
Holger Vogt e27f093fb7 Prevent error: implicit declaration of function ‘get_local_home’
[-Werror=implicit-function-declaration], if editline is selected.
2024-03-16 23:18:13 +01:00
Holger Vogt 0c2c10eb9c add 'option klu' to printout 2024-03-16 23:13:03 +01:00
Brian Taylor 715ce8c809 Return correct error statuses. Detect another illegally placed gate operator in an infix expression. 2024-03-15 21:53:13 +01:00
Holger Vogt 603c730260 If TRACE is defined, print out everything without comment lines,
to improve readability.
Redo printing of global nodes when TRACE is defined.
2024-03-15 19:20:53 +01:00
Holger Vogt 054a65c2d5 Fix a bug in 'reset', where .subckt are not transformed
due to wrong line count in dynmaxline.
2024-03-15 19:20:47 +01:00
dwarning 7e39c10bee introduce jfet gate-drain and gate-source junction emission coefficient 2024-03-13 21:55:38 +01:00
Holger Vogt 65a91648ef temporary printout of deck 2024-03-13 17:27:33 +01:00
Brian Taylor 14bf034f28 The lexer incorrectly treats a single '_' '-' '/' as an identifier. The counter used for tmp__ names should be incremented after use. The infix_to_postfix converter now has more checks for invalid infix expressions in LOGICEXP constructs. Without these checks the evaluation of the generated postfix could silently create bad gates which would load but simulate incorrectly. All MicroCap and PSpice libraries and QEI.cir pass their tests. 2024-03-11 22:25:48 +01:00
Brian Taylor ae8e423d97 Add WARNINGs when there are potential name collisions, and identify the possible name. 2024-03-11 22:25:39 +01:00
Holger Vogt adb38ecb17 Upon error, bail out when strict_error is set. 2024-03-10 21:58:56 +01:00
dwarning 2dab26212a introduce diode breakdown voltage parameter alias vb 2024-03-10 09:47:17 +01:00
Holger Vogt f5c0a1420c Upon a warning on a model issue, ngspice should not bail out,
even if strict_error is set, as typically the simulation will
run and foreign models often have additional unsupported, but
less important parameters.

It shall however, exit if the simulation is interrupted due
to an error and strict_errorhandling is set.
2024-03-09 23:41:34 +01:00
Holger Vogt da51e1bddf Don't use printf(".."), but fprintf(stdout, "..."),
thus send an end-of-line also when redirected to file.
2024-02-28 10:06:31 +01:00
Holger Vogt a5f99a4953 Make PSP103_nqs standard, as it is used by the Open PDK from IHP 2024-02-23 14:12:49 +01:00
Brian Taylor 4c983e9133 Remove old dead code. 2024-02-23 14:06:39 +01:00
Brian Taylor 8788ce3504 Add check for a trailing } in a logicexp statement. 2024-02-23 14:06:28 +01:00
Brian Taylor 826401f6a4 Add error detection and reporting for invalid infix expressions. 2024-02-23 14:06:17 +01:00
dwarning adaa3d39fc no use for grouping in cx_fft and cx_ifft 2024-02-16 13:56:43 +01:00
dwarning 3201bcb09b prevent clang error 2024-02-16 10:12:09 +01:00
dwarning fd000c079b hicum2: use device temperature for noise analysis too 2024-02-15 18:19:11 +01:00
dwarning 3a18028283 vbic: use device temperature for noise analysis too 2024-02-15 18:09:38 +01:00
dwarning 305cd85c76 mos1...3: use device temperature for noise analysis too 2024-02-15 07:49:06 +01:00
dwarning a1dbd3f3c8 bjt, dio, jfet, res: use device temperature for noise analysis too 2024-02-14 18:16:50 +01:00
dwarning 20c82a5b1b format 2024-02-14 17:50:41 +01:00
dwarning e8f1cd4c92 too soon return - break is correct 2024-02-14 14:17:01 +01:00
dwarning 8d64381795 rm confusing comments and formatting 2024-02-14 14:14:15 +01:00
Holger Vogt b9c1f68ee0 Preliminary fix to bug report 660
Final setting will be decided before next release.
2024-02-13 14:04:58 +01:00
Brian Taylor e01290c9a2 Replace the logicexp parser with infix to postfix translation followed by evaluating the postfix. logicexp.c is now shorter and easier to understand and maintain. Also, operator precedence expression parsing conforms to the PSPICE rules. Thus, a & b | c is understood to mean (a & b) | c, for example. 2024-02-13 10:11:28 +01:00
Brian Taylor bd0f725776 There are approx. 47 out of 1455 subckts in PSPICE 9.1 libraries which contain X* subckt calls together with zero or more U* instances. Now this type of subckt can be translated to XSPICE. 2024-02-13 10:11:21 +01:00
dwarning 9ed7a24a0e mos1...3: Beta in noise w/o channel length modulation 2024-02-12 18:44:35 +01:00
dwarning 6359b7b41f mos1...3: add nlev=3 mode channel thermal noise 2024-02-12 18:44:35 +01:00
dwarning c2f0b1468c mos3mask: change unusual structure name 2024-02-12 18:44:35 +01:00
dwarning 89c7b83954 mos1...3: formatting and white spaces 2024-02-12 18:44:35 +01:00
dwarning 1381d71cb1 selectable flicker noise models for mos1...3 2024-02-12 18:44:35 +01:00
dwarning 2a6db71726 formatting mos1...3 noise code 2024-02-12 18:44:35 +01:00
dwarning 1c9f8b6345 two corrections in Ycor and NF formulae 2024-02-12 11:08:35 +01:00
Giles Atkinson 2ec5944dd4 Use all available precision when creating a "plot" command for a
zoomed window.  That prevents an unexpected zoom-out in one dimension
caused by a zero-height (or width) window being requested when zooming
with already high magnification.
2024-02-07 14:56:59 +01:00
Holger Vogt 7d1ea80a2e F source fails when VNAM contains math symbols like '-'.
Use INPgetNetTok for instance parameters
like it has been done for nodes already.
2024-02-02 11:15:14 +01:00
Holger Vogt c0b3511b20 compile with gcc-14 fails due to `-Werror=incompatible-pointer-types`
Patch provided by Mamoru Tasaka.
2024-02-02 11:12:24 +01:00
dwarning 1e8f9a411a rm obsolete order for spec blackman window 2024-01-26 08:32:18 +01:00
dwarning e0c3206601 partially revert commit aafd7bbb: spec triangular window 2024-01-26 07:45:27 +01:00