fix false positive in double-free detection, reported by updated track_memory.awk; fix missing free on allocated string

src/track_memory.awk

@@ -1,6 +1,10 @@
 #!/usr/bin/awk -f
-
-
+# memory leak analyzer. Run xschem with options "-d 3 -l log", do some operations you want to check
+# then *from this directory* launch: 
+# ./track_memory.awk /path/to/log
+# it will print the amount of leaked memory (total, leak) 
+# and the allocation that was not freed, with the source code line.
+# total and leak should indicate same amount of bytes, it is a cross check for the script.
 BEGIN{
   total = 0 
   malloc = 0
@@ -19,15 +23,19 @@ BEGIN{
   malloc++
 }
 
-# my_free():  freeing 198efc0
+# my_free(977,):  freeing 198efc0
 /^my_free\(/{ 
-  total -= address[$3]
-  delete address[$3]
-  delete idx[$3]
-  free++
+  if(!($3 in address)) {
+    print "Double free: " $0
+  } else {
+    total -= address[$3]
+    delete address[$3]
+    delete idx[$3]
+    free++
+  }
 }
 
-# my_realloc(235,): reallocating 0 --> 198efa0 to 24 bytes
+# my_realloc(235,): reallocating (nil) --> 198efa0 to 24 bytes
 # my_realloc(237,): reallocating 198efc0 --> 1cfc090 to 28 bytes
 /^my_realloc\(/{
   id = $1
@@ -49,7 +57,6 @@ BEGIN{
   realloc++
 }
 
-
 END{
   print "total = " total
   print "malloc = " malloc
@@ -57,19 +64,14 @@ END{
   print "free = " free
   stale = 0
   leak = 0
-
   for(i in address) {
-
-
-
- 
     stale++
     leak+= address[i]
     print "  address[ " i ", " idx[i] " ]= " address[i]
-    pipe = "grep -n ' \([^/][^*]\) *my_.*(" idx[i] ",' *.c xschem.h"
+    pipe = "grep -n ' \\([^/][^*]\\) *my_.*(" idx[i] ",' *.c xschem.h"
     while( pipe | getline a) print "    " a
     close(pipe)
   }
-  print "stale= " stale
-  print "leak= " leak
+  print "stale = " stale
+  print "leak = " leak
 }

src/xinit.c

@@ -614,6 +614,7 @@ void xwin_exit(void)
  translate2(NULL, 0, NULL); /* clear static data in function */
  subst_token(NULL, NULL, NULL); /* clear static data in function */
  find_nth(NULL, '\0', 0); /* clear static data in function */
+ tcl_hook2(NULL); /* clear static data in function */
  save_ascii_string(NULL, NULL, 0); /* clear static data in function */
  dbg(1, "xwin_exit(): removing font\n");
  for(i=0;i<127;i++) my_free(1140, &character[i]);
@@ -1473,7 +1474,8 @@ int Tcl_AppInit(Tcl_Interp *inter)
                 formats[i].direct.alpha_shift == 24)
                     format_rgba = formats[i];
     }
-    my_free(1145, &formats_reply);
+    free(formats_reply); /* can not use my_free() since not allocated by my_* allocator wrappers */
+    formats_reply = NULL;
     #endif /* HAS_XRENDER */
     /*/---------------------------------------------------- */
     /* /20171125 */