luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-07 10:01:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Internals: Optimize temporary memory allocations (#6517)

Browse Source 
This patch gets rid of over 80% of temporary dynamic memory allocations
(when a malloced node is immediately freed with no other malloc in
between). It also gets rid of over 20% of all calls to malloc.

It's worth ~3% average verilation speed up with tcmalloc, and more
without tcmalloc.
This commit is contained in:
Geza Lore
2025-10-01 15:01:30 +01:00
committed by GitHub
parent 435e1149d5
commit e9c48cd1ce
19 changed files with 218 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3PreProc.cpp
+7 -5
View File
@@ -195,6 +195,8 @@ public:
// For getline()
string m_lineChars; ///< Characters left for next line
string m_tokenBuf; // Token buffer, to avoid repeated alloc/free
void v3errorEnd(std::ostringstream& str) VL_RELEASE(V3Error::s().m_mutex) {
fileline()->v3errorEnd(str);
}
@@ -1687,7 +1689,7 @@ int V3PreProcImp::getFinalToken(string& buf) {
if (!m_finAhead) {
m_finAhead = true;
m_finToken = getStateToken();
m_finBuf = string{yyourtext(), yyourleng()};
m_finBuf.assign(yyourtext(), yyourleng());
}
const int tok = m_finToken;
buf = m_finBuf;
@@ -1748,10 +1750,10 @@ string V3PreProcImp::getline() {
const char* rtnp;
bool gotEof = false;
while (nullptr == (rtnp = std::strchr(m_lineChars.c_str(), '\n')) && !gotEof) {
string buf;
const int tok = getFinalToken(buf /*ref*/);
m_tokenBuf.clear();
const int tok = getFinalToken(m_tokenBuf /*ref*/);
if (debug() >= 5) {
const string bufcln = V3PreLex::cleanDbgStrg(buf);
const string bufcln = V3PreLex::cleanDbgStrg(m_tokenBuf);
const string flcol = m_lexp->m_tokFilelinep->asciiLineCol();
UINFO(0, flcol << ": GETFETC: " << tokenName(tok) << ": " << bufcln);
}
@@ -1762,7 +1764,7 @@ string V3PreProcImp::getline() {
}
gotEof = true;
} else {
m_lineChars.append(buf);
m_lineChars.append(m_tokenBuf);
}
}