luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Error message cleanup

This commit is contained in:
Wilson Snyder 2020-12-06 20:20:14 -05:00
parent 570631380b
commit b32d530000
5 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/V3Inst.cpp
View File

@ -341,10 +341,10 @@ private:
// Arrayed instants: one bit for each of the instants (each // Arrayed instants: one bit for each of the instants (each
// assign is 1 pinwidth wide) // assign is 1 pinwidth wide)
if (m_cellRangep->littleEndian()) { if (m_cellRangep->littleEndian()) {
nodep->exprp()->v3warn( nodep->exprp()->v3warn(LITENDIAN, "Little endian cell range connecting to "
LITENDIAN, "vector: left < right of cell range: ["
"Little endian cell range connecting to vector: MSB < LSB of cell range: " << m_cellRangep->leftConst() << ":"
<< m_cellRangep->lsbConst() << ":" << m_cellRangep->msbConst()); << m_cellRangep->rightConst() << "]");
} }
AstNode* exprp = nodep->exprp()->unlinkFrBack(); AstNode* exprp = nodep->exprp()->unlinkFrBack();
bool inputPin = nodep->modVarp()->isNonOutput(); bool inputPin = nodep->modVarp()->isNonOutput();

5
src/V3Width.cpp
View File

@ -777,8 +777,9 @@ private:
// Note width() not set on range; use elementsConst() // Note width() not set on range; use elementsConst()
if (nodep->littleEndian() && !VN_IS(nodep->backp(), UnpackArrayDType) if (nodep->littleEndian() && !VN_IS(nodep->backp(), UnpackArrayDType)
&& !VN_IS(nodep->backp(), Cell)) { // For cells we warn in V3Inst && !VN_IS(nodep->backp(), Cell)) { // For cells we warn in V3Inst
nodep->v3warn(LITENDIAN, "Little bit endian vector: MSB < LSB of bit range: " nodep->v3warn(LITENDIAN, "Little bit endian vector: left < right of bit range: ["
<< nodep->lsbConst() << ":" << nodep->msbConst()); << nodep->leftConst() << ":" << nodep->rightConst()
<< "]");
} }
} }
} }

8
test_regress/t/t_interface_array_nocolon_bad.out
View File

@ -1,17 +1,17 @@
%Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:26:26: Little endian cell range connecting to vector: MSB < LSB of cell range: 0:2 %Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:26:26: Little endian cell range connecting to vector: left < right of cell range: [0:2]
: ... In instance t : ... In instance t
26 | foo_intf foos [N] (.x(X)); 26 | foo_intf foos [N] (.x(X));
| ^ | ^
... Use "/* verilator lint_off LITENDIAN */" and lint_on around source to disable this message. ... Use "/* verilator lint_off LITENDIAN */" and lint_on around source to disable this message.
%Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:27:28: Little endian cell range connecting to vector: MSB < LSB of cell range: 1:3 %Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:27:28: Little endian cell range connecting to vector: left < right of cell range: [1:3]
: ... In instance t : ... In instance t
27 | foo_intf fool [1:3] (.x(X)); 27 | foo_intf fool [1:3] (.x(X));
| ^ | ^
%Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:30:26: Little endian cell range connecting to vector: MSB < LSB of cell range: 0:2 %Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:30:26: Little endian cell range connecting to vector: left < right of cell range: [0:2]
: ... In instance t : ... In instance t
30 | foo_subm subs [N] (.x(X)); 30 | foo_subm subs [N] (.x(X));
| ^ | ^
%Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:31:28: Little endian cell range connecting to vector: MSB < LSB of cell range: 1:3 %Warning-LITENDIAN: t/t_interface_array_nocolon_bad.v:31:28: Little endian cell range connecting to vector: left < right of cell range: [1:3]
: ... In instance t : ... In instance t
31 | foo_subm subl [1:3] (.x(X)); 31 | foo_subm subl [1:3] (.x(X));
| ^ | ^

4
test_regress/t/t_metacmt_onoff.out
View File

@ -1,9 +1,9 @@
%Warning-LITENDIAN: t/t_metacmt_onoff.v:8:8: Little bit endian vector: MSB < LSB of bit range: 0:1 %Warning-LITENDIAN: t/t_metacmt_onoff.v:8:8: Little bit endian vector: left < right of bit range: [0:1]
: ... In instance t : ... In instance t
8 | reg [0:1] show1; /*verilator lint_off LITENDIAN*/ reg [0:2] ign2; /*verilator lint_on LITENDIAN*/ reg [0:3] show3; 8 | reg [0:1] show1; /*verilator lint_off LITENDIAN*/ reg [0:2] ign2; /*verilator lint_on LITENDIAN*/ reg [0:3] show3;
| ^ | ^
... Use "/* verilator lint_off LITENDIAN */" and lint_on around source to disable this message. ... Use "/* verilator lint_off LITENDIAN */" and lint_on around source to disable this message.
%Warning-LITENDIAN: t/t_metacmt_onoff.v:8:109: Little bit endian vector: MSB < LSB of bit range: 0:3 %Warning-LITENDIAN: t/t_metacmt_onoff.v:8:109: Little bit endian vector: left < right of bit range: [0:3]
: ... In instance t : ... In instance t
8 | reg [0:1] show1; /*verilator lint_off LITENDIAN*/ reg [0:2] ign2; /*verilator lint_on LITENDIAN*/ reg [0:3] show3; 8 | reg [0:1] show1; /*verilator lint_off LITENDIAN*/ reg [0:2] ign2; /*verilator lint_on LITENDIAN*/ reg [0:3] show3;
| ^ | ^

2
test_regress/t/t_select_bad_msb.out
View File

@ -1,4 +1,4 @@
%Warning-LITENDIAN: t/t_select_bad_msb.v:12:8: Little bit endian vector: MSB < LSB of bit range: 0:22 %Warning-LITENDIAN: t/t_select_bad_msb.v:12:8: Little bit endian vector: left < right of bit range: [0:22]
: ... In instance t : ... In instance t
12 | reg [0:22] backwd; 12 | reg [0:22] backwd;
| ^ | ^