luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 01:54:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

CI: Fix more unintended cancellations

Browse Source
This commit is contained in:
Geza Lore
2026-09-20 23:38:41 +01:00
parent 652495a932
commit 33d1e4e685
3 changed files with 75 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/coverage.yml
+25 -12
View File
@@ -21,21 +21,34 @@ defaults:
concurrency:
# At most 1 job per branch. Auto cancel all but scheduled jobs.
# Label events that do not concern the 'pr: dev-coverage' label are given a
# unique concurrency group, so they do not cancel a run that is in progress.
# Of the pull request events, only one that starts a run, or that removes the
# 'pr: dev-coverage' label to cancel one, shares the group. The rest are
# skipped (a change of another label, or a payload that does not carry the
# label, like an 'opened' delivered after it was added), and a skipped run
# must not cancel the one in progress, so they are given a unique group.
# This way adding the label starts a run, removing it cancels the in-progress
# run, and any other label change has no effect. Note such an event still
# creates a run of this workflow, which is skipped, and would then hide the
# one in progress on the pull request. 'pr-run-cleanup.yml' deletes those.
# run, and anything else has no effect. Note such an event still creates a
# run of this workflow, which is skipped, and would then hide the one in
# progress on the pull request. 'pr-run-cleanup.yml' deletes those.
# Key pull request runs on the number: 'github.ref' is the base branch once
# the pull request is closed, so unlabel events would cancel base runs.
group: >-
${{ github.workflow }}-${{
github.event_name == 'pull_request'
&& format('pr-{0}', github.event.number) || github.ref }}-${{
(github.event.action == 'labeled' || github.event.action == 'unlabeled')
&& github.event.label.name != 'pr: dev-coverage'
&& github.run_id || 'shared' }}
# NOTE: The last part of the group expression must be kept in sync with the
# 'start' job condition below: it maps to 'shared' exactly those events that
# satisfy that condition, plus the 'unlabeled' event of the gating label.
group: "${{
github.workflow
}}-${{
(github.event_name == 'pull_request')
&& format('pr-{0}', github.event.number) || github.ref
}}-${{
(github.event_name == 'pull_request'
&& (((github.event.action == 'labeled' || github.event.action == 'unlabeled')
&& github.event.label.name != 'pr: dev-coverage')
|| (github.event.action != 'labeled'
&& github.event.action != 'unlabeled'
&& !contains(github.event.pull_request.labels.*.name, 'pr: dev-coverage'))))
&& github.run_id || 'shared'
}}"
cancel-in-progress: ${{ github.event_name != 'schedule' }}
jobs:
.github/workflows/regression.yml
+25 -12
View File
@@ -24,21 +24,34 @@ defaults:
concurrency:
# At most 1 job per branch. Auto cancel on pull requests and on all forks.
# Label events that do not concern the 'pr: regression' label are given a
# unique concurrency group, so they do not cancel a run that is in progress.
# Of the pull request events, only one that starts a run, or that removes the
# 'pr: regression' label to cancel one, shares the group. The rest are
# skipped (a change of another label, or a payload that does not carry the
# label, like an 'opened' delivered after it was added), and a skipped run
# must not cancel the one in progress, so they are given a unique group.
# This way adding the label starts a run, removing it cancels the in-progress
# run, and any other label change has no effect. Note such an event still
# creates a run of this workflow, which is skipped, and would then hide the
# one in progress on the pull request. 'pr-run-cleanup.yml' deletes those.
# run, and anything else has no effect. Note such an event still creates a
# run of this workflow, which is skipped, and would then hide the one in
# progress on the pull request. 'pr-run-cleanup.yml' deletes those.
# Key pull request runs on the number: 'github.ref' is the base branch once
# the pull request is closed, so unlabel events would cancel base runs.
group: >-
${{ github.workflow }}-${{
github.event_name == 'pull_request'
&& format('pr-{0}', github.event.number) || github.ref }}-${{
(github.event.action == 'labeled' || github.event.action == 'unlabeled')
&& github.event.label.name != 'pr: regression'
&& github.run_id || 'shared' }}
# NOTE: The last part of the group expression must be kept in sync with the
# 'start' job condition below: it maps to 'shared' exactly those events that
# satisfy that condition, plus the 'unlabeled' event of the gating label.
group: "${{
github.workflow
}}-${{
(github.event_name == 'pull_request')
&& format('pr-{0}', github.event.number) || github.ref
}}-${{
(github.event_name == 'pull_request'
&& (((github.event.action == 'labeled' || github.event.action == 'unlabeled')
&& github.event.label.name != 'pr: regression')
|| (github.event.action != 'labeled'
&& github.event.action != 'unlabeled'
&& !contains(github.event.pull_request.labels.*.name, 'pr: regression'))))
&& github.run_id || 'shared'
}}"
cancel-in-progress: ${{ github.event_name == 'pull_request' || github.repository != 'verilator/verilator' }}
jobs:
.github/workflows/rtlmeter.yml
+25 -12
View File
@@ -23,21 +23,34 @@ defaults:
concurrency:
# At most 1 job per branch. Auto cancel all but scheduled jobs.
# Label events that do not concern the 'pr: rtlmeter' label are given a
# unique concurrency group, so they do not cancel a run that is in progress.
# Of the pull request events, only one that starts a run, or that removes the
# 'pr: rtlmeter' label to cancel one, shares the group. The rest are
# skipped (a change of another label, or a payload that does not carry the
# label, like an 'opened' delivered after it was added), and a skipped run
# must not cancel the one in progress, so they are given a unique group.
# This way adding the label starts a run, removing it cancels the in-progress
# run, and any other label change has no effect. Note such an event still
# creates a run of this workflow, which is skipped, and would then hide the
# one in progress on the pull request. 'pr-run-cleanup.yml' deletes those.
# run, and anything else has no effect. Note such an event still creates a
# run of this workflow, which is skipped, and would then hide the one in
# progress on the pull request. 'pr-run-cleanup.yml' deletes those.
# Key pull request runs on the number: 'github.ref' is the base branch once
# the pull request is closed, so unlabel events would cancel base runs.
group: >-
${{ github.workflow }}-${{
github.event_name == 'pull_request'
&& format('pr-{0}', github.event.number) || github.ref }}-${{
(github.event.action == 'labeled' || github.event.action == 'unlabeled')
&& github.event.label.name != 'pr: rtlmeter'
&& github.run_id || 'shared' }}
# NOTE: The last part of the group expression must be kept in sync with the
# 'start' job condition below: it maps to 'shared' exactly those events that
# satisfy that condition, plus the 'unlabeled' event of the gating label.
group: "${{
github.workflow
}}-${{
(github.event_name == 'pull_request')
&& format('pr-{0}', github.event.number) || github.ref
}}-${{
(github.event_name == 'pull_request'
&& (((github.event.action == 'labeled' || github.event.action == 'unlabeled')
&& github.event.label.name != 'pr: rtlmeter')
|| (github.event.action != 'labeled'
&& github.event.action != 'unlabeled'
&& !contains(github.event.pull_request.labels.*.name, 'pr: rtlmeter'))))
&& github.run_id || 'shared'
}}"
cancel-in-progress: ${{ github.event_name != 'schedule' }}
jobs: