luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-02 18:58:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Internals: Fix remaining cppcheck errors (#6319)

Browse Source 
Fixed the non const-related issue and added suppressions for the const
ones. With that `make cppcheck` should be clean.
This commit is contained in:
Geza Lore
2025-08-21 09:43:37 +01:00
committed by GitHub
parent bd91b619ad
commit 327d55d13d
64 changed files with 266 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3LinkResolve.cpp
+5 -3
View File
@@ -141,10 +141,11 @@ class LinkResolveVisitor final : public VNVisitor {
nodep->varp()->usedParam(true);
// Look for where genvar is valid
bool ok = false;
for (AstGenFor* forp : m_underGenFors) {
// cppcheck-suppress constVariablePointer
for (AstGenFor* const forp : m_underGenFors) {
if (ok) break;
if (forp->initsp())
forp->initsp()->foreach([&](AstVarRef* refp) { //
forp->initsp()->foreach([&](const AstVarRef* refp) { //
if (refp->varp() == nodep->varp()) ok = true;
});
}
@@ -199,6 +200,7 @@ class LinkResolveVisitor final : public VNVisitor {
}
// UINFOTREE(1, letp, "", "let-let");
// UINFOTREE(1, nodep, "", "let-ref");
// cppcheck-suppress constVariablePointer
AstStmtExpr* const letStmtp = VN_AS(letp->stmtsp(), StmtExpr);
AstNodeExpr* const newp = letStmtp->exprp()->cloneTree(false);
const V3TaskConnects tconnects = V3Task::taskConnects(nodep, letp->stmtsp());
@@ -398,7 +400,7 @@ class LinkResolveVisitor final : public VNVisitor {
return newFormat;
}
static void expectDescriptor(AstNode* /*nodep*/, AstNodeVarRef* filep) {
static void expectDescriptor(AstNode* /*nodep*/, const AstNodeVarRef* filep) {
// This might fail on complex expressions like arrays
// We use attrFileDescr() only for lint suppression, so that's ok
if (filep && filep->varp()) filep->varp()->attrFileDescr(true);