Commit Graph

10481 Commits

Author SHA1 Message Date
eugene yokota 4d8258ba67
Merge pull request #6408 from eed3si9n/wip/windows_cache
Use LOCALAPPDATA or $HOME/AppData/Local on Windows
2021-03-21 23:59:55 -04:00
Eugene Yokota 01e3d9e9d8 Use LOCALAPPDATA or $HOME/AppData/Local on Windows
Fixes https://github.com/sbt/sbt/issues/5206

Problem
--------
Coursier uses directories-jvm to determine its default cache directory.
Currently directories-jvm shells out to Powershell to call the [Known Folders API](https://docs.microsoft.com/en-us/windows/win32/shell/knownfolderid), which doesn't work in various environments, and instead of an error, it apparently returns `null/Coursier/cache` as the directory name.

Solution
--------
With due respect to the heroic effort directories-jvm is making to comply to the directory standards on all operating systems, including that of Microsoft, I don't think the majority of the sbt users care exactly where that directory is as long as it is well-documented, and calculated in a fast and predictable way.

Instead of shelling out to Powershell, or using JNI, to hit the Known Folders API, I propose we first look at `LOCALAPPDATA` environment variable. When it is not found, it will fall back to `$HOME/AppData/Local`. Per discussion in https://github.com/dirs-dev/directories-jvm/issues/43, `LOCALAPPDATA` environment variable may NOT represent the one-true Known Folders API value of the AppData directory in case the user happened to have set the `LOCALAPPDATA` environmental variable. For the purpose of picking a directory for Coursier cache, I don't find that to be a problem because it will be faster, more reliable, and predictable.
2021-03-21 20:50:03 -04:00
eugene yokota 07687e51e4
Merge pull request #6407 from eed3si9n/wip/bumpcoursier
lm-coursier-shaded 2.0.8
2021-03-21 18:51:03 -04:00
Eugene Yokota d19b2faaa5 Clear .sbt/scripted/ directory 2021-03-21 18:11:01 -04:00
Eugene Yokota 79d7832a35 lm-coursier-shaded 2.0.8
Fixes https://github.com/sbt/sbt/issues/6243
This updates the underlying Coursier from 2.0.12 to 2.0.15

https://github.com/coursier/coursier/releases/tag/v2.0.13
- NumberFormatException fix

https://github.com/coursier/coursier/releases/tag/v2.0.15
- Updates directories-jvm to 24
2021-03-21 16:00:31 -04:00
eugene yokota 65309c890f
Merge pull request #6406 from eed3si9n/wip/launcher
Launcher 1.3.0-M3
2021-03-21 13:15:00 -04:00
Eugene Yokota 34eed6f24c Launcher 1.3.0-M3 2021-03-21 05:46:18 -04:00
eugene yokota bc40c75964
Merge pull request #6393 from sbt/dependabot/github_actions/coursier/cache-action-v6
Bump coursier/cache-action from v5 to v6
2021-03-20 23:53:45 -04:00
eugene yokota b8691cba88
Merge pull request #6397 from arixmkii/bsp-env-var
Environment variables support in BSP debug session
2021-03-19 11:45:01 -04:00
Arthur Sengileyev 75a5135417 Adding env vars at ScalaMainClass creation time 2021-03-18 23:13:03 +02:00
eugene yokota cc94de91b6
Merge pull request #6403 from adpi2/fix-6398
Silence unused-nowarn in meta-build
2021-03-18 15:46:35 -04:00
Adrien Piquerez 332b53735e Silence unused-nowarn in meta-build 2021-03-18 18:27:26 +01:00
eugene yokota 2e930987e1
Merge pull request #6401 from adpi2/fix-6176
Sanitize sbt-launch-jar in BSP connection details
2021-03-17 17:44:59 -04:00
Adrien Piquerez 503e09ce00 sanitize sbt-launch-jar 2021-03-17 17:44:33 +01:00
Arthur Sengileyev 970ce22aca Environment variables support in BSP debug session 2021-03-15 13:41:50 +02:00
eugene yokota 699ffe57cd
Merge pull request #6391 from eed3si9n/wip/bump
Bump Zinc, LM, and Launcher
2021-03-15 03:00:32 -04:00
Eugene Yokota 8c3f0970eb launcher 1.3.0-M2 2021-03-15 02:25:55 -04:00
dependabot[bot] 5542e9a720
Bump coursier/cache-action from v5 to v6
Bumps [coursier/cache-action](https://github.com/coursier/cache-action) from v5 to v6.
- [Release notes](https://github.com/coursier/cache-action/releases)
- [Commits](https://github.com/coursier/cache-action/compare/v5...730a6a454f386fff4be026f3e304ee7fe68912ac)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-15 06:13:23 +00:00
Eugene Yokota 4a0ebac52a Bump Zinc, LM, and Launcher 2021-03-15 01:34:23 -04:00
eugene yokota 7b46f03b62
Merge pull request #6390 from eed3si9n/fport/bintray_less
[fport] Drop Bintray from release
2021-03-14 03:12:21 -04:00
eugene yokota deb5139e12
Merge pull request #6380 from sbt/eed3si9n-patch-1
Use fully qualified name in the macro
2021-03-09 15:54:06 -05:00
eugene yokota 34a3f7fe64
Use fully qualified name in the macro 2021-03-09 11:55:29 -05:00
eugene yokota 3d784b9217
Merge pull request #6378 from adpi2/bsp-logging
Improve BSP processing logs
2021-03-09 09:46:31 -05:00
eugene yokota 196370285b
Merge pull request #6376 from eed3si9n/wip/jansi
JAnsi 2.1.0
2021-03-09 09:43:02 -05:00
Adrien Piquerez 93afa7e892 Improve BSP processing logs
The processing log is sent when a command issued by a request is being
processed, if the request has not yet been responded. In particular,
the processing log of sbtReportResult is filtered out if the client has
already received a response.

The processing log severity is the lowest so that it can be ignored by
the BSP client.
2021-03-09 10:18:12 +01:00
Eugene Yokota c064cf1aff JAnsi 2.1.0
Fixes https://github.com/sbt/sbt/issues/6372
sbt 1.4.x includes both JLine 2 and JLine 3, and our fork of JLine 2 uses JAnsi matching with JLine 3.
I need to bump JLine 2 together, which uses the same JAnsi version as
JLine 3.
2021-03-09 01:48:09 -05:00
eugene yokota 177185f812
Merge pull request #6374 from eed3si9n/wip/unidoc-patch
Patch for unidoc
2021-03-09 00:12:43 -05:00
Eugene Yokota d0f540aea1 Patch for unidoc 2021-03-08 22:41:19 -05:00
eugene yokota 01df7219da
Merge pull request #6373 from eatkins/input-files
Don't use deprecated `in` inside of macros
2021-03-08 15:41:13 -05:00
Ethan Atkins 7dc5590190 Don't use deprecated `in` inside of macros
The inputFileChanges, inputFiles and outputFiles macros all used the now
deprecated `in` syntax, which causes warnings for builds that use these
apis. SlashSyntax doesn't naively work in these macros so it was easier
to just reimplement the logic in this file.

Fixes #6330
2021-03-08 10:54:01 -08:00
Eugene Yokota 2759a122cf Drop Bintray from release
Fixes https://github.com/sbt/sbt/issues/6370

compatibility note
Today we release the sbt-launcher JAR **twice** under
https://repo1.maven.org/maven2/org/scala-sbt/sbt-launch/1.4.7/:
- https://repo1.maven.org/maven2/org/scala-sbt/sbt-launch/1.4.7/sbt-launch-1.4.7.jar
- https://repo1.maven.org/maven2/org/scala-sbt/sbt-launch/1.4.7/sbt-launch.jar

I think this goes back to the early days when we used to tell people to download the `sbt-launch.jar` and write your own launcher script, which I remember doing. Some remnant seen in https://www.scala-sbt.org/0.12.4/docs/Getting-Started/Setup.html#unix.

I think we can drop this old practice.
2021-03-07 17:47:58 -05:00
eugene yokota 571005efa0
Merge pull request #6367 from eed3si9n/wip/pos-sourcefile
Make sure to also pass absolute sourceFile to sourceMappers, take 2
2021-03-07 15:09:50 -05:00
Matthias Kurz 6fbed26d22 Make sure to also pass absolute sourceFile to sourceMappers 2021-03-07 14:44:42 -05:00
eugene yokota 93fd5703b6
Merge pull request #6363 from eed3si9n/wip/nowarn
Work around "a pure expression does nothing" warning, take 3
2021-03-07 14:04:50 -05:00
eugene yokota 48fd4f46ba
Merge pull request #6364 from eed3si9n/wip/jline3
JLine 3.19.0
2021-03-07 14:04:21 -05:00
Eugene Yokota ab95cc7dca JLine 3.19.0
Fixes https://github.com/sbt/sbt/issues/6348

Intentionally or unintentionally the JLine 3 leaks over from sbt to
Scala REPL currently.
I think this enables things like sbtn to transmit tab completion and
other console interaction over a socket to sbt server.
Scala 2.13.5 REPL now causes some issue of displaying warning
each time the user hits tab for tab completion.
This works around the issue by upgrading to the latest JLine 3.
2021-03-07 03:47:49 -05:00
Eugene Yokota 9cd4c0d05f Work around "a pure expression does nothing" warning, take 3
Fixes https://github.com/sbt/sbt/issues/6161
Ref https://github.com/scala/bug/issues/12112

This uses the configurable warning backported to Scala 2.12.
2021-03-07 03:17:42 -05:00
eugene yokota f155bfd1f3
Merge pull request #6360 from eed3si9n/wip/in_memory
Add test for in-memory file
2021-03-07 00:30:00 -05:00
Eugene Yokota 744a8a076d Try another VirtualFile name 2021-03-06 18:27:49 -05:00
Eugene Yokota 8a2083cb03 Add test for in-memory file 2021-03-06 14:34:23 -05:00
eugene yokota ff6cbf2e1f
Merge pull request #6351 from steinybot/scripted-publish-deps
Publish all plugin dependencies
2021-03-04 23:35:59 -05:00
Ondra Pelech 81457e60ec
Give an explanation in case of ServerAlreadyBootingException (#6353)
Give and explanation in case of ServerAlreadyBootingException
2021-03-04 23:21:42 -05:00
eugene yokota 5f24664c0d
Merge pull request #6355 from marcospereira/updates/semanticdb-4.4.10
Update semanticdb to version 4.4.10
2021-03-04 20:17:06 -05:00
eugene yokota 9c25045592
Merge pull request #6352 from mkurz/no_default_sourcePositionMappers
Never set a default for sourcePositionMappers
2021-03-04 20:15:40 -05:00
Marcos Pereira c9941aeabc
Update semanticdb to version 4.4.10 2021-03-04 16:38:00 -05:00
Matthias Kurz de313bbdde
Never set a default for sourcePositionMappers 2021-03-04 22:30:35 +01:00
Jason Pickens 6e0da94d91
Publish all plugin dependencies 2021-03-04 12:09:12 +13:00
eugene yokota 33e2bfe281
Merge pull request #6337 from adpi2/fix-server-command
Fix size of server running message
2021-02-27 14:02:08 -05:00
eugene yokota 0972b7fa17
Merge pull request #6336 from adpi2/fix-tasty-test
Fix TastyFiles added twice in Test
2021-02-24 13:28:51 -05:00
Adrien Piquerez bf29e2a908 Fix size of server running message 2021-02-24 17:31:28 +01:00