[2.x] Update to Scala 3.8.4 (#9302)

contributing-docs/05_scripted_tests.md

@@ -28,7 +28,7 @@ Create an initial build in `something`. Like a real build using sbt. I'm sure yo
 
 ```scala
 name := "foo"
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 ```
 
 I also have `Hello.scala`:
@@ -107,7 +107,7 @@ import scala.sys.process.Process
 lazy val check = taskKey[Unit]("check")
 
 name := "foo"
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 check := {
   val pkg = (Compile / packageBin).value
   val conv = fileConverter.value

launcher-package/citest/build.sbt

@@ -3,7 +3,7 @@ lazy val check2 = taskKey[Unit]("")
 
 lazy val root = (project in file("."))
   .settings(
-    scalaVersion := "3.8.3",
+    scalaVersion := "3.8.4",
     name := "Hello",
     libraryDependencies += "com.eed3si9n.verify" %% "verify" % "1.0.0" % Test,
     testFrameworks += new TestFramework("verify.runner.Framework"),

launcher-package/citest2/build.sbt

@@ -1,5 +1,5 @@
 lazy val root = (project in file("."))
   .settings(
-    scalaVersion := "3.8.3",
+    scalaVersion := "3.8.4",
     name := "Hello",
   )

project/Dependencies.scala

@@ -3,14 +3,14 @@ import Keys.*
 
 object Dependencies {
   // WARNING: Please Scala update versions in PluginCross.scala too
-  val scala3 = "3.8.3"
+  val scala3 = "3.8.4"
   val scala212 = "2.12.21"
   val baseScalaVersion = scala3
   def nightlyVersion: Option[String] =
     sys.env.get("BUILD_VERSION") orElse sys.props.get("sbt.build.version")
 
   // sbt modules
-  val ioVersion = nightlyVersion.getOrElse("1.12.0")
+  val ioVersion = nightlyVersion.getOrElse("1.12.1")
   val zincVersion = nightlyVersion.getOrElse("2.0.0-M18")
 
   private val sbtIO = "org.scala-sbt" %% "io" % ioVersion

sbt-app/src/sbt-test/cache/cached-compile/build.sbt

@@ -5,7 +5,7 @@ lazy val checkMiss = inputKey[Unit]("")
 
 Global / localCacheDirectory := baseDirectory.value / "diskcache"
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 checkMiss := {
   val expected: Int = (Space ~> NatBasic).parsed
   val s = streams.value

sbt-app/src/sbt-test/cache/cached-test/build.sbt

@@ -5,7 +5,7 @@ lazy val verify = "com.eed3si9n.verify" %% "verify" % "1.0.0"
 
 Global / localCacheDirectory := baseDirectory.value / "diskcache"
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 libraryDependencies += verify % Test
 testFrameworks += new TestFramework("verify.runner.Framework")
 

sbt-app/src/sbt-test/dependency-management/ivyless-publish-http/build.sbt

@@ -3,7 +3,7 @@ ThisBuild / csrCacheDirectory := (ThisBuild / baseDirectory).value / "coursier-c
 name := "lib1"
 organization := "com.example"
 version := "0.1.0-SNAPSHOT"
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 val publishRepoBase = settingKey[File]("Base directory for publish repo (HTTP server writes here)")
 publishRepoBase := baseDirectory.value / "repo"

sbt-app/src/sbt-test/dependency-management/ivyless-publish-local/build.sbt

@@ -3,7 +3,7 @@ ThisBuild / csrCacheDirectory := (ThisBuild / baseDirectory).value / "coursier-c
 name := "lib1"
 organization := "com.example"
 version := "0.1.0-SNAPSHOT"
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 // Use a fixed path for local ivy repo to avoid sbt 2.x output sharding
 val ivyLocalBase = settingKey[File]("Local Ivy repository base")

sbt-app/src/sbt-test/dependency-management/ivyless-publish-maven-http/build.sbt

@@ -1,7 +1,7 @@
 ThisBuild / csrCacheDirectory := (ThisBuild / baseDirectory).value / "coursier-cache"
 ThisBuild / organization := "com.example"
 ThisBuild / version := "0.1.0-SNAPSHOT"
-ThisBuild / scalaVersion := "3.8.3"
+ThisBuild / scalaVersion := "3.8.4"
 
 val publishRepoBase = settingKey[File]("Base directory for Maven publish repo (HTTP server writes here)")
 ThisBuild / publishRepoBase := (ThisBuild / baseDirectory).value / "repo"

sbt-app/src/sbt-test/dependency-management/ivyless-publish-maven/build.sbt

@@ -3,7 +3,7 @@ ThisBuild / csrCacheDirectory := (ThisBuild / baseDirectory).value / "coursier-c
 name := "lib1"
 organization := "com.example"
 version := "0.1.0-SNAPSHOT"
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 publishMavenStyle := true
 val publishRepoBase = settingKey[File]("Base directory for Maven publish repo")

sbt-app/src/sbt-test/dependency-management/ivyless-publish/build.sbt

@@ -3,7 +3,7 @@ ThisBuild / csrCacheDirectory := (ThisBuild / baseDirectory).value / "coursier-c
 name := "lib1"
 organization := "com.example"
 version := "0.1.0-SNAPSHOT"
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 // Publish to a file repo (tests ivyless publish without HTTP server)
 val publishRepoBase = settingKey[File]("Base directory for publish repo")

sbt-app/src/sbt-test/dependency-management/platform-artifact-name/build.sbt

@@ -1,7 +1,7 @@
 ThisBuild / organization := "com.example"
 name := "testproj"
 version := "0.1.0-SNAPSHOT"
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 platform := "native0.5"
 crossVersion := CrossVersion.binary

sbt-app/src/sbt-test/dependency-management/platform-publish/build.sbt

@@ -3,7 +3,7 @@
 
 ThisBuild / organization := "com.example"
 ThisBuild / version := "0.1.0"
-ThisBuild / scalaVersion := "3.8.3"
+ThisBuild / scalaVersion := "3.8.4"
 ThisBuild / csrCacheDirectory := (ThisBuild / baseDirectory).value / "coursier-cache"
 
 lazy val mavenRepo = settingKey[File]("shared local Maven repo for the consume round-trip")

sbt-app/src/sbt-test/dependency-management/stdlib-3.8/build.sbt

@@ -1,6 +1,6 @@
 lazy val a = project
   .settings(
-    scalaVersion := "3.8.3"
+    scalaVersion := "3.8.4"
   )
 
 // (b / update) sbt.librarymanagement.ResolveException: Error downloading org.scala-lang:scala-reflect:3.8.3

sbt-app/src/sbt-test/nio/clean-symlinks/build.sbt

@@ -2,7 +2,7 @@ import java.nio.file.Files
 
 name := "clean-symlinks-test"
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 TaskKey[Unit]("createSymlinkedDirectory") := {
   IO.createDirectory(target.value)

sbt-app/src/sbt-test/nio/clean-symlinks/test

@@ -1,9 +1,9 @@
 > createSymlinkedDirectory
 
-$ exists target/out/jvm/scala-3.8.3/clean-symlinks-test/foo/bar
+$ exists target/**/clean-symlinks-test/foo/bar
 $ exists foo/bar
 
 > clean
 
-$ absent target/out/jvm/scala-3.8.3/clean-symlinks-test/foo
+$ absent target/**/clean-symlinks-test/foo
 $ exists foo/bar

sbt-app/src/sbt-test/plugins/auto-plugins-minimal/build.sbt

@@ -1,4 +1,4 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 organization := "com.example"
 

sbt-app/src/sbt-test/plugins/pgp/build.sbt

@@ -1,2 +1,2 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 publishLocal := {}

sbt-app/src/sbt-test/plugins/plugin-cross/build.sbt

@@ -19,4 +19,4 @@ lazy val plugin = (projectMatrix in file("plugin"))
         case _      => "2.0.0-RC3"
     },
   )
-  .jvmPlatform(scalaVersions = Seq("3.8.3", "2.12.21"))
+  .jvmPlatform(scalaVersions = Seq("3.8.4", "2.12.21"))

sbt-app/src/sbt-test/plugins/sbt-native-packager/build.sbt

@@ -1,4 +1,4 @@
-ThisBuild / scalaVersion := "3.8.3"
+ThisBuild / scalaVersion := "3.8.4"
 
 name := "hello"
 enablePlugins(JavaAppPackaging)
@@ -6,7 +6,7 @@ enablePlugins(JavaAppPackaging)
 lazy val check = taskKey[Unit]("")
 
 check := {
-  val cmd = "target/out/jvm/scala-3.8.3/hello/universal/stage/bin/hello"
+  val cmd = "target/out/jvm/scala-3.8.4/hello/universal/stage/bin/hello"
   val cmd0 =
     if (sys.props("os.name").toLowerCase(java.util.Locale.ROOT).contains("windows"))
       cmd + ".bat"

sbt-app/src/sbt-test/project-load/subdirectory/build.sbt

@@ -3,7 +3,7 @@ lazy val foo = project
 @transient
 lazy val check = taskKey[Unit]("")
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 LocalRootProject / check := {
   assert((foo / Compile / scalacOptions).value == List("-Xmacro-settings:a:a"),
     s"${(foo / Compile / scalacOptions).value}")

sbt-app/src/sbt-test/project-load/werror/build.sbt

@@ -1,4 +1,4 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 @deprecated
 def foo = true

sbt-app/src/sbt-test/project-load/werror/changes/build.sbt

@@ -1,4 +1,4 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 @deprecated
 def foo = true

sbt-app/src/sbt-test/project-matrix/full/build.sbt

@@ -1,5 +1,5 @@
 lazy val scala3_LTS = "3.3.5"
-lazy val scala3_current = "3.8.3"
+lazy val scala3_current = "3.8.4"
 lazy val check = taskKey[Unit]("")
 
 organization := "com.example"

sbt-app/src/sbt-test/project-matrix/full/test

@@ -1,4 +1,4 @@
 > packageBin
 $ exists target/**/app_3.3.5-0.1.0-SNAPSHOT.jar
-$ exists target/**/app_3.8.3-0.1.0-SNAPSHOT.jar
-> core3_8_3/check
+$ exists target/**/app_3.8.4-0.1.0-SNAPSHOT.jar
+> core3_8_4/check

sbt-app/src/sbt-test/project-matrix/source-dep/build.sbt

@@ -1,5 +1,5 @@
 // https://github.com/sbt/sbt/issues/8971
-ThisBuild / scalaVersion := "3.8.3"
+ThisBuild / scalaVersion := "3.8.4"
 
 lazy val extLib = ProjectRef(file("ext/lib"), "lib")
 

sbt-app/src/sbt-test/project-matrix/source-dep/ext/lib/build.sbt

@@ -1,7 +1,7 @@
-ThisBuild / scalaVersion := "3.8.3"
+ThisBuild / scalaVersion := "3.8.4"
 
 lazy val lib = (projectMatrix in file("."))
   .settings(
     name := "lib",
   )
-  .jvmPlatform(scalaVersions = Seq("3.8.3"))
+  .jvmPlatform(scalaVersions = Seq("3.8.4"))

sbt-app/src/sbt-test/project/Class.forName/build.sbt

@@ -1,4 +1,4 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 crossPaths := false
 name := "definition-lib-forname-test"
 version := "1.0"

sbt-app/src/sbt-test/project/nested-macro/build.sbt

@@ -1,6 +1,6 @@
 lazy val a1 = settingKey[Boolean]("")
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 a1 := true
 
 Compile / sourceGenerators += {

sbt-app/src/sbt-test/project/no-delegate/build.sbt

@@ -1 +1 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"

sbt-app/src/sbt-test/project/remove/build.sbt

@@ -11,7 +11,7 @@ lazy val intsSetting2 = Def.setting {
   Seq(1, 2, 3)
 }
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 intsTask := Seq(1, 2, 3, 4, 5, 6, 7)
 intsTask -= 3
@@ -30,10 +30,10 @@ intsSetting -= intSetting2.value
 intsSetting --= intsSetting2.value
 
 intsFromScalaV := Seq(1, 2, 3, 4, 5, 6, 7)
-intsFromScalaV -= { if scalaVersion.value == "3.8.3" then 3 else 5 }
-intsFromScalaV --= { if scalaVersion.value == "3.8.3" then Seq(1, 2) else Seq(4) }
-intsFromScalaV -= { if scalaVersion.value == "3.8.3" then Option(6) else None }
-intsFromScalaV --= { if scalaVersion.value == "3.8.3" then Option(7) else None }
+intsFromScalaV -= { if scalaVersion.value == "3.8.4" then 3 else 5 }
+intsFromScalaV --= { if scalaVersion.value == "3.8.4" then Seq(1, 2) else Seq(4) }
+intsFromScalaV -= { if scalaVersion.value == "3.8.4" then Option(6) else None }
+intsFromScalaV --= { if scalaVersion.value == "3.8.4" then Option(7) else None }
 
 intsSetSetting := Set(1, 2, 3, 4, 5, 6, 7)
 intsSetSetting -= 3

sbt-app/src/sbt-test/project/scala3-console-project/build.sbt

@@ -1,4 +1,4 @@
-ThisBuild / scalaVersion := "3.8.3"
+ThisBuild / scalaVersion := "3.8.4"
 
 lazy val markerFile = settingKey[java.io.File]("marker file written by consoleProject REPL when bindings resolve")
 

sbt-app/src/sbt-test/project/settings-delegate/build.sbt

@@ -1 +1 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"

sbt-app/src/sbt-test/tests/fork-main-resources/build.sbt

@@ -1,6 +1,6 @@
 val scalatest = "org.scalatest" %% "scalatest" % "3.2.19"
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 Test / fork := true
 libraryDependencies += scalatest % Test
 

sbt-app/src/sbt-test/tests/fork2/build.sbt

@@ -1,5 +1,5 @@
 val scalatest = "org.scalatest" %% "scalatest" % "3.2.19"
 
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 fork := true
 libraryDependencies += scalatest % Test

sbt-app/src/sbt-test/tests/incremental-object-deps/build.sbt

@@ -1,3 +1,3 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 libraryDependencies += "com.eed3si9n.verify" %% "verify" % "1.0.0" % Test
 testFrameworks += new TestFramework("verify.runner.Framework")

sbt-app/src/sbt-test/tests/t543/build.sbt

@@ -6,7 +6,7 @@ val marker = new File("marker")
 val check = TaskKey[Unit]("check", "Check correct error has been returned.")
 val scalatest = "org.scalatest" %% "scalatest" % "3.2.19"
 
-ThisBuild / scalaVersion := "3.8.3"
+ThisBuild / scalaVersion := "3.8.4"
 
 lazy val root = (project in file(".")).
   settings(

sbt-app/src/sbt-test/tests/test-option/build.sbt

@@ -1,2 +1,2 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 libraryDependencies += "org.scalameta" %% "munit" % "0.7.29" % Test

server-test/src/server-test/channel-cursor/build.sbt

@@ -1,4 +1,4 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 val printCurrentProject = inputKey[Unit]("Prints current project name")
 

server-test/src/server-test/client/build.sbt

@@ -1,4 +1,4 @@
-scalaVersion := "3.8.3"
+scalaVersion := "3.8.4"
 
 TaskKey[Unit]("willSucceed") := println("success")