luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4164 from alodavi/alodavi/improving_loading_settings_messaging 

Improving loading settings messaging
This commit is contained in:
eugene yokota 2018-05-23 16:18:08 -04:00 committed by GitHub
parent a6cd0fc994 67efea6248
commit 7f808bd3a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
main/src/main/scala/sbt/internal/Load.scala
View File

@ -1039,7 +1039,7 @@ private[sbt] object Load {
// Grab all the settings we already loaded from sbt files // Grab all the settings we already loaded from sbt files
def settings(files: Seq[File]): Seq[Setting[_]] = { def settings(files: Seq[File]): Seq[Setting[_]] = {
if (files.nonEmpty) if (files.nonEmpty)
log.info(s"${files.map(_.getName).mkString("Loading settings from ", ",", " ...")}") log.info(s"${files.map(_.getName).mkString(s"Loading settings for project ${p.id} from ", ",", " ...")}")
for { for {
file <- files file <- files
config <- (memoSettings get file).toSeq config <- (memoSettings get file).toSeq

22
notes/1.1.4/improving_loading_settings_messaging.md Normal file
View File

@ -0,0 +1,22 @@
### Improvements
Now when loading a project that has multiple build.sbt files the logger shows the path as well.
Before it was:
```bash
[info] Loading settings from build.sbt ...
[info] Loading settings from build.sbt ...
[info] Loading settings from build.sbt ...
[info] Loading settings from build.sbt ...
```
Now it's:
```bash
[info] Loading settings from /home/user/Work/personal/someProject/build.sbt ...
[info] Loading settings from /home/user/Work/personal/someProject/subProject1/build.sbt ...
[info] Loading settings from /home/user/Work/personal/someProject/subProject2/build.sbt ...
[info] Loading settings from /home/user/Work/personal/someProject/subProject3/build.sbt ...
```
This should solve the issue: https://github.com/sbt/sbt/issues/3607