From b30159aded43bc945744ae6e21b69b30a873e5f3 Mon Sep 17 00:00:00 2001 From: alodavi Date: Tue, 15 May 2018 14:06:50 +0200 Subject: [PATCH 1/3] [alodavi/improving_loading_settings_messaging] logging the path instead of just the name --- main/src/main/scala/sbt/internal/Load.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main/src/main/scala/sbt/internal/Load.scala b/main/src/main/scala/sbt/internal/Load.scala index 6d620ec7c..0a3cce27d 100755 --- a/main/src/main/scala/sbt/internal/Load.scala +++ b/main/src/main/scala/sbt/internal/Load.scala @@ -1039,7 +1039,7 @@ private[sbt] object Load { // Grab all the settings we already loaded from sbt files def settings(files: Seq[File]): Seq[Setting[_]] = { if (files.nonEmpty) - log.info(s"${files.map(_.getName).mkString("Loading settings from ", ",", " ...")}") + log.info(s"${files.map(_.getPath).mkString("Loading settings from ", ",", " ...")}") for { file <- files config <- (memoSettings get file).toSeq From 80601e78ad5711cc9ac1023c034e50b4f9484f12 Mon Sep 17 00:00:00 2001 From: alodavi Date: Tue, 15 May 2018 14:44:00 +0200 Subject: [PATCH 2/3] [alodavi/improving_loading_settings_messaging] added notes on the Pr --- .../improving_loading_settings_messaging.md | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 notes/1.1.4/improving_loading_settings_messaging.md diff --git a/notes/1.1.4/improving_loading_settings_messaging.md b/notes/1.1.4/improving_loading_settings_messaging.md new file mode 100644 index 000000000..683846bbb --- /dev/null +++ b/notes/1.1.4/improving_loading_settings_messaging.md @@ -0,0 +1,22 @@ +### Improvements + +Now when loading a project that has multiple build.sbt files the logger shows the path as well. +Before it was: + +```bash +[info] Loading settings from build.sbt ... +[info] Loading settings from build.sbt ... +[info] Loading settings from build.sbt ... +[info] Loading settings from build.sbt ... +``` + +Now it's: + +```bash +[info] Loading settings from /home/user/Work/personal/someProject/build.sbt ... +[info] Loading settings from /home/user/Work/personal/someProject/subProject1/build.sbt ... +[info] Loading settings from /home/user/Work/personal/someProject/subProject2/build.sbt ... +[info] Loading settings from /home/user/Work/personal/someProject/subProject3/build.sbt ... +``` + +This should solve the issue: https://github.com/sbt/sbt/issues/3607 \ No newline at end of file From 67efea6248cd70a0b129fa39a8ca6fa347b5fba5 Mon Sep 17 00:00:00 2001 From: alodavi Date: Wed, 23 May 2018 17:20:41 +0200 Subject: [PATCH 3/3] [alodavi/improving_loading_settings_messaging] logging file and project name instead of only file name --- main/src/main/scala/sbt/internal/Load.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main/src/main/scala/sbt/internal/Load.scala b/main/src/main/scala/sbt/internal/Load.scala index 0a3cce27d..8a316bbc1 100755 --- a/main/src/main/scala/sbt/internal/Load.scala +++ b/main/src/main/scala/sbt/internal/Load.scala @@ -1039,7 +1039,7 @@ private[sbt] object Load { // Grab all the settings we already loaded from sbt files def settings(files: Seq[File]): Seq[Setting[_]] = { if (files.nonEmpty) - log.info(s"${files.map(_.getPath).mkString("Loading settings from ", ",", " ...")}") + log.info(s"${files.map(_.getName).mkString(s"Loading settings for project ${p.id} from ", ",", " ...")}") for { file <- files config <- (memoSettings get file).toSeq