Commit Graph

6437 Commits

Author SHA1 Message Date
Giles Atkinson fbebfb708c Two memory leaks found interactively with valgrind with safe fixes. 2022-05-10 08:29:54 +01:00
Giles Atkinson 4fd0a68fb2 Fix memory leak found by valgrind/paranoia. 2022-05-10 08:25:28 +01:00
Giles Atkinson 55e8975124 Suppress warning from gcc 10.2.1. 2022-05-09 10:51:18 +02:00
Giles Atkinson 11d6c41a7d Fix memory leaks found by valgrind in the paranoia script. 2022-05-08 17:59:20 +02:00
Giles Atkinson b26be81444 Fix XSPICE memory leaks found by valgrind. 2022-05-08 17:59:11 +02:00
Giles Atkinson 44c68183e8 Further change for #578 "Crash while plotting single complex vector".
Move the check on vector lengths to ensure all cases are covered.
2022-05-03 17:00:11 +02:00
Holger Vogt 074a2a6f11 Fix bug 581, reported by Adam Denton 2022-05-02 20:32:21 +02:00
Holger Vogt 60d349589d Merge branch 'pre-master' of ssh://git.code.sf.net/p/ngspice/ngspice into pre-master 2022-05-02 11:27:01 +02:00
Holger Vogt aeef25efaf Enable compiling the shared ngspice library with S-parameters enabled 2022-05-02 11:26:32 +02:00
dwarning 4a6f61ad5a more logical setup for absurd parameter input 2022-05-02 09:19:08 +02:00
dwarning d692669bb9 prevent crash for absurd parameter input 2022-05-01 17:55:56 +02:00
Holger Vogt 6328f7ac13 Don't use bitwise operators, but logic operators 2022-04-30 23:39:24 +02:00
Holger Vogt c094f2e979 Avoid circular redundant function declaration.
Include vsrcext.h only via vsrcdefs.h, so VSRCinstance is defined.
2022-04-30 23:17:46 +02:00
Holger Vogt 78ffba59d4 Remove unused (preliminary) 2022-04-30 16:58:24 +02:00
Holger Vogt 1576783017 add some missing prototypes 2022-04-30 16:58:01 +02:00
Giles Atkinson e6bbbefa10 Suppress warnings from function pointer casts seen with gcc 10.2.1. 2022-04-30 15:26:57 +02:00
Holger Vogt 01266e48ea Merge branch 'pre-master' of ssh://git.code.sf.net/p/ngspice/ngspice into pre-master 2022-04-29 23:33:42 +02:00
Holger Vogt cf62c69aef remove numerous unsigned int vs. int warnings
by setting all variables to type int.
Remove redundant function declarations by remmoving some includes
in span.c and vsrcdefs.h
In tmalloc convert int to size_t
2022-04-29 23:22:05 +02:00
dwarning bc0f1a7a02 simplification of hicum2 model switches selfheat and nqs 2022-04-29 20:43:33 +02:00
dwarning 6dd5c5ad25 #bug 580: prevent crash in case of hicum2 default parameter set 2022-04-29 18:40:19 +02:00
dwarning 43e7c1eb17 #bug 580: prevent crash in case of hicum2 default parameter set 2022-04-29 18:33:48 +02:00
Holger Vogt ea0cdbd6d7 Set {} to remove compiler warning (VS) 2022-04-29 14:32:11 +02:00
dwarning 8361cd8915 correct pnp type bipolar transistor current convention 2022-04-29 11:07:56 +02:00
Holger Vogt 1edc6b8a51 Fix a bug: remove excess ')' 2022-04-29 09:43:16 +02:00
Holger Vogt 86b22083f4 If XSPICE is not selected, still send CKTspDump(ckt, freq, spPlot),
but without ipc (spPlot instead of undefined acPlot)
2022-04-29 07:21:39 +02:00
Holger Vogt 52d0e69710 Add a note that wrs2p currently is limited to two ports only. 2022-04-28 14:14:13 +02:00
Holger Vogt 1d8dacedaa S-parameters: Replace S11 by S_1_1 etc. to avoid ambiguity
when more than 10 ports are measured.
Update to S-parameter script and command wr2sp
2022-04-28 11:58:21 +02:00
Holger Vogt dcf9c1027a Add new flags to command devhelp:
-type (show parameter types)
-flags (show parameter flags)
Patches provided by Mikolaj Wielgus
2022-04-27 08:46:26 +02:00
Giles Atkinson ce81dd7fd9 Rename a variable so that it does not clash with one in outer scope. 2022-04-25 21:12:57 +02:00
Holger Vogt f12f31bed6 Searching for params: as plain identifier 2022-04-25 16:26:30 +02:00
Holger Vogt 7924af7f22 Remove the special handling of X... device names.
Subcircuit devices are saved with leading X in their names.
2022-04-25 15:18:25 +02:00
Giles Atkinson dd7ec4470d Fix Bug #577 "Zooming iplot drops vectors" and three crashes when
the iplot window is closed during simulation.
2022-04-25 13:53:41 +02:00
Holger Vogt 28a39a51d6 Search for "off" token in device instance lines not with
C standard fcn strstr, but with search_plain_identifier().
Thus allow model names that contain "off" (like offset)
2022-04-25 13:38:37 +02:00
Holger Vogt 7703c2d370 Add a function itoa10 and use it
instead of non-standard itoa.
2022-04-25 13:35:23 +02:00
Holger Vogt 4aa5d784ec When calculating power, we need to exclude thermal nodes
of devices like diodes (d) and MOS (m)
2022-04-25 11:35:29 +02:00
Holger Vogt 458b6cf776 Add flag 'power' to fcn setallvsources()
Add code to calculate the power dissipation in a device
(top level instances, including X (subcircuit) invocations).
2022-04-23 20:07:52 +02:00
Holger Vogt 761da8ad0e revert polarity of current mesurements:
current positive when flowing into device, e.g.
Ic, Ib of a positively biased npn.

Add current measurement for all nodes of a device,
e.g. .probe i(Q1) will measure Ic, Ib, Ie (and Is)
2022-04-22 17:46:55 +02:00
Giles Atkinson 2b1433e968 Fix numerous gcc warnings of duplicate declarations. 2022-04-21 15:48:58 +02:00
Giles Atkinson 724cf4e638 Fix Bug #402 "Crash related to aliases". Do not return freed pointer. 2022-04-21 15:48:50 +02:00
Holger Vogt 2aa950fe9c Remove a conflict between the text variable substitution like
set text = "mytext"
set newtext = new.{$text}
echo $newtext
and the command circbyline, which may have to process strings
containing braces {...} without any change to the string.

Do not call cp_doglob() when command circbyline is executed.
2022-04-19 23:26:26 +02:00
Holger Vogt 7985b05aec make comment more verbose 2022-04-19 23:22:17 +02:00
Holger Vogt ae221a70c2 Remove a typo: runable --> runnable 2022-04-15 10:52:56 +02:00
Holger Vogt cd01f4949e Make error message more verbose 2022-04-11 12:05:54 +02:00
Holger Vogt 9deb9f51d8 In case of resistor valuues r150 (r + integer number),
return 150
R2 n1 n2 r150

In case of r23mod return error = 1 and val = 0, so
r23mod may be read as a model, not an instance parameter
R3 n3 n4 r23mod
2022-04-06 16:01:45 +02:00
Giles Atkinson bf7efb18f9 Fix two crashes caused by trying to plot after circuit parsing failed. 2022-04-06 10:24:23 +02:00
Giles Atkinson e16564edf7 Make "nogrid" plotting option work. The deleted code was in the original
commit, so the reason for it can not be traced.
2022-04-06 10:24:16 +02:00
Holger Vogt df9859a5d0 function deriv: This is just a preliminary fix: prevent a crash
when base > 0.

But when is base supposed to be > 0 ? More invetigation is needed.
2022-04-06 10:13:52 +02:00
Holger Vogt 744eaece69 Patch to avoid false reads and writes due to inconsitent
structs SPAN and NOISEAN.
Prevent using non-initialized variables.
2022-04-04 17:41:28 +02:00
Holger Vogt e33ebe5636 Compile only when RFSPICE is selected in config.h 2022-03-30 15:54:35 +02:00
Holger Vogt d903eb45cd Linking failed on openSUSE Linux gcc:
make the inline functions static to allow linking
2022-03-29 17:50:00 +02:00