Commit Graph

7241 Commits

Author SHA1 Message Date
Holger Vogt 5dbb25f667 Set new default values.
Restructure the code a bit.

Two parameters for AM are required (offset and amplitude). Even if this
sounds needless, changing it would require a major effort.
2024-01-07 11:59:33 +01:00
Holger Vogt 4d0e65b3b6 Extend the error message 2024-01-07 11:56:56 +01:00
Holger Vogt a4ae81ec06 We are developing towards ngspice-43 2024-01-06 23:14:26 +01:00
Holger Vogt aaaad70991 Previous AM was buggy in V(I)SRC: Update to amplitude modulation
with corrected equation.
2024-01-06 23:09:27 +01:00
Holger Vogt 88d0727d3f In PS compat mode we only have 2 nodes in a diode,
but still allow self heating diode with ngspice syntax.
2024-01-06 11:51:11 +01:00
Holger Vogt ace932e1b9 Patches provided by Carsten Schoenert: Misspellings, File access 2023-12-31 13:51:05 +01:00
Holger Vogt 88844ba74d Prevent vectors carrying the E POLY source current from being disaggregated 2023-12-31 13:32:45 +01:00
Holger Vogt dd7b9ff273 Avoid memory crash when reading old VDMOS models.
Enable both old and current model format.
2023-12-30 22:52:41 +01:00
Holger Vogt ace235da04 Remove ADMS from build process 2023-12-29 16:53:39 +01:00
Holger Vogt f99a137eb3 Patch for snprintf provided by Marco Atzeri 2023-12-29 10:59:56 +01:00
Holger Vogt 902a62d2f4 win_time.c as extra distribution, used only by MSVC 2023-12-27 19:41:13 +01:00
Holger Vogt f8e77d08d0 More headers distributed 2023-12-27 17:12:15 +01:00
Holger Vogt f4c560ba71 Add more KLU headers to enable their distribution 2023-12-27 16:42:37 +01:00
Holger Vogt a08f1046e4 Add KLU headers to enable their distribution 2023-12-27 16:18:36 +01:00
Holger Vogt 009249eafe Short title 2023-12-27 12:27:31 +01:00
Holger Vogt c1effe3b33 Just a hack to avoid a crash during sensitivity analysis:
Exclude parameter RCO from sens code, if not given,
as sens sets mods->BJTintCollResistGiven to TRUE, which fails due to
missing memory allocation for the extra nodes.
2023-12-27 12:26:56 +01:00
Holger Vogt ca7c6cce71 Avoid crash, when sensitivity analysis is called 2023-12-27 11:32:31 +01:00
Holger Vogt f307586d89 Formatting 2023-12-27 10:42:07 +01:00
Holger Vogt db5e5b08eb Don't switch display to "op", if called from a dc simulation. 2023-12-22 18:16:26 +01:00
Holger Vogt 03905433bb If compatmode hs is set, don't run an extra iteration with
differing mode settings, but go directly to CKTop().
If other or none compat modes, keep existing behavior, as
for example CIDER example may otherwise slow down significantly.

This is to keep dc sim in accordance with other simulators.
2023-12-22 17:21:55 +01:00
Holger Vogt 37944bd7c4 Preliminary fix to bug 650
Don't omit replacement, when independent nested subcircuit has been checked.
FIXME: Better use the cards level parameter.
2023-12-22 17:18:43 +01:00
Holger Vogt 4671b588b6 Update comment 2023-12-22 17:14:43 +01:00
Holger Vogt 5154fd3fd7 Allways export function ngCM_Input_Path, independently from XSPICE
Update comment
2023-12-22 17:14:22 +01:00
Holger Vogt d1abc8f6c7 typo 2023-12-22 13:11:21 +01:00
Holger Vogt c53b32ffa8 Plug a potential memory leak 2023-12-19 15:30:44 +01:00
Brian Taylor 8f52a67786 Fix set but not used warning. 2023-12-19 14:28:29 +01:00
Giles Atkinson af31904f99 The previous fix for Bug #467 - ".OPTION INTERP has accuracy issue"
(359e3d46) updated variable timeold inside a loop so that
all interpolations after the first caused division by zero.
That caused the xspice/delta-sigma example to fail.
Set the variable once at the end of the function.
2023-12-19 14:27:33 +01:00
Giles Atkinson ffcf3b24d9 Improve efficiency and irreversible CM support in EVTcall_hybrids() by
halting calls to code models as soon as the timestep is chenged.
This should have been included in 508fad0f55.
2023-12-19 14:26:56 +01:00
Holger Vogt 9a50f8b749 typo 2023-12-12 17:24:23 +01:00
Holger Vogt ce8f6c5017 prepare ngspice-42 2023-12-12 17:08:58 +01:00
Holger Vogt 2e56f3a063 Add short description of the new interface functions
ngSpice_LockRealloc(void) ad ngSpice_UnlockRealloc(void)
2023-12-12 17:02:19 +01:00
Holger Vogt 7f30055f22 Prevent crash if port number is less than 1. 2023-12-12 16:29:32 +01:00
Holger Vogt 45850c07dc Don't silently accept wrong user input (missing nodes, values).
Check for at leat 4 tokens (name, n1, n2, val/model/...).
If the instance has not been set up correctly, bail out, prevent crash.
2023-12-12 16:29:28 +01:00
Holger Vogt 7cd4f003ff typo 2023-12-12 16:29:23 +01:00
Holger Vogt 6459fed460 Don't prescribe a different resistance value if the user has given one > 0. 2023-12-12 16:28:38 +01:00
Holger Vogt 732c12c93f Remove another potential crash if buggy user input 2023-12-09 15:43:19 +01:00
Holger Vogt c69018fe82 Enable measurements with ?-sweep (v, i, temp, or res).
Improve error messages.
Prevent crash is compüdata is not available.
Add to examples for measure failures.
2023-12-09 15:43:15 +01:00
dwarning 6ad0a6ad38 hisim2: allow compile w/o NEWCONV defined 2023-12-09 15:43:11 +01:00
dwarning a98cfcd8cb allow compile w/o NEWCONV defined 2023-12-09 15:43:00 +01:00
Giles Atkinson 3cf8fe8c41 Stop after last data point, preventing read overrun of nscale. 2023-12-01 12:26:58 +00:00
Giles Atkinson d82f948832 Fix a crash found by Brian Taylor: when .plot attempts to plot digital
node history, interpolation may produce an infinite value at digital edges.
Remove vertical edges when interpolating and make some other improvements:
do not calculate a polynomial approximation for unused frames;
center the target x-value in the frame; and do not propogate a reduction
in degree to later frames.
2023-11-30 17:23:32 +00:00
Giles Atkinson c18447f9f5 Add the support files for co-simulation with Verilog code
compiled by Verilator.  Also add script files to Visual Studio builds
that are already installed by the Makefile builds.
2023-11-27 20:55:59 +00:00
Giles Atkinson a92c569b72 Prevent some strings being mis-recognised by strstr(), including
one that causes a false error message from the vlnggen script.
2023-11-27 17:17:21 +00:00
Giles Atkinson 597268cc26 Treat input files names passed a start-up the same as those entered
as commands or called as scripts: search for them using $sourcepath.
2023-11-27 17:16:55 +00:00
Giles Atkinson 07ce9c788e Recognise *ng_script_with_params" in the first line of the first
program input file to mean that the file is a pure interpreter
script that receives any remaining command arguments.
In winmain.c ensure that the argv array is NULL-terminated
and tidy some code.
2023-11-27 17:06:39 +00:00
Giles Atkinson 89851872ed When substituting interpreter variables, allow '$' to be part of
the variable expresstion only within '[]' or '()'. That lets
forms like "$a$b" to be treated as two substitutions, not one.
2023-11-27 15:13:31 +00:00
Giles Atkinson 3ba314d4bc New interpreter commands strstr, strslice, fopen, fread and fclose. 2023-11-27 14:58:01 +00:00
Giles Atkinson 566e2938f4 Add XSPICE code model d_cosim, a generic adaptor for digital cosimulation. 2023-11-27 14:50:21 +00:00
Giles Atkinson 12fe7b90c4 Add new code model function cm_irreversible(). This may only be
called from an XSPICE code model's INIT call and has three effects:
the instance is treated as "hybrid" even when it does not use both
port types; its position in the hybrids array is adusted; and it
is explicitly notifed when called just befoore the end of an
analog time-step.
2023-11-26 18:30:53 +00:00
Giles Atkinson 34e6c4abea Convert XSPICE's hybrid_index array to instance pointers.
That simplifies code and will be needed for irreversible code model support.
2023-11-26 18:29:23 +00:00
Giles Atkinson 508fad0f55 In dctran.c, call EVTcall_hybrids() (which then calls a subset of
code model instances) only when the current timestep was successful.
That is efficient and means that code models may rely on such calls,
for example a co-simulator may safely advance to the end of the timestep.
The function cm_irreversible() that is mentioned in a comment will be
added in a later commit.
2023-11-26 18:29:03 +00:00
Holger Vogt 3d1cbf93ee Add a predifined variable 'skywaterpdk' to speed up circuit
loading and parsing.
If set, it removes quoting tokens for params. This requires
that Skywater PDK does adequately stick to the ngspice syntax
to put params in between braces. As far as tests go, it does.
It also set the number of nodes for MSO devices to 4, so no lengthy
search is required.
2023-11-23 18:29:48 +01:00
Holger Vogt dd58b07949 Initialize the new mutex vecreallocMutex 2023-11-19 12:37:29 +01:00
Holger Vogt 1849a8d220 Add functions ngSpice_LockRealloc and ngSpice_UnlockRealloc
to lock reallocing output vectors, e.g. during reading the
vecs for plotting.
2023-11-19 12:05:18 +01:00
Holger Vogt e87651e27f Update to comments, restrict mutex definitions to shared ngspice 2023-11-19 12:05:10 +01:00
Holger Vogt 3619041e26 Add new lock for realloc of vectors 2023-11-19 12:05:01 +01:00
Holger Vogt 1db8eff25c Write message only once. 2023-11-19 10:46:19 +01:00
Holger Vogt ecf4f819dc typo 2023-11-19 10:44:42 +01:00
Holger Vogt 86e991515e Enable compiling with MINGW under MS Windows 2023-11-18 20:09:49 +01:00
Holger Vogt 4d4f226a83 Prevent crash, when vector is defined, but still empty. 2023-11-18 17:17:04 +01:00
Holger Vogt e376c0e5c6 Eanble op or ac op (operating point), when selfheat is on.
op for tran has been o.k.
Fixme: preliminary fix or hack.
2023-11-18 17:16:19 +01:00
Holger Vogt b62bb20e6f Increase the allowable node name length from 24 to 256.
Enable safe copying, no user induced buffer overflow.
2023-11-18 10:55:19 +01:00
Holger Vogt 10756111bf Fix a bug when deleting the memory. With the first call
to mem_delete() all the hash table is deleted, a second
call to mem_delete() does not have any further effect, so
has to be avoided.
2023-11-18 09:58:30 +01:00
Holger Vogt e57979d15d Plug two memory leaks introduced by
2bbadc608 ("Use a hash table glonodes to prevent
double or multiple entries in global node table
global_nodes", 2023-11-17)
2023-11-17 23:50:59 +01:00
Holger Vogt 70e366021b Generate seed numbers from a microseconds clock, not a seconds clock 2023-11-17 18:35:21 +01:00
Holger Vogt 81bb886c71 Replace array global_nodes by hash table glonodes:
Save each global node only once
Search for global nodes hash table (much faster than scanning the list repeatedly).
Remove limit for amount of global nodes.
2023-11-17 17:02:06 +01:00
Holger Vogt 2bbadc6085 Use a hash table glonodes to prevent double or multiple entries
in global node table global_nodes
2023-11-17 13:58:57 +01:00
Holger Vogt d060cb82af typo 2023-11-17 13:57:39 +01:00
Holger Vogt 0735b8d0a5 fix previous commit on repeating error messages 2023-11-15 22:54:53 +01:00
Holger Vogt 22a10c0e44 typo 2023-11-15 22:54:06 +01:00
Holger Vogt 55ba927973 If nan occurs during op calculation, issue the warning
no more than 10 times.
2023-11-14 16:57:14 +01:00
Holger Vogt 4da3dc51fd If compatmode ps or lt: add a series resistance (100µOhms) to
diodes, when RS is not given or 0:
Improves convergence in behavioural models for op evaluation.
2023-11-14 16:56:31 +01:00
Holger Vogt 29bfe94318 Exclude some code under a unified #undef REM_USED 2023-11-13 12:32:15 +01:00
dwarning 2cf2693706 few code cleanings 2023-11-12 17:04:36 +01:00
Holger Vogt 2a005292db Sparse 1.3 is the matrix solver if no option (sparse or klu) is given.
KLU is selected by 'option klu'
If both 'option klu' and 'option sparse' are given,
the last one executed determines the solver.
'option sparse=0' de-selects spares, i.e. selects klu.
'option klu=0' de-selects klu, selects sparse.
'option klu=1' has the same meaning as 'option klu'.
'option sparse=1' has the same meaning as 'option sparse'.
2023-11-12 16:32:40 +01:00
Holger Vogt c87df54f24 Remove unused global variable cp_dol.
This also prevents a gcc 13 bug, as cp_dol has been set to '\0'
by -O2 optimization (see
https://stackoverflow.com/questions/77407156/s-0-being-optimized-out-possible-gcc-13-bug-or-some-undefined-behaviour)
2023-11-11 10:39:51 +01:00
Giles Atkinson 359e3d4609 Fix Bug #467 - ".OPTION INTERP has accuracy issue". 2023-11-09 12:09:05 +00:00
Giles Atkinson 10386ee3e3 Commit [35d338]ngspice partly reverted commit 423f9a9db to fix deletion
of source files if make was accidentally used in the source tree.
That caused the original bug to return.  Fix the problem by deleting
the generated source files by name (no such files exist in source.
Also make the generated files depend on cmpp, making 'make clean'
unnecessary after a chenge to cmpp.
2023-11-09 12:08:02 +00:00
Giles Atkinson f6f7319792 Add null-pointer checks to some code that crashed when trying
to .print results from a non-existent analysis.  Also remove the
troublesome .plot and .print lines from two examples.
2023-11-09 12:07:31 +00:00
Giles Atkinson 4228ba6e8a Ignore end-of-line comments in quoted strings. 2023-11-09 12:06:34 +00:00
Holger Vogt 0a087809d6 If both node names are the same, just print them once in the error message. 2023-11-08 13:12:06 +01:00
Brian Taylor 0555c5d9c7 Make previous KLU support check more transparent. 2023-11-08 11:49:28 +01:00
Brian Taylor 295f212de8 When CIDER is detected, until KLU works with CIDER, print Error: CIDER simulation is not (yet) supported with 'option klu'. Use 'option sparse' instead. and then call controlled exit(1). 2023-11-08 11:49:22 +01:00
dwarning 35d338f256 partly revert commit 423f9a9db - don't remove xspice/icm .c files 2023-11-08 07:59:36 +01:00
Holger Vogt d27b888f13 Noise simulation is buggy when using the KLU solver. Thus for now it is disabled.
Use 'option sparse' instead.
2023-11-06 15:03:09 +01:00
dwarning 4e1452cdb7 rm compiler warnings 2023-11-04 19:36:31 +01:00
Pascal Kuthe 5223f4b27d fix(hicuml2): ensure flicker noise power is always stored in state vec 2023-11-04 19:36:30 +01:00
Pascal Kuthe c21f87051a always compute osdi noise powers
ngspice will reuse operating points for noise analysis so we can not trust
the mode flags
2023-11-04 19:36:30 +01:00
Pascal Kuthe f66e0bf2ac implement osdi noise support 2023-11-04 19:36:30 +01:00
Brian Taylor 04c68d5f30 Cleanup child processes on Windows VisualC and Mingw. On Linux those processes quit when ngspice quits. 2023-10-28 19:45:24 +02:00
Brian Taylor 4219efb5d5 Make it explicit that null output ports are not allowed. The output port vector bounds are always >= 1. 2023-10-28 19:43:46 +02:00
Brian Taylor c83d11c9c0 Call cm_cexit() to prevent the simulator running when d_process initialization errors occur. 2023-10-28 19:43:23 +02:00
Holger Vogt 21761207bc Change license to 3-clause BSD (see
https://sourceforge.net/p/ngspice/ngspice/merge-requests/6/?limit=25#fd4f/73e6)
2023-10-28 14:55:13 +02:00
Brian Taylor 09f070f582 Error handling improvements in cfunc.mod. Ensure that d_process.h wiil always respond to version and interface checks sent from sendheader. This is needed so that the pipe reads in sendheader do not cause Windows to hang when the interface version and in/out counts do not match. This hang was the cause of errors not being reported and the Windows gui hanging. Startup and header checks are now detected in cm_d_process, and the simulator will run but with runtime errors since a d_process model cannot be completely instantiated after initial errors. It would be good to find a means of gracefully halting the simulation run. 2023-10-28 11:00:33 +02:00
Brian Taylor 8c72a76844 Another attempt at clean up of error handling and reporting. It's OK on limux and cygwin, but Windows VisualC is being stubborn. I would prefer not to have to call exit(1) just for Windows, since then nothing is reported and the gui disappears in a puff of smoke. Even without the exit calls nothing gets reported with the Windows gui which will hang when there are errors detected by d_process. 2023-10-28 11:00:28 +02:00
Brian Taylor 4eae039779 Add modifications note. 2023-10-28 11:00:23 +02:00
Brian Taylor 4530cde8e2 Use Xspice cm_message_send to report errors rathen than printing to stderr and calling exit. When a d_process model has errors found in start(), sendheader(), and dprocess_exchangedata() these are reported, but if the model is run a SIGINT is raised. There must be a better way of stopping the simulator. 2023-10-28 11:00:18 +02:00
Brian Taylor df28fabc42 Restore the deleted unused params to be backword compatible. Handle the case where the d_process instance has a null in vector, so that N_din is zero. This allows the model to be just a pattern generator. Add include to cmproto.h to avoid a forward ref. to an enum type. 2023-10-28 11:00:03 +02:00
Brian Taylor 307ba1985b Remove unused reset_state param; do not allow null in and out, so there is at least 1 input and 1 output. 2023-10-28 10:59:52 +02:00
Brian Taylor 7820940be3 Remove the unused reset_delay param. 2023-10-28 10:59:42 +02:00