Commit Graph

3879 Commits

Author SHA1 Message Date
Holger Vogt e1bd97d8f6 If C= or Q= is omitted in the instance line of a behavioral capacitor,
select as default the C= formulation, not the Q= formula..
2025-01-10 15:17:22 +01:00
Giles Atkinson 2666460663 Using XFlush() instead of XSync() avoids a round trip to the X server
on each call to DevUpdate().  That speeds plotting when using XQuartz
on Macintosh and makes iplot useable there.
2025-01-09 13:21:31 +01:00
Holger Vogt 1b7c8eb2d7 Fix a crash due to buggy user input.
Improve error message.
Reported in
https://gitlab.com/kicad/code/kicad/-/issues/19439#note_2277932762
2025-01-09 13:21:05 +01:00
Holger Vogt ce8480c690 Enable improved error message with nested .include. 2024-12-28 14:43:01 +01:00
Holger Vogt c7ee676e3d Improve the error message by hinting to the source of the error. 2024-12-28 14:42:49 +01:00
Holger Vogt a4e443fcce precautionary prevent passing instances which internally have got
upper case lettering. Removes a crash reported in
https://gitlab.com/kicad/code/kicad/-/issues/18648.
2024-12-27 11:18:00 +01:00
Holger Vogt ffde17441b Don't quote the subcircuit name in an X line 2024-12-27 11:15:09 +01:00
Giles Atkinson d549b882df Fix a crash that happens after an iplot window is zoomed and closed
while active.
2024-12-27 11:14:53 +01:00
Holger Vogt 1e4a6ac8b8 avoid memory leak by appending, not prepending the word 2024-12-15 10:29:32 +01:00
Holger Vogt a6ad2470f1 Add a flag compmod to struct card.
Set compmod to 1 if netlist line is included by command 'incpslt'
Guard special newcompat.hs sections by compmod
2024-12-15 10:29:23 +01:00
Holger Vogt 8b5a046cdb Remove again, not needed 2024-12-15 10:26:20 +01:00
Holger Vogt 8e9a115aa9 Update/remove comment(no longer valid) 2024-12-15 10:26:08 +01:00
Holger Vogt b7092ff19b Revert ABORTPROC to bool, where appropriate 2024-12-15 10:25:51 +01:00
Holger Vogt deb3cd9809 Replace all BOOLEAN, BOOL, _Bool by bool
Remove all #undef bool (set in conjunction with #iclude <Windows.h>)
2024-12-15 10:25:28 +01:00
Giles Atkinson 932ef50cc3 Improve two error messages: in d_cosim, report the filename given,
not the last one tried; and report attempted use of iplot or
tclplot in batch mode only once.
2024-12-06 22:50:37 +01:00
Holger Vogt 660b183ad0 Revise check for '.probe alli' and event nodes:
Bail out, don't run any sim, don't change variable
'auto_bridge'.
2024-12-06 22:49:40 +01:00
Holger Vogt 4eec6eb8e2 Fixes bug 723
New lines had been inadvertently written into the .control section.
2024-12-06 22:48:44 +01:00
Holger Vogt 2db9533380 Enable strings as parameters across subckt boundaries
by keeping the quotes and excluding {} around the string token.
2024-12-06 22:48:15 +01:00
Brian Taylor 6500caeba1 Now that checks on actuals and formals have been fixed for X* instances, some older PSpice libraries will not translate correctly in psa mode. This commit removes unnecessary power and ground nodes from X* instances of subcircuits where the nodes are optional. These X* instances occur within the body of another subcircuit which is being translated. MicroCap libraries that we can translate in ngspice do not have such cases. To enable the removal of the power and ground nodes, set ps_global_tmodels=1 in .spiceinit. This is not set by default since an extra pass through the circuit word list is necessary to find the subcircuits whose instances do not require power and ground node removal. Without enabling this feature, errors reporting too many parameters may be reported. 2024-12-06 22:45:13 +01:00
Holger Vogt 7d59ad2db7 Create extra name derived from node name, but with / replaced by _,
to become part of the new voltage source name: avoid names
which are not parsed correctly by the B source equation parser.
2024-12-06 22:43:26 +01:00
Holger Vogt a45c1500a6 Remove 512 char limit of sourcepath variable.
Make attaching new path more efficient.
2024-12-06 22:43:00 +01:00
Holger Vogt 22b4f4e632 Re-enable detection of over- or underflow of number of nodes
when calling a subcircuit.
Update to commit
c12296182 ("The code in src/frontend/subckt.c has a
fixed-size structure called table at the top with a
size set to N_GLOBAL_NODES = 1005.  If the number of
items passed in formal and actual exceeds 1005, then
ngspice exits immediately with an error.", 2023-03-14)
2024-12-06 22:42:16 +01:00
Holger Vogt 33ef1fc876 typos 2024-12-06 22:41:43 +01:00
Giles Atkinson b48224e514 Improve the behaviour of ngspice when run in the background on a
Unix-like OS with job control.  The progress ticker is suppressed
for a command like "ngspice some_circuit.cir &" so the terminal
remains usuable while the simulation runs.
2024-12-06 22:40:55 +01:00
Giles Atkinson 4feb0c3ccc Remove function cp_ccon() and related code. The function modifies
the terminal driver's treatment of the control-D (EOF) and escape
keys on Unix-like OSs.  But escape has no special meaning, and treating
control-D as a line terminator was probably to prevent unexpected
session exit when connected through a modem without error-correction.

Removing the function allows "ngspice netlist &" to work correctly.
The function was called during initialisation, which caused an endless
loop of job-control stops when ngspice was started as a background process.
2024-12-06 22:40:38 +01:00
Giles Atkinson 562466a3c5 Three minor code improvements. Remove a redundant test in com_measure2.c.
In vectors.c, always initialise a newly-created plot exactly once.
Improve an error message in spiceif.c.
2024-12-06 22:40:21 +01:00
Giles Atkinson fb63573b6b Fix processing of lines like: "*# pre_some_command ...". 2024-12-06 22:40:08 +01:00
Brian Taylor 75c2811fa9 Fix some memory leaks. 2024-12-06 22:39:49 +01:00
dwarning 3d20dc0da7 format - white spaces 2024-12-06 22:38:26 +01:00
dwarning bf6ffd357d Keep it simple: use only one structure and get_time function 2024-12-06 22:38:16 +01:00
dwarning 60554855d8 seconds() gives difftime to program start, lower priority for getrusage() and times() 2024-12-06 22:38:00 +01:00
dwarning 3faed1647a Reorder and renovate timer functions taking into account ngspice multiprocessor capabilities
by using available high performance functions first.
Deprecated ftime() still acts as a backup function.
Solution is portable for today's operating systems and compilers.
2024-12-06 22:35:02 +01:00
Holger Vogt 60ddad4983 Make the resistor name unique for a device with multiple unconnected nodes 2024-11-02 22:46:20 +01:00
Holger Vogt 793fca6e2a If preprocessing is skipped, we still need the number of lines in the deck. 2024-11-02 22:45:45 +01:00
Holger Vogt 8e05683592 Prevent crash if number of lines is wrong/not available ... 2024-11-02 22:45:35 +01:00
Holger Vogt 20d6fb460f Add a comment 2024-11-02 22:44:56 +01:00
Holger Vogt e2c4182888 Vectors Cy_xxx are of type 'current'. 2024-11-02 22:44:43 +01:00
Holger Vogt c716e34425 Use the correct type for each vector after S-parameter analysis.
Cy_1_1 is still missing (voltage as default).
2024-11-02 22:44:34 +01:00
Holger Vogt 27db91480b Fix bug no. 708, reported by Philip Sauvage. 2024-11-02 22:43:57 +01:00
Holger Vogt 368c59466b Allow plotting a single point in an ascii plot
(command .asciiplot)
2024-11-02 22:42:42 +01:00
Giles Atkinson 537d55d80b Improve an error message. 2024-11-02 22:42:12 +01:00
Giles Atkinson cf812da363 Try to clarify the mechanism of parameter substitution and add
an example of substituting an XSPICE vector parameter.
2024-11-02 22:41:59 +01:00
Holger Vogt d5f0c6598f Fix commit 09685dde1
("Set lower case for variables or vectors in command 'echo'.
Tokens starting with '$' will get lower-casing.", 2024-09-07)

Don't use s as name for temporary string, as s has been set
already and is used later.
2024-11-02 22:39:03 +01:00
Holger Vogt b62528d7e5 Set lower case for variables or vectors in command 'echo'.
Tokens starting with '$' will get lower-casing.
2024-11-02 22:38:49 +01:00
Holger Vogt 287280c3db Make error messages more verbose:
add line number and source file name.
2024-11-02 22:37:47 +01:00
Holger Vogt bce621680b Add line number and source file to some error messages 2024-11-02 22:37:31 +01:00
Holger Vogt 8e8716abc7 Fix warning message 2024-11-02 22:37:12 +01:00
Holger Vogt c2c35b56a4 More on verbose error and warning messages 2024-11-02 22:36:46 +01:00
Holger Vogt 4e6af5a55f Allow KiCad special token V(/xyz) by quoting 2024-11-02 22:36:26 +01:00
Holger Vogt c33fd66a21 Make error messages more verbose:
add line number and source file name.
2024-11-02 22:36:11 +01:00