Commit Graph

52 Commits

Author SHA1 Message Date
Brian Taylor a2f081f89d Completed and cleaned up memory leak fixes in:
inpc_probe.c outitf.c inpcom.c niiter.c
cherry-pick of this one commit should be OK.
2026-05-18 22:17:40 -07:00
Brian Taylor df95d04ba3 Revert "Fix memory leaks for paranoia_parallel."
This reverts commit cf825fd80a.
2026-05-18 22:02:44 -07:00
Brian Taylor cf825fd80a Fix memory leaks for paranoia_parallel.
Tests with leaks:
  examples/various/probe-i-dev.cir
  examples/vdmos/100W.sp
  multiple tests using OUTpBeginPlot, add_to_sourcepath
2026-05-16 13:22:48 -07:00
dwarning 69da75f7f0 intel cc see obsolete }; as empty declaration 2024-11-03 10:43:46 +01:00
Brian Taylor 4a9a734bf3 Fix bug #680. Check that src/dest memcpy arguments are non-NULL. 2024-08-23 19:52:30 +02:00
Holger Vogt 6ea6f8d9a8 Add a comment 2024-08-03 16:08:41 +02:00
Holger Vogt 0a087809d6 If both node names are the same, just print them once in the error message. 2023-11-08 13:12:06 +01:00
Holger Vogt a6d5ce8ea6 Some KLU warnings are useless for the normal user, as she or he
does not have any means to further analyze or repair the issue:
Warning: KLU ReFactor failed. Factoring again...
Warning (ReFactor Complex): KLU Matrix is SINGULAR
    Numerical Rank: %d\n
    Singular Node: %d\n
So print these messages only in debug mode.
2023-09-10 14:41:16 +02:00
Francesco Lannutti caf1ee7c47 Fixed a crash when SPARSE is used 2023-08-16 11:14:21 +02:00
Francesco Lannutti 3c15993fe5 Fixed the case when DiagGmin has to not be loaded again and the case when refactoring returns 1 2023-08-16 11:14:21 +02:00
Francesco Lannutti 967ee13940 Added a comment in NIiter 2023-08-16 11:14:19 +02:00
Francesco Lannutti 5513f6e5f6 Handled the SINGULAR matrix case in a more clever way! 2023-08-16 11:14:18 +02:00
Francesco Lannutti fbd8d94cdf Fixed again the NIiter loop for KLU 2023-08-16 11:14:17 +02:00
Francesco Lannutti 710341bbfd Fixed KLU returns values so that NIiter can Factor again, if the matrix is numerically singular from the refactorization
Fixed the NIiter code to perform a factorization without reloading the matrix
2023-08-16 11:14:17 +02:00
dwarning a4f6a777c0 few cleanings to prevent compiler warnings 2023-05-27 10:41:21 +02:00
Holger Vogt 27fb6cd0a6 Allow resetting the limit for warning mesaages, when a new run is started. 2022-12-11 15:32:11 +01:00
Holger Vogt 8e175f1e77 Replace obscure warning "singular matrix: check nodes mymode1 and mynode1" by
"singular matrix: check node mynode1", if both node names are equal.
2022-12-11 15:31:41 +01:00
Holger Vogt b46dd5effd Limit the number of messages 'Warning singular matrix: ...' to 6,
if not 'set ngdebug'
2022-10-07 11:35:38 +02:00
Holger Vogt 54cbfb4138 Nodedamping: Make difference independent of the sign
of the difference
2021-07-05 14:32:57 +02:00
Holger Vogt b0e7962169 don't generate error message during transient analysis,
it will not be used
2018-09-02 18:04:42 +02:00
rlar caf3115733 cleanup, emphasise CKTrhs being an array
when accessing slot [0]
2018-01-29 19:51:13 +01:00
rlar a5817192e1 ni/niiter.c, #5/5, whitespace 2016-07-30 21:03:55 +02:00
rlar 266e6da24b ni/niiter.c, #4/5, cleanup 2016-07-30 21:03:49 +02:00
rlar dda415a0e3 ni/niiter.c, #3/5, use `copy()' 2016-07-30 21:03:29 +02:00
rlar 86bb88b546 ni/niiter.c, #2/5, reduce scope 2016-07-30 21:03:19 +02:00
rlar 2978621931 ni/niiter.c, #1/5, cleanup 2016-07-30 21:03:00 +02:00
rlar 5b42d09618 unify, use memcpy for CKTstate copy operations 2016-07-30 21:00:29 +02:00
rlar 40a0cea0d2 swap some `SWAP' arguments for readability 2016-03-22 15:23:05 +01:00
rlar bd0bc3038b use `SWAP' macro 2016-03-22 13:04:13 +01:00
rlar 4049e8ec1f rewrite, using IFerrorf() 2014-04-04 21:58:08 +02:00
rlar ea7372efe7 rewrite, useing IFerrorf()
OUTerror() and IFerror() are no more used,
  but kept for compatibility
2014-04-04 21:22:48 +02:00
rlar 6050e2e0ea cleanup some extra parentheses 2013-12-31 16:12:44 +01:00
rlar b3847817a1 retire #define NODE_VOLTAGE, use SP_VOLTAGE instead
(grep "git --no-pager grep -nH -e '\\(SP_\\|NODE_\\)\\(VOLTAGE\\|CURRENT\\)'")
2013-12-31 12:56:22 +01:00
rlar 4184aa8c10 cleanup, use array operator
checked for object file invariance on linux with
   ./configure --enable-debug=no --enable-maintainer-mode --with-readline=yes --enable-cider --enable-ndev --enable-pss --enable-xspice
2013-12-31 12:54:43 +01:00
Francesco Lannutti e27d43cd0c remove empty src/maths/ni/*.h include files 2012-12-24 11:28:30 +01:00
h_vogt cea4eb09d6 niiter.c: indentations 2012-12-15 20:07:42 +01:00
rlar 0beb95757f cancer of the semicolon 2012-08-07 21:20:36 +02:00
rlar 10346e055c #1/4 #include <ngspice/...> --> #include "ngspice/..." 2011-12-11 18:05:00 +00:00
rlar d26015586c #1/7 use a subdirectory "ngspice" for includes to create a uniq namespace 2011-08-20 17:27:09 +00:00
rlar 23056573d8 code cleanup, drop NULL pointer casts 2011-04-28 15:59:36 +00:00
rlar 0b6a557334 code cleanup 2011-04-27 18:30:15 +00:00
rlar 7b3960506f wrap tmalloc MALLOC etc, into two macros TMALLOC and TREALLOC 2010-10-28 19:32:34 +00:00
rlar 3369d860b4 cast the return values of malloc() function calls 2010-07-01 19:52:23 +00:00
dwarning 41325622fd some clean-up's to come through MSC 2007-10-18 19:34:30 +00:00
pnenzi 6d5a4474aa Fixed minimum iterations number to 100 (Phil Barker) 2007-10-10 11:21:16 +00:00
pnenzi 008c9d7a4c Improved reporting (from Phil Barker) 2007-10-08 15:36:56 +00:00
pnenzi 5296cd51b8 Partially applied Paul Reich patch (missing include and c++ style comments) 2005-12-04 08:52:10 +00:00
pnenzi 363ffb85e0 Fixed bug in memory management when xspice codemodels are used. 2005-08-04 08:23:32 +00:00
pnenzi ada277e81b Cleaned up the code removing unnecessary includes. 2004-01-20 20:32:57 +00:00
pnenzi 8362dec274 Integrated code from tclspice, brorson xspice and Vera memleak. 2003-07-23 19:36:39 +00:00