luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lef: cleanup mark unnecessary call to function with no side-effects 

Maybe these function call can be removed or at least their return
value discarded (as the returned value is never used).
This commit is contained in:
Darryl L. Miles 2025-01-04 09:04:49 +00:00 committed by Tim Edwards
parent 56bf27548d
commit ed87c3a98b
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lef/lefRead.c
View File

@ -1247,7 +1247,7 @@ LefReadGeometry(
{
if (is_imported)
{
int pNum = DBPlane(curlayer);
int pNum = DBPlane(curlayer); /* FIXME unused return value from call to function with no side-effects */
SearchContext scx;
CellUse dummy;
PlaneType pt;

2
lef/lefTech.c
View File

@ -304,7 +304,7 @@ LefTechLine(
if (newlefl == NULL)
{
float oscale = CIFGetOutputScale(1000);
float oscale = CIFGetOutputScale(1000); /* FIXME unused return value from call to function with no side-effects */
newlefl = (lefLayer *)mallocMagic(sizeof(lefLayer));
newlefl->refCnt = 0;

4
lef/lefWrite.c
View File

@ -2082,7 +2082,7 @@ lefGetSites(
propvalue = (char *)DBPropGet(def, "LEFsite", &propfound);
if (propfound)
he = HashFind(lefSiteTbl, propvalue);
he = HashFind(lefSiteTbl, propvalue); /* FIXME return value not used from call to function with no side-effects (reevaluate this entire func purpose?) */
return 0;
}
@ -2124,7 +2124,7 @@ lefGetProperties(
while (*psrch != ' ' && *psrch != '\0') psrch++;
if (*psrch == '\0') break;
*psrch = '\0';
he = HashFind(lefPropTbl, key);
he = HashFind(lefPropTbl, key); /* FIXME return value not used from call to function with no side-effects */
/* Potentially to do: Handle INT and REAL types */
/* For now, only STRING properties are handled. */