From ed87c3a98b03edb52d2b56358b38c28bf0256c87 Mon Sep 17 00:00:00 2001 From: "Darryl L. Miles" Date: Sat, 4 Jan 2025 09:04:49 +0000 Subject: [PATCH] lef: cleanup mark unnecessary call to function with no side-effects Maybe these function call can be removed or at least their return value discarded (as the returned value is never used). --- lef/lefRead.c | 2 +- lef/lefTech.c | 2 +- lef/lefWrite.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lef/lefRead.c b/lef/lefRead.c index edc44966..eae676fc 100644 --- a/lef/lefRead.c +++ b/lef/lefRead.c @@ -1247,7 +1247,7 @@ LefReadGeometry( { if (is_imported) { - int pNum = DBPlane(curlayer); + int pNum = DBPlane(curlayer); /* FIXME unused return value from call to function with no side-effects */ SearchContext scx; CellUse dummy; PlaneType pt; diff --git a/lef/lefTech.c b/lef/lefTech.c index ce61487d..36dabcb1 100644 --- a/lef/lefTech.c +++ b/lef/lefTech.c @@ -304,7 +304,7 @@ LefTechLine( if (newlefl == NULL) { - float oscale = CIFGetOutputScale(1000); + float oscale = CIFGetOutputScale(1000); /* FIXME unused return value from call to function with no side-effects */ newlefl = (lefLayer *)mallocMagic(sizeof(lefLayer)); newlefl->refCnt = 0; diff --git a/lef/lefWrite.c b/lef/lefWrite.c index 557a3fc8..6d102d1f 100644 --- a/lef/lefWrite.c +++ b/lef/lefWrite.c @@ -2082,7 +2082,7 @@ lefGetSites( propvalue = (char *)DBPropGet(def, "LEFsite", &propfound); if (propfound) - he = HashFind(lefSiteTbl, propvalue); + he = HashFind(lefSiteTbl, propvalue); /* FIXME return value not used from call to function with no side-effects (reevaluate this entire func purpose?) */ return 0; } @@ -2124,7 +2124,7 @@ lefGetProperties( while (*psrch != ' ' && *psrch != '\0') psrch++; if (*psrch == '\0') break; *psrch = '\0'; - he = HashFind(lefPropTbl, key); + he = HashFind(lefPropTbl, key); /* FIXME return value not used from call to function with no side-effects */ /* Potentially to do: Handle INT and REAL types */ /* For now, only STRING properties are handled. */