luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Removed an oddball method put into the extflat code some time ago 

that makes a net a global net if there is a Tcl variable of the
same name.  This conflicts with a later use of Tcl variables VDD
and GND to denote power and ground names, which is a completely
different usage.
This commit is contained in:
Tim Edwards 2021-12-25 16:14:37 -05:00
parent 86f7c1f2cf
commit 9af44230eb
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
VERSION
View File

@ -1 +1 @@
8.3.244 8.3.245

10
extflat/EFname.c
View File

@ -73,6 +73,12 @@ extern void efHNRecord();
* also check if the array variable "globals" contains the name as * also check if the array variable "globals" contains the name as
* a key entry. * a key entry.
* *
* Updated 12/2021: Removed the check for Tcl variable names matching
* the net name. This seems like a bad idea all around. Left just the
* check for the array variable "globals". Otherwise use of VDD and GND
* variables cause nets named VDD and GND to become globals, which was
* not intended.
*
* Results: * Results:
* TRUE if the name is a global. * TRUE if the name is a global.
* *
@ -92,8 +98,8 @@ EFHNIsGlob(hierName)
TCL_GLOBAL_ONLY); TCL_GLOBAL_ONLY);
if (retstr != NULL) return TRUE; if (retstr != NULL) return TRUE;
retstr = (char *)Tcl_GetVar(magicinterp, hierName->hn_name, TCL_GLOBAL_ONLY); // retstr = (char *)Tcl_GetVar(magicinterp, hierName->hn_name, TCL_GLOBAL_ONLY);
if (retstr != NULL) return TRUE; // if (retstr != NULL) return TRUE;
#endif #endif
return hierName->hn_name[strlen(hierName->hn_name) - 1] == '!'; return hierName->hn_name[strlen(hierName->hn_name) - 1] == '!';
} }