From 9af44230ebacbaa67cfbd3075fa97e3f68b9bfd9 Mon Sep 17 00:00:00 2001 From: Tim Edwards Date: Sat, 25 Dec 2021 16:14:37 -0500 Subject: [PATCH] Removed an oddball method put into the extflat code some time ago that makes a net a global net if there is a Tcl variable of the same name. This conflicts with a later use of Tcl variables VDD and GND to denote power and ground names, which is a completely different usage. --- VERSION | 2 +- extflat/EFname.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/VERSION b/VERSION index 885da2ba..8ddea425 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -8.3.244 +8.3.245 diff --git a/extflat/EFname.c b/extflat/EFname.c index 8cec5931..017de1a2 100644 --- a/extflat/EFname.c +++ b/extflat/EFname.c @@ -73,6 +73,12 @@ extern void efHNRecord(); * also check if the array variable "globals" contains the name as * a key entry. * + * Updated 12/2021: Removed the check for Tcl variable names matching + * the net name. This seems like a bad idea all around. Left just the + * check for the array variable "globals". Otherwise use of VDD and GND + * variables cause nets named VDD and GND to become globals, which was + * not intended. + * * Results: * TRUE if the name is a global. * @@ -92,8 +98,8 @@ EFHNIsGlob(hierName) TCL_GLOBAL_ONLY); if (retstr != NULL) return TRUE; - retstr = (char *)Tcl_GetVar(magicinterp, hierName->hn_name, TCL_GLOBAL_ONLY); - if (retstr != NULL) return TRUE; + // retstr = (char *)Tcl_GetVar(magicinterp, hierName->hn_name, TCL_GLOBAL_ONLY); + // if (retstr != NULL) return TRUE; #endif return hierName->hn_name[strlen(hierName->hn_name) - 1] == '!'; }