luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

utils/main.c: LefRead() Call to function with fewer arguments than declared parameters 

Looks like -1 is accepted as placeholder, maybe it should be the
temporary->fn (filename mtime?).

Copilot Autofix rejected: LefRead(temporary->fn, FALSE, NULL);

related git blame utils/main.c:
8e80644d (2022-01-22 13:30:11 -0500 2078)     int lefTimestamp;         /* If not -1, use the value pointed to
8e80644d (2022-01-22 13:30:11 -0500 2884)     int lefTimestamp;

related commit:
commit 8e80644dd7
Date:   Sat Jan 22 13:30:11 2022 -0500

CodeQL: https://github.com/dlmiles/magic/security/code-scanning/28
This commit is contained in:
Darryl L. Miles 2024-09-29 23:00:00 +01:00 committed by Tim Edwards
parent 49f4daa715
commit 3db35216b9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
utils/main.c
View File

@ -1188,7 +1188,7 @@ mainInitFinal()
break;
#ifdef LEF_MODULE
case FN_LEF_FILE:
LefRead(temporary->fn, FALSE, FALSE);
LefRead(temporary->fn, FALSE, FALSE, -1);
break;
case FN_DEF_FILE:
DefRead(temporary->fn, FALSE);