From 3db35216b9f2c23d11481fee65f7ccdbeb33de55 Mon Sep 17 00:00:00 2001 From: "Darryl L. Miles" Date: Sun, 29 Sep 2024 23:00:00 +0100 Subject: [PATCH] utils/main.c: LefRead() Call to function with fewer arguments than declared parameters Looks like -1 is accepted as placeholder, maybe it should be the temporary->fn (filename mtime?). Copilot Autofix rejected: LefRead(temporary->fn, FALSE, NULL); related git blame utils/main.c: 8e80644d (2022-01-22 13:30:11 -0500 2078) int lefTimestamp; /* If not -1, use the value pointed to 8e80644d (2022-01-22 13:30:11 -0500 2884) int lefTimestamp; related commit: commit 8e80644dd76495b37bf8b2303ae7a29c757fa2a2 Date: Sat Jan 22 13:30:11 2022 -0500 CodeQL: https://github.com/dlmiles/magic/security/code-scanning/28 --- utils/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/main.c b/utils/main.c index 0ffc84da..ecfca76f 100644 --- a/utils/main.c +++ b/utils/main.c @@ -1188,7 +1188,7 @@ mainInitFinal() break; #ifdef LEF_MODULE case FN_LEF_FILE: - LefRead(temporary->fn, FALSE, FALSE); + LefRead(temporary->fn, FALSE, FALSE, -1); break; case FN_DEF_FILE: DefRead(temporary->fn, FALSE);