luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

graphics/grDStyle.c: Incorrect return-value check for a 'scanf'-like function 

Fix code scanning alert no. 151: Incorrect return-value check for a 'scanf'-like function (#7)

* Create codeql.yml

* Fix code scanning alert no. 151: Incorrect return-value check for a 'scanf'-like function

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Update grDStyle.c

* AI suggested '< 1', DLM edited to '<= 0' easier for a human to reason about ?

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This commit is contained in:
Darryl Miles 2024-09-30 01:48:04 +01:00 committed by Tim Edwards
parent 64d94ae588
commit 39e76f3f31
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
graphics/grDStyle.c
View File

@ -229,7 +229,7 @@ styleBuildDisplayStyle(line, version)
*/
/* Allow colors to be specified by index or by name */
if (sscanf(colorName, ((version > 6) ? "%i" : "%o"), &color) == 0)
if (sscanf(colorName, ((version > 6) ? "%i" : "%o"), &color) <= 0)
color = GrNameToColor(colorName);
newstyle->style.mask = (mask & grBitPlaneMask);