From 39e76f3f31c7a6fff1ee741df4e85efc07962eb4 Mon Sep 17 00:00:00 2001 From: Darryl Miles Date: Mon, 30 Sep 2024 01:48:04 +0100 Subject: [PATCH] graphics/grDStyle.c: Incorrect return-value check for a 'scanf'-like function Fix code scanning alert no. 151: Incorrect return-value check for a 'scanf'-like function (#7) * Create codeql.yml * Fix code scanning alert no. 151: Incorrect return-value check for a 'scanf'-like function Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Update grDStyle.c * AI suggested '< 1', DLM edited to '<= 0' easier for a human to reason about ? --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --- graphics/grDStyle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphics/grDStyle.c b/graphics/grDStyle.c index 57d8f7b6..d85c15e4 100644 --- a/graphics/grDStyle.c +++ b/graphics/grDStyle.c @@ -229,7 +229,7 @@ styleBuildDisplayStyle(line, version) */ /* Allow colors to be specified by index or by name */ - if (sscanf(colorName, ((version > 6) ? "%i" : "%o"), &color) == 0) + if (sscanf(colorName, ((version > 6) ? "%i" : "%o"), &color) <= 0) color = GrNameToColor(colorName); newstyle->style.mask = (mask & grBitPlaneMask);