luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Discovered an error in region and net selection that can cause 

unrelated nets to be captured in the same selection, due to the
use of the label bounding box instead of the label rectangle.
The bounding box is used for display only and should not be used
for connectivity.
This commit is contained in:
Tim Edwards 2023-07-29 20:36:46 -04:00
parent 6b5bd149fc
commit 2aab645308
5 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
VERSION
View File

@ -1 +1 @@
8.3.418
8.3.419

4
database/DBcellsrch.c
View File

@ -619,8 +619,8 @@ DBTreeSrLabels(scx, mask, xMask, tpath, flags, func, cdarg)
r1.r_ybot = r->r_ytop;
r2.r_xbot = r->r_xtop;
}
is_touching = GEO_TOUCH(&lab->lab_bbox, &r1) ||
GEO_TOUCH(&lab->lab_bbox, &r2);
is_touching = GEO_TOUCH(&lab->lab_rect, &r1) ||
GEO_TOUCH(&lab->lab_rect, &r2);
}
else
is_touching = GEO_TOUCH(&lab->lab_rect, r);

9
doc/html/ext2sim.html
View File

@ -128,6 +128,15 @@ Convert extracted file(s) to a ".sim" format file.
of search for area and perimeter is the whole netlist. In
general, <B>flat</B> (which is the default) will give accurate
results (it will take into account shared sources/drains).
<DT> <B>-p</B> <I>path</I>
<DD> Search the directory location <I>path</I> for .ext format
files. This option is typically used with the "<B>extract
path</B> <I>path</I>" command, because extraction and netlist
generation are two independent steps. If this option is not
specified, then by default the .ext file is expected to be in
the same location as the corresponding .mag file, and failing
that, the search path for .ext files is the same as the search
path for .mag files.
</DL>
</BLOCKQUOTE>

9
doc/html/ext2spice.html
View File

@ -273,6 +273,15 @@ Convert extracted file(s) to a SPICE format file.
of search for area and perimeter is the whole netlist. In
general, <B>flat</B> (which is the default) will give accurate
results (it will take into account shared sources/drains).
<DT> <B>-p</B> <I>path</I>
<DD> Search the directory location <I>path</I> for .ext format
files. This option is typically used with the "<B>extract
path</B> <I>path</I>" command, because extraction and netlist
generation are two independent steps. If this option is not
specified, then by default the .ext file is expected to be in
the same location as the corresponding .mag file, and failing
that, the search path for .ext files is the same as the search
path for .mag files.
</DL>
</BLOCKQUOTE>

5
doc/html/extract.html
View File

@ -140,7 +140,10 @@ Circuit netlist extractor
the user, in which case the file is extracted to the
current working diretory. Note that "<B>extract do local</B>"
is the same as "<B>extract path .</B>" and "<B>extract no local</B>"
is the same as "<B>extract path none</B>".
is the same as "<B>extract path none</B>". Also note that
netlist generation is independent of extraction, and needs to
specify the same path as used by <B>extract path</B>, e.g.,
"<B>ext2spice -p</B> <I>pathname</I>".
<DT> <B>parents</B>
<DD> Extract the selected cell and all its parents
<DT> <B>showparents</B>