luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Elaborate widths of parameters correctly for unsigned values 

If there is no size in the parameter type declaration or on the
value itself, then give the parameter value a minimum width of
integer bits.
This commit is contained in:
Stephen Williams 2014-02-11 18:24:12 -08:00
parent 801e795112
commit be5bfeb172
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
net_design.cc
View File

@ -483,6 +483,20 @@ void NetScope::evaluate_parameter_logic_(Design*des, param_ref_t cur)
des->errors += 1; des->errors += 1;
return; return;
} }
// If the parameter has type or range information, then
// make sure the type is set right. Note that if the
// parameter doesn't have an explicit type or range,
// then it will get the signedness from the expression itself.
if (cur->second.type != IVL_VT_NO_TYPE) {
expr->cast_signed(cur->second.signed_flag);
} else if (cur->second.signed_flag) {
expr->cast_signed(true);
}
if (!range_flag && !expr->has_width()) {
expr = pad_to_width(expr, integer_width, *expr);
}
break; break;
default: default:
@ -492,17 +506,8 @@ void NetScope::evaluate_parameter_logic_(Design*des, param_ref_t cur)
des->errors += 1; des->errors += 1;
return; return;
} }
(*cur).second.val = expr;
/* If the parameter has type or range information, then make cur->second.val = expr;
sure the type is set right. Note that if the parameter
doesn't have an explicit type or range, then it will get
the signedness from the expression itself. */
if ((*cur).second.type != IVL_VT_NO_TYPE) {
(*cur).second.val->cast_signed((*cur).second.signed_flag);
} else if ((*cur).second.signed_flag) {
(*cur).second.val->cast_signed(true);
}
// If there are no value ranges to test the value against, // If there are no value ranges to test the value against,
// then we are done. // then we are done.