luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check for mixed assignment conflicts in procedural indexed part selects.

This commit is contained in:
Martin Whitaker 2024-02-03 21:16:57 +00:00
parent d4759e02aa
commit 3a2a1fb93d
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
elab_lval.cc
View File

@ -841,7 +841,7 @@ bool PEIdent::elaborate_lval_net_idx_(Design*des,
NetAssign_*lv, NetAssign_*lv,
index_component_t::ctype_t use_sel, index_component_t::ctype_t use_sel,
bool need_const_idx, bool need_const_idx,
bool /*is_force*/) const bool is_force) const
{ {
if (lv->sig()->data_type() == IVL_VT_STRING) { if (lv->sig()->data_type() == IVL_VT_STRING) {
cerr << get_fileline() << ": error: Cannot index part select assign to a string ('" cerr << get_fileline() << ": error: Cannot index part select assign to a string ('"
@ -944,6 +944,14 @@ bool PEIdent::elaborate_lval_net_idx_(Design*des,
rel_base = reg->sb_to_idx(prefix_indices,lsv) + offset; rel_base = reg->sb_to_idx(prefix_indices,lsv) + offset;
} }
delete base; delete base;
if ((reg->type()==NetNet::UNRESOLVED_WIRE) && !is_force) {
ivl_assert(*this, reg->coerced_to_uwire());
if (reg->test_part_driven(rel_base+wid-1, rel_base)) {
report_mixed_assignment_conflict_("part select");
des->errors += 1;
return false;
}
}
/* If we cover the entire lvalue just skip the select. */ /* If we cover the entire lvalue just skip the select. */
if (rel_base == 0 && wid == reg->vector_width()) return true; if (rel_base == 0 && wid == reg->vector_width()) return true;
base = new NetEConst(verinum(rel_base)); base = new NetEConst(verinum(rel_base));
@ -985,6 +993,12 @@ bool PEIdent::elaborate_lval_net_idx_(Design*des,
des->errors += 1; des->errors += 1;
return false; return false;
} }
if ((reg->type()==NetNet::UNRESOLVED_WIRE) && !is_force) {
ivl_assert(*this, reg->coerced_to_uwire());
report_mixed_assignment_conflict_("part select");
des->errors += 1;
return false;
}
ivl_assert(*this, prefix_indices.size()+1 == reg->packed_dims().size()); ivl_assert(*this, prefix_indices.size()+1 == reg->packed_dims().size());
/* Correct the mux for the range of the vector. */ /* Correct the mux for the range of the vector. */
if (use_sel == index_component_t::SEL_IDX_UP) { if (use_sel == index_component_t::SEL_IDX_UP) {