mirror of
https://github.com/The-OpenROAD-Project/OpenSTA.git
synced 2026-09-08 04:31:14 +02:00
Clean up test suite per 3-way code review findings
- Remove temp files: network_gcd_traversal.log, util_report_redirect.log - Delete 19 comment-only C++ test stubs (dead code for removed APIs) - Remove redundant graph_make_verify test (covered by graph_advanced) - Centralize assert_file_nonempty/assert_file_contains into test/helpers.tcl and remove inline copies from 17 verilog test files - Fix Build.sh stray quotes in heredoc output - Fix regression.sh unquoted variable expansions - Update .gitignore: add */test/*.log and Testing/ All 6087 tests pass. Co-Authored-By: Claude <[email protected]> Signed-off-by: Jaehyun Kim <[email protected]>
This commit is contained in:
Jaehyun Kim
Claude
@@ -747,12 +747,6 @@ TEST_F(StaInitTest, SetArcDelayCalc) {
|
||||
ASSERT_NO_THROW(sta_->setArcDelayCalc("lumped_cap"));
|
||||
}
|
||||
|
||||
// Parasitic analysis pts
|
||||
TEST_F(StaInitTest, SetParasiticAnalysisPts) {
|
||||
// setParasiticAnalysisPts removed from API
|
||||
// setParasiticAnalysisPts removed from API
|
||||
}
|
||||
|
||||
// RemoveClockGroupsNull removed — nullptr now throws std::logic_error
|
||||
|
||||
// FindReportPathField
|
||||
@@ -1891,12 +1885,6 @@ TEST_F(StaInitTest, CornersBeginEnd) {
|
||||
EXPECT_EQ(static_cast<size_t>(count), corners.size());
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, CornersOperatingConditionsChanged) {
|
||||
// operatingConditionsChanged removed from SceneSeq
|
||||
// No crash
|
||||
|
||||
}
|
||||
|
||||
// Levelize.cc uncovered functions
|
||||
TEST_F(StaInitTest, LevelizeNotLevelized) {
|
||||
Levelize *levelize = sta_->levelize();
|
||||
@@ -2118,13 +2106,6 @@ TEST_F(StaInitTest, ClkSkewPaths) {
|
||||
EXPECT_EQ(skew.tgtPath(), nullptr);
|
||||
}
|
||||
|
||||
// ClkSkews class
|
||||
TEST_F(StaInitTest, ClkSkewsExists) {
|
||||
// ClkSkews is a component of Sta
|
||||
// Access through sta_ members
|
||||
|
||||
}
|
||||
|
||||
// CheckMaxSkews
|
||||
TEST_F(StaInitTest, CheckMaxSkewsExists) {
|
||||
// maxSkewSlack/maxSkewViolations removed from Sta API
|
||||
@@ -2280,13 +2261,6 @@ TEST_F(StaInitTest, ReportPathFormatValues) {
|
||||
static_cast<int>(ReportPathFormat::slack_only));
|
||||
}
|
||||
|
||||
// Variables - additional variables
|
||||
TEST_F(StaInitTest, VariablesSearchPreamble) {
|
||||
// Search preamble requires network but we can test it won't crash
|
||||
// when there's no linked design
|
||||
|
||||
}
|
||||
|
||||
// Sta::clear on empty
|
||||
TEST_F(StaInitTest, StaClearEmpty) {
|
||||
sta_->clear();
|
||||
@@ -2298,12 +2272,6 @@ TEST_F(StaInitTest, StaClearEmpty) {
|
||||
// (skipping because requires linked design)
|
||||
|
||||
// Additional Sta functions that exercise uncovered code paths
|
||||
TEST_F(StaInitTest, StaSearchPreambleNoDesign) {
|
||||
// searchPreamble requires ensureLinked which needs a network
|
||||
// We can verify the pre-conditions
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaTagCount) {
|
||||
TagIndex count = sta_->tagCount();
|
||||
EXPECT_GE(count, 0u);
|
||||
@@ -2334,11 +2302,6 @@ TEST_F(StaInitTest, StaMaxPathCountVertex) {
|
||||
}
|
||||
|
||||
// More Sta.cc function coverage
|
||||
TEST_F(StaInitTest, StaSetSlewLimitClock) {
|
||||
// Without a clock this is a no-op - just exercise code path
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaOperatingConditions) {
|
||||
const OperatingConditions *op = sta_->operatingConditions(MinMax::min(), sta_->cmdSdc());
|
||||
// May be null without a liberty lib
|
||||
@@ -2351,11 +2314,6 @@ TEST_F(StaInitTest, StaDelaysInvalidEmpty) {
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaFindRequiredsEmpty) {
|
||||
// Without timing, this should be a no-op
|
||||
// findRequireds removed from public Sta API
|
||||
}
|
||||
|
||||
// Additional Property types coverage
|
||||
TEST_F(StaInitTest, PropertyValuePwrActivity) {
|
||||
PwrActivity activity;
|
||||
@@ -2451,18 +2409,6 @@ TEST_F(StaInitTest, StaClearLogicConstants) {
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaSetParasiticAnalysisPtsNotPerCorner) {
|
||||
// setParasiticAnalysisPts removed from API
|
||||
// No crash
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaSetParasiticAnalysisPtsPerCorner) {
|
||||
// setParasiticAnalysisPts removed from API
|
||||
// No crash
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaDeleteParasitics) {
|
||||
sta_->deleteParasitics();
|
||||
// No crash on empty
|
||||
@@ -2490,14 +2436,6 @@ TEST_F(StaInitTest, WnsSlackLessConstructor) {
|
||||
|
||||
}
|
||||
|
||||
// Additional Sta.cc report functions
|
||||
TEST_F(StaInitTest, StaReportPathEndHeaderFooter) {
|
||||
// reportPathEndHeader removed from API
|
||||
// reportPathEndFooter removed from API
|
||||
// Just exercise without crash
|
||||
|
||||
}
|
||||
|
||||
// Sta.cc - make functions already called by makeComponents,
|
||||
// but exercising the public API on the Sta
|
||||
|
||||
@@ -2618,24 +2556,6 @@ TEST_F(StaInitTest, StaMakeExceptionTo) {
|
||||
EXPECT_EQ(to, nullptr);
|
||||
}
|
||||
|
||||
// Sta.cc - checkTiming
|
||||
TEST_F(StaInitTest, StaCheckTimingNoDesign) {
|
||||
// checkTiming requires a linked network - just verify the method exists
|
||||
|
||||
}
|
||||
|
||||
// Exercise Sta.cc setPvt without instance
|
||||
TEST_F(StaInitTest, StaSetPvtMinMax) {
|
||||
// Can't call without instance/design, but verify the API exists
|
||||
// setPvt removed from public Sta API
|
||||
}
|
||||
|
||||
// Sta.cc - endpoint-related functions
|
||||
TEST_F(StaInitTest, StaEndpointViolationCountNoDesign) {
|
||||
// Requires graph, skip
|
||||
// endpointViolationCount removed from public Sta API
|
||||
}
|
||||
|
||||
// Additional coverage for SceneSeq iteration
|
||||
TEST_F(StaInitTest, CornersRangeForIteration) {
|
||||
const SceneSeq &corners = sta_->scenes();
|
||||
@@ -3035,11 +2955,6 @@ TEST_F(StaInitTest, StaEnsureClkArrivals) {
|
||||
EXPECT_THROW(sta_->ensureClkArrivals(), std::exception);
|
||||
}
|
||||
|
||||
// startpointPins() is declared in Sta.hh but not defined - skip
|
||||
TEST_F(StaInitTest, StaStartpointPins) {
|
||||
// startpointPins not implemented
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaEndpoints2) {
|
||||
EXPECT_THROW(sta_->endpoints(), std::exception);
|
||||
}
|
||||
@@ -3087,18 +3002,6 @@ TEST_F(StaInitTest, StaSetReportPathFormat2) {
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaReportPathEndHeader) {
|
||||
// reportPathEndHeader removed from API
|
||||
// No crash
|
||||
|
||||
}
|
||||
|
||||
TEST_F(StaInitTest, StaReportPathEndFooter) {
|
||||
// reportPathEndFooter removed from API
|
||||
// No crash
|
||||
|
||||
}
|
||||
|
||||
// --- Sta.cc: operating conditions ---
|
||||
TEST_F(StaInitTest, StaSetOperatingConditions) {
|
||||
sta_->setOperatingConditions(nullptr, MinMaxAll::all(), sta_->cmdSdc());
|
||||
@@ -3280,11 +3183,6 @@ TEST_F(StaInitTest, StaRemoveDelaySlewAnnotations) {
|
||||
|
||||
}
|
||||
|
||||
// --- Sta.cc: minPeriodViolations and maxSkewViolations (throw) ---
|
||||
TEST_F(StaInitTest, StaMinPeriodViolationsThrows) {
|
||||
// minPeriodViolations removed from API;
|
||||
}
|
||||
|
||||
// minPeriodSlack removed from API
|
||||
TEST_F(StaInitTest, StaMinPeriodReportThrows) {
|
||||
EXPECT_THROW(sta_->reportMinPeriodChecks(nullptr, 10, false, false, sta_->scenes()), std::exception);
|
||||
|
||||
Reference in New Issue
Block a user