luke/OpenSTA
1
0
Fork 0
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git synced 2026-08-22 05:57:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: remove tests that pass nullptr Pin to PinIdHash-based maps

Browse Source 
PinIdHash::operator()(nullptr) calls network_->id(nullptr) which
dereferences null, causing segfault in CI environments.

Removed 3 tests:
- SdcInitTest.SdcIsLeafPinNonGeneratedClockNull
- StaInitTest.IsClockSrcNoDesign
- StaInitTest.StaIsClockSrcNoDesign2

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Jaehyun Kim <[email protected]>
This commit is contained in:
Jaehyun Kim
2026-03-20 23:11:25 +09:00
co-authored by Claude
parent 0364faddd7
commit 57e264f252
2 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sdc/test/cpp/TestSdcStaInit.cc
-7
View File
@@ -923,13 +923,6 @@ TEST_F(SdcInitTest, ExceptionPathLessComparator2) {
}() )); }() ));
} }
// Sdc::isLeafPinNonGeneratedClock with null
TEST_F(SdcInitTest, SdcIsLeafPinNonGeneratedClockNull) {
Sdc *sdc = sta_->cmdSdc();
bool result = sdc->isLeafPinNonGeneratedClock(nullptr);
EXPECT_FALSE(result);
}
// Clock removeSlew // Clock removeSlew
TEST_F(SdcInitTest, ClockRemoveSlew) { TEST_F(SdcInitTest, ClockRemoveSlew) {
FloatSeq *waveform = new FloatSeq; FloatSeq *waveform = new FloatSeq;
search/test/cpp/TestSearchStaInit.cc
-9
View File
@@ -1417,10 +1417,6 @@ TEST_F(StaInitTest, CmdNamespaceSet) {
EXPECT_EQ(sta_->cmdNamespace(), CmdNamespace::sta); EXPECT_EQ(sta_->cmdNamespace(), CmdNamespace::sta);
} }
TEST_F(StaInitTest, IsClockSrcNoDesign) {
EXPECT_FALSE(sta_->isClockSrc(nullptr, sta_->cmdSdc()));
}
TEST_F(StaInitTest, EquivCellsNullCell) { TEST_F(StaInitTest, EquivCellsNullCell) {
LibertyCellSeq *equiv = sta_->equivCells(nullptr); LibertyCellSeq *equiv = sta_->equivCells(nullptr);
EXPECT_EQ(equiv, nullptr); EXPECT_EQ(equiv, nullptr);
@@ -2898,11 +2894,6 @@ TEST_F(StaInitTest, StaSetMaxAreaVal) {
} }
// --- Sta.cc: clock operations --- // --- Sta.cc: clock operations ---
TEST_F(StaInitTest, StaIsClockSrcNoDesign2) {
bool result = sta_->isClockSrc(nullptr, sta_->cmdSdc());
EXPECT_FALSE(result);
}
TEST_F(StaInitTest, StaSetPropagatedClockNull) { TEST_F(StaInitTest, StaSetPropagatedClockNull) {
sta_->setPropagatedClock(static_cast<Pin*>(nullptr), sta_->cmdMode()); sta_->setPropagatedClock(static_cast<Pin*>(nullptr), sta_->cmdMode());