From 57e264f252067c9b6d463c972c71e7628be0dfe4 Mon Sep 17 00:00:00 2001 From: Jaehyun Kim Date: Fri, 20 Mar 2026 23:11:25 +0900 Subject: [PATCH] test: remove tests that pass nullptr Pin to PinIdHash-based maps PinIdHash::operator()(nullptr) calls network_->id(nullptr) which dereferences null, causing segfault in CI environments. Removed 3 tests: - SdcInitTest.SdcIsLeafPinNonGeneratedClockNull - StaInitTest.IsClockSrcNoDesign - StaInitTest.StaIsClockSrcNoDesign2 Co-Authored-By: Claude Signed-off-by: Jaehyun Kim --- sdc/test/cpp/TestSdcStaInit.cc | 7 ------- search/test/cpp/TestSearchStaInit.cc | 9 --------- 2 files changed, 16 deletions(-) diff --git a/sdc/test/cpp/TestSdcStaInit.cc b/sdc/test/cpp/TestSdcStaInit.cc index 24e6d17d..0d9649ff 100644 --- a/sdc/test/cpp/TestSdcStaInit.cc +++ b/sdc/test/cpp/TestSdcStaInit.cc @@ -923,13 +923,6 @@ TEST_F(SdcInitTest, ExceptionPathLessComparator2) { }() )); } -// Sdc::isLeafPinNonGeneratedClock with null -TEST_F(SdcInitTest, SdcIsLeafPinNonGeneratedClockNull) { - Sdc *sdc = sta_->cmdSdc(); - bool result = sdc->isLeafPinNonGeneratedClock(nullptr); - EXPECT_FALSE(result); -} - // Clock removeSlew TEST_F(SdcInitTest, ClockRemoveSlew) { FloatSeq *waveform = new FloatSeq; diff --git a/search/test/cpp/TestSearchStaInit.cc b/search/test/cpp/TestSearchStaInit.cc index 45abd593..935ec5d1 100644 --- a/search/test/cpp/TestSearchStaInit.cc +++ b/search/test/cpp/TestSearchStaInit.cc @@ -1417,10 +1417,6 @@ TEST_F(StaInitTest, CmdNamespaceSet) { EXPECT_EQ(sta_->cmdNamespace(), CmdNamespace::sta); } -TEST_F(StaInitTest, IsClockSrcNoDesign) { - EXPECT_FALSE(sta_->isClockSrc(nullptr, sta_->cmdSdc())); -} - TEST_F(StaInitTest, EquivCellsNullCell) { LibertyCellSeq *equiv = sta_->equivCells(nullptr); EXPECT_EQ(equiv, nullptr); @@ -2898,11 +2894,6 @@ TEST_F(StaInitTest, StaSetMaxAreaVal) { } // --- Sta.cc: clock operations --- -TEST_F(StaInitTest, StaIsClockSrcNoDesign2) { - bool result = sta_->isClockSrc(nullptr, sta_->cmdSdc()); - EXPECT_FALSE(result); -} - TEST_F(StaInitTest, StaSetPropagatedClockNull) { sta_->setPropagatedClock(static_cast(nullptr), sta_->cmdMode());