luke
/
xschem
mirror of https://github.com/StefanSchippers/xschem.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix erroneous bbox(START...) call in edit_rect_property() not followed by bbox(SET...) and bbox(END...), possibly locking the UI

This commit is contained in:
stefan schippers 2024-03-14 20:25:50 +01:00
parent 6c0398a8b6
commit d59196f1d4
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cairo_jpg.c
View File

@ -376,7 +376,7 @@ cairo_surface_t *cairo_image_surface_create_from_jpeg_mem(void *data, size_t len
jpeg_destroy_decompress(&cinfo);
/* Stefan: commented out since this assumes static lifetime of 'data' buffer
* that I don't assume. I consider this a bug */
* that I don't assume. I consider this a bug. Embedding jpeg data should be optional */
/* set jpeg mime data */
/* cairo_surface_set_mime_data(sfc, CAIRO_MIME_TYPE_JPEG, data, len, free, data);*/

4
src/editprop.c
View File

@ -901,7 +901,6 @@ static int edit_rect_property(int x)
if(strcmp(tclgetvar("tctx::rcode"),"") )
{
xctx->push_undo();
bbox(START, 0.0 , 0.0 , 0.0 , 0.0);
for(i=0; i<xctx->lastsel; ++i) {
if(xctx->sel_array[i].type != xRECT) continue;
c = xctx->sel_array[i].col;
@ -930,6 +929,9 @@ static int edit_rect_property(int x)
if( (oldprop && xctx->rect[c][n].prop_ptr && strcmp(oldprop, xctx->rect[c][n].prop_ptr)) ||
(!oldprop && xctx->rect[c][n].prop_ptr) || (oldprop && !xctx->rect[c][n].prop_ptr)) {
modified = 1;
if(!drw) {
bbox(START, 0.0 , 0.0 , 0.0 , 0.0);
}
drw = 1;
if( xctx->rect[c][n].flags & 1024) {
draw_image(0, &xctx->rect[c][n], &xctx->rect[c][n].x1, &xctx->rect[c][n].y1,