luke
/
xschem
mirror of https://github.com/StefanSchippers/xschem.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

execute_fileevent: do not reset pipe to blocking mode before closing if no status is requested: this avoids close blocking if executed process closes its stdout / stderr file descriptors before ending

This commit is contained in:
Stefan Schippers 2020-10-31 01:45:59 +01:00
parent 01ed63275b
commit 34a1cb8950
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/xschem.tcl
View File

@ -44,27 +44,28 @@ proc execute_fileevent {id} {
append execute_data($id) [read $execute_pipe($id) 1024]
if {[eof $execute_pipe($id)]} {
fileevent $execute_pipe($id) readable ""
# setting pipe to blocking before closing allows to see if pipeline failed
fconfigure $execute_pipe($id) -blocking 1
set status 0
if {[catch {close $execute_pipe($id)} err options]} {
set details [dict get $options -errorcode]
if {[lindex $details 0] eq "CHILDSTATUS"} {
set status [lindex $details 2]
if { $execute_status($id) } {
if { $execute_status($id) } {
# setting pipe to blocking before closing allows to see if pipeline failed
# do not ask status for processes that close stdout/stderr, as eof might
# occur before process ends and following close blocks until process terminates.
fconfigure $execute_pipe($id) -blocking 1
set status 0
if {[catch {close $execute_pipe($id)} err options]} {
set details [dict get $options -errorcode]
if {[lindex $details 0] eq "CHILDSTATUS"} {
set status [lindex $details 2]
viewdata "Failed: $execute_cmd($id)\nstderr:\n$err\ndata:\n$execute_data($id)" ro
}
} else {
if { $execute_status($id) } {
} else {
set status 1
viewdata "Completed: $execute_cmd($id)\nstderr:\n$err\ndata:\n$execute_data($id)" ro
}
}
}
if { $status == 0 } {
if { $execute_status($id) } {
if { $status == 0 } {
viewdata "Completed: $execute_cmd($id)\ndata:\n$execute_data($id)" ro
}
} else {
# nonblocking close always succeed
close $execute_pipe($id)
}
if { [info exists execute_callback($id)] } { eval $execute_callback($id); unset execute_callback($id) }
unset execute_pipe($id)