luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 10:03:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Optimize DFG synthesis symbol table ordering (#8282)

Browse Source
This commit is contained in:
Geza Lore
2026-09-05 11:13:09 -04:00
committed by GitHub
parent 35c1a244a8
commit fa59f8f302
1 changed files with 30 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3DfgSynthesize.cpp
+30 -21
View File
@@ -587,8 +587,11 @@ class AstToDfgSynthesize final {
// SymTab must be ordered in order to yield stable results
struct AstVarScopeComparator final {
bool operator()(const AstVarScope* lhs, const AstVarScope* rhs) const {
return lhs->name() < rhs->name();
static int s_vscpIdCounter; // Counter for lazily allocating the unique AstVarScope IDs
bool operator()(AstVarScope* lhs, AstVarScope* rhs) const {
if (!lhs->user4()) lhs->user4(++s_vscpIdCounter);
if (!rhs->user4()) rhs->user4(++s_vscpIdCounter);
return lhs->user4() < rhs->user4();
}
};
using SymTab = std::map<AstVarScope*, DfgVertexVar*, AstVarScopeComparator>;
@@ -1790,28 +1793,32 @@ class AstToDfgSynthesize final {
//-------------------------------------------------------------------
UINFO(5, "Step 1: Attempting to synthesize each of the selected DfgLogic");
for (DfgVertex& vtx : m_dfg.opVertices()) {
DfgLogic* const logicp = vtx.cast<DfgLogic>();
if (!logicp) continue;
{
// AstVarScope::user4() -> int: unique ID for 'AstVarScopeComparator'
const VNUser4InUse user4InUse;
for (DfgVertex& vtx : m_dfg.opVertices()) {
DfgLogic* const logicp = vtx.cast<DfgLogic>();
if (!logicp) continue;
// We should only have DfgLogic remaining that was selected for synthesis
UASSERT_OBJ(logicp->selectedForSynthesis(), logicp, "Unselected DfgLogic remains");
// We should only have DfgLogic remaining that was selected for synthesis
UASSERT_OBJ(logicp->selectedForSynthesis(), logicp, "Unselected DfgLogic remains");
// Debug aid
const auto debugCallback = [&]() -> void {
// This is the breaking logic
m_debugLogicp = logicp;
// Dump it
UINFOTREE(0, logicp->nodep(), "Problematic DfgLogic: " << logicp, " ");
V3EmitV::debugVerilogForTree(logicp->nodep(), std::cout);
debugDump("synth-lastok");
};
if (VL_UNLIKELY(s_dfgSynthDebugBisect.stop(debugCallback))) break;
// Debug aid
const auto debugCallback = [&]() -> void {
// This is the breaking logic
m_debugLogicp = logicp;
// Dump it
UINFOTREE(0, logicp->nodep(), "Problematic DfgLogic: " << logicp, " ");
V3EmitV::debugVerilogForTree(logicp->nodep(), std::cout);
debugDump("synth-lastok");
};
if (VL_UNLIKELY(s_dfgSynthDebugBisect.stop(debugCallback))) break;
// Synthesize it, if failed, enqueue for reversion
if (!synthesize(*logicp)) {
logicp->setNonSynthesizable();
m_toRevert.push_front(*logicp);
// Synthesize it, if failed, enqueue for reversion
if (!synthesize(*logicp)) {
logicp->setNonSynthesizable();
m_toRevert.push_front(*logicp);
}
}
}
debugDump("synth-converted");
@@ -1966,6 +1973,8 @@ public:
}
};
int AstToDfgSynthesize::AstVarScopeComparator::s_vscpIdCounter = 0;
// Decide which DfgLogic to attempt to synthesize
static void dfgSelectLogicForSynthesis(DfgGraph& dfg) {
// If we are told to synthesize everything, we will do so ...