luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Partially support IEEE 1800-2017 section 10.9.1 apply default recursively (#4589)

This commit is contained in:
Ali Hammoud 2025-12-21 22:18:14 -05:00
parent 742c0b134c
commit edea97a63f
1 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/V3Width.cpp
View File

@ -4902,6 +4902,38 @@ class WidthVisitor final : public VNVisitor {
}
patp = nextp;
}
// Handle recursive default expansion (e.g. multidim unpacked array assignment)
if (defaultp && nodep->dtypep()) {
// The type of the pattern itself
AstNodeDType* patternDType = nodep->dtypep()->skipRefp();
// Check if we are targeting an array
if (AstNodeArrayDType* arrayDType = VN_CAST(patternDType, NodeArrayDType)) {
AstNodeDType* elementTypep = arrayDType->subDTypep()->skipRefp();
// If the element type is ALSO an array, but our default value is NOT a pattern
if (VN_IS(elementTypep, NodeArrayDType) && !VN_IS(defaultp->lhssp(), Pattern)) {
UINFO(4, "Synthesizing recursive default pattern for " << nodep << endl);
// Get the current value (e.g. '0)
AstNodeExpr* valueToWrapp = defaultp->lhssp();
// Clone it
AstNodeExpr* clonedValuep = valueToWrapp->cloneTree(true);
// Create the wrapper pattern: '{ default: <clonedValuep> }
AstPattern* innerPatternp
= new AstPattern(valueToWrapp->fileline(), nullptr);
// Create the member, default: <clonedValuep>
// AstPatMember ( fileline, value_expr, key_node, rep_node )
AstPatMember* innerMemberp = new AstPatMember(
valueToWrapp->fileline(), clonedValuep, nullptr, nullptr);
innerMemberp->isDefault(true);
// Add member to pattern
innerPatternp->addItemsp(innerMemberp);
// Replace the original '0 with the new '{default: '0}
valueToWrapp->replaceWith(innerPatternp);
// Cleanup the original value node. It is now detached so delete it.
VL_DO_DANGLING(valueToWrapp->deleteTree(), valueToWrapp);
}
}
}
//*/
while (const AstConstDType* const vdtypep = VN_CAST(dtypep, ConstDType)) {
dtypep = vdtypep->subDTypep()->skipRefp();
}