luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 18:13:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Support functions on RHS of force (#7491)

Browse Source 
Signed-off-by: Artur Bieniek <[email protected]>
This commit is contained in:
Artur Bieniek
2026-04-30 10:38:07 -04:00
committed by GitHub
parent dd75c4cd1b
commit ec03edcddd
4 changed files with 44 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Task.cpp
+42
View File
@@ -434,6 +434,7 @@ class TaskVisitor final : public VNVisitor {
int m_unconVarNum = 0; // Unique bad connection variable
// STATE - across all visitors
V3UniqueNames m_forceTmpNames; // For generating unique force-RHS helper names
DpiCFuncs m_dpiNames; // Map of all created DPI functions
VDouble0 m_statInlines; // Statistic tracking
VDouble0 m_statHierDpisWithCosts; // Statistic tracking
@@ -1784,6 +1785,47 @@ class TaskVisitor final : public VNVisitor {
VL_DO_DANGLING(pushDeletep(nodep), nodep);
}
}
void visit(AstAssignForce* nodep) override {
// Force statements cannot be converted to always blocks outside of a logic block
// This causes function calls on RHS of force assignments to be improperly inlined and
// called just once. To prevent this, we create a temporary variable for each function
// reference on RHS. This variable is declared in the nearest scope and gets a continuous
// assignment of the function, so it can be converted to always and properly inlined This
// temporary variable becomes the RHS of the force assignment
std::vector<AstNodeFTaskRef*> refs;
nodep->rhsp()->foreach([&refs](AstNodeFTaskRef* refp) { refs.push_back(refp); });
for (AstNodeFTaskRef* const refp : refs) {
// Create the temporary variable and its scope
// Replicate the logic from V3Task, every function call gets
// a unique temp variable
AstVar* const interVarp = new AstVar{
nodep->fileline(), VVarType::VAR,
refp->name() + "__Vforcefuncout" + m_forceTmpNames.get(nodep), refp->dtypep()};
UASSERT_OBJ(m_modp->stmtsp(), m_modp, "Module should have statements in it");
m_modp->stmtsp()->addHereThisAsNext(interVarp);
AstVarScope* const interVscp = new AstVarScope{refp->fileline(), m_scopep, interVarp};
m_scopep->addVarsp(interVscp);
// Recompute the helper in a combo block so any inlined function body stays
// inside schedulable logic rather than spilling statements at module scope.
AstAssign* const assignp = new AstAssign{
nodep->fileline(), new AstVarRef{nodep->fileline(), interVscp, VAccess::WRITE},
nodep->rhsp()->cloneTreePure(false)};
AstSenTree* const senTreep = new AstSenTree{
nodep->fileline(), new AstSenItem{nodep->fileline(), AstSenItem::Combo{}}};
AstActive* const activep
= new AstActive{nodep->fileline(), "force-func-update", senTreep};
activep->senTreeStorep(activep->sentreep());
activep->addStmtsp(
new AstAlways{nodep->fileline(), VAlwaysKwd::ALWAYS, nullptr, assignp});
m_scopep->addBlocksp(activep);
// Replace RHS of force assignment with the temporary variable
refp->replaceWith(new AstVarRef{nodep->fileline(), interVscp, VAccess::READ});
VL_DO_DANGLING(refp->deleteTree(), refp);
}
}
void visit(AstNodeForeach* nodep) override { // LCOV_EXCL_LINE
nodep->v3fatalSrc(
"Foreach statements should have been converted to while statements in V3Begin.cpp");