luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary virtual methods

This commit is contained in:
Geza Lore 2022-08-26 18:14:53 +01:00
parent 881c3f6e40
commit ebbe24966c
2 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/V3Order.cpp
View File

@ -790,7 +790,7 @@ class OrderVerticesByDomainThenScope final {
PartPtrIdMap m_ids; PartPtrIdMap m_ids;
public: public:
virtual bool operator()(const V3GraphVertex* lhsp, const V3GraphVertex* rhsp) const { bool operator()(const V3GraphVertex* lhsp, const V3GraphVertex* rhsp) const {
const MTaskMoveVertex* const l_vxp = dynamic_cast<const MTaskMoveVertex*>(lhsp); const MTaskMoveVertex* const l_vxp = dynamic_cast<const MTaskMoveVertex*>(lhsp);
const MTaskMoveVertex* const r_vxp = dynamic_cast<const MTaskMoveVertex*>(rhsp); const MTaskMoveVertex* const r_vxp = dynamic_cast<const MTaskMoveVertex*>(rhsp);
uint64_t l_id = m_ids.findId(l_vxp->domainp()); uint64_t l_id = m_ids.findId(l_vxp->domainp());
@ -803,14 +803,10 @@ public:
} }
}; };
class MTaskVxIdLessThan final { struct MTaskVxIdLessThan final {
public:
MTaskVxIdLessThan() = default;
virtual ~MTaskVxIdLessThan() = default;
// Sort vertex's, which must be AbstractMTask's, into a deterministic // Sort vertex's, which must be AbstractMTask's, into a deterministic
// order by comparing their serial IDs. // order by comparing their serial IDs.
virtual bool operator()(const V3GraphVertex* lhsp, const V3GraphVertex* rhsp) const { bool operator()(const V3GraphVertex* lhsp, const V3GraphVertex* rhsp) const {
const AbstractMTask* const lmtaskp = dynamic_cast<const AbstractLogicMTask*>(lhsp); const AbstractMTask* const lmtaskp = dynamic_cast<const AbstractLogicMTask*>(lhsp);
const AbstractMTask* const rmtaskp = dynamic_cast<const AbstractLogicMTask*>(rhsp); const AbstractMTask* const rmtaskp = dynamic_cast<const AbstractLogicMTask*>(rhsp);
return lmtaskp->id() < rmtaskp->id(); return lmtaskp->id() < rmtaskp->id();

9
src/V3Partition.cpp
View File

@ -394,11 +394,8 @@ private:
// Sort AbstractMTask objects into deterministic order by calling id() // Sort AbstractMTask objects into deterministic order by calling id()
// which is a unique and stable serial number. // which is a unique and stable serial number.
class MTaskIdLessThan final { struct MTaskIdLessThan final {
public: bool operator()(const AbstractMTask* lhsp, const AbstractMTask* rhsp) const {
MTaskIdLessThan() = default;
virtual ~MTaskIdLessThan() = default;
virtual bool operator()(const AbstractMTask* lhsp, const AbstractMTask* rhsp) const {
return lhsp->id() < rhsp->id(); return lhsp->id() < rhsp->id();
} }
}; };
@ -727,7 +724,7 @@ class OrderByPtrId final {
PartPtrIdMap m_ids; PartPtrIdMap m_ids;
public: public:
virtual bool operator()(const OrderVarStdVertex* lhsp, const OrderVarStdVertex* rhsp) const { bool operator()(const OrderVarStdVertex* lhsp, const OrderVarStdVertex* rhsp) const {
const uint64_t l_id = m_ids.findId(lhsp); const uint64_t l_id = m_ids.findId(lhsp);
const uint64_t r_id = m_ids.findId(rhsp); const uint64_t r_id = m_ids.findId(rhsp);
return l_id < r_id; return l_id < r_id;