luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-05 08:42:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

Support consecutive repetition [*N:M], [+], and [*] in sequence expressions (#7379)

Browse Source
This commit is contained in:
Yilou Wang
2026-04-08 10:26:03 -04:00
committed by GitHub
parent 7dcf586807
commit e63c4f563e
14 changed files with 435 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Width.cpp
+20 -5
View File
@@ -1512,19 +1512,34 @@ class WidthVisitor final : public VNVisitor {
}
}
void visit(AstConsRep* nodep) override {
// IEEE 1800-2023 16.9.2 -- consecutive repetition [*N]
// IEEE 1800-2023 16.9.2 -- consecutive repetition [*N], [*N:M], [+], [*]
assertAtExpr(nodep);
if (m_vup->prelim()) {
userIterateAndNext(nodep->exprp(), WidthVP{SELF, BOTH}.p());
userIterateAndNext(nodep->countp(), WidthVP{SELF, BOTH}.p());
V3Const::constifyParamsEdit(nodep->countp()); // countp may change
const AstConst* const constp = VN_CAST(nodep->countp(), Const);
if (!constp) {
V3Const::constifyParamsEdit(nodep->countp());
const AstConst* const minConstp = VN_CAST(nodep->countp(), Const);
if (!minConstp) {
nodep->v3error("Consecutive repetition count must be constant expression"
" (IEEE 1800-2023 16.9.2)");
} else if (constp->toSInt() < 1) {
} else if (!nodep->unbounded() && !nodep->maxCountp() && minConstp->toSInt() < 1) {
nodep->v3warn(E_UNSUPPORTED, "Unsupported: [*0] consecutive repetition");
}
if (nodep->maxCountp()) {
userIterateAndNext(nodep->maxCountp(), WidthVP{SELF, BOTH}.p());
V3Const::constifyParamsEdit(nodep->maxCountp());
const AstConst* const maxConstp = VN_CAST(nodep->maxCountp(), Const);
if (!maxConstp) {
nodep->v3error("Consecutive repetition max count must be constant"
" expression (IEEE 1800-2023 16.9.2)");
} else if (minConstp && maxConstp->toSInt() < minConstp->toSInt()) {
nodep->v3error("Consecutive repetition max count must be >= min count"
" (IEEE 1800-2023 16.9.2)");
} else if (maxConstp->toSInt() < 1) {
nodep->v3warn(E_UNSUPPORTED, "Unsupported: [*N:0] consecutive repetition"
" with zero max count");
}
}
nodep->dtypeSetBit();
}
}