luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 10:03:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Better error on inside on unpacked, queues, etc (#2566)

Browse Source
This commit is contained in:
Wilson Snyder
2020-12-12 21:20:42 -05:00
parent 6061744c4d
commit e2e3cc8463
8 changed files with 72 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Width.cpp
+11 -2
View File
@@ -2211,12 +2211,21 @@ private:
for (AstNode *nextip, *itemp = nodep->itemsp(); itemp; itemp = nextip) {
nextip = itemp->nextp(); // Will be unlinking
AstNode* inewp;
AstNodeDType* itemDtp = itemp->dtypep()->skipRefp();
if (AstInsideRange* irangep = VN_CAST(itemp, InsideRange)) {
// Similar logic in V3Case
inewp = irangep->newAndFromInside(nodep->exprp(), irangep->lhsp()->unlinkFrBack(),
irangep->rhsp()->unlinkFrBack());
} else if (auto* irangep = VN_CAST(itemp->dtypep(), UnpackArrayDType)) {
irangep->v3error("Unsupported: inside on unpacked array");
} else if (VN_IS(itemDtp, UnpackArrayDType)) {
nodep->v3error("Unsupported: inside (set membership operator) on unpacked array");
// Need the AstInside type to persist, then
// for parameters, need V3Simulate support.
// For non-parameters, need runtime support.
continue;
} else if (VN_IS(itemDtp, AssocArrayDType) || VN_IS(itemDtp, DynArrayDType)
|| VN_IS(itemDtp, QueueDType)) {
nodep->v3error(
"Inside operator not legal on non-unpacked arrays (IEEE 1800-2017 11.4.13)");
continue;
} else {
inewp = new AstEqWild(itemp->fileline(), nodep->exprp()->cloneTree(true),