luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Variable in the arguments of the std::randomization are randomized if not mentioned their value will be checked against the constrained

This commit is contained in:
Udaya Raj Subedi 2025-09-28 12:46:35 +02:00
parent 410564720c
commit d32267e15c
1 changed files with 46 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
src/V3Randomize.cpp
View File

@ -220,6 +220,7 @@ class RandomizeMarkVisitor final : public VNVisitor {
void visit(AstWith* nodep) override { void visit(AstWith* nodep) override {
cout << " Whattttt " << stdrandcall << endl; cout << " Whattttt " << stdrandcall << endl;
// stdrandcall->dumpTreeJson(cout);
for (AstNode* pinp = stdrandcall ? stdrandcall->pinsp() : nullptr; pinp; for (AstNode* pinp = stdrandcall ? stdrandcall->pinsp() : nullptr; pinp;
pinp = pinp->nextp()) { pinp = pinp->nextp()) {
AstArg* const argp = VN_CAST(pinp, Arg); AstArg* const argp = VN_CAST(pinp, Arg);
@ -479,8 +480,27 @@ class RandomizeMarkVisitor final : public VNVisitor {
if (nodep->varp()->lifetime().isStatic()) m_staticRefs.emplace(nodep); if (nodep->varp()->lifetime().isStatic()) m_staticRefs.emplace(nodep);
if (nodep->varp()->rand().isRandomizable() || (instdwith && stdrandcall)) if (nodep->varp()->rand().isRandomizable() && !(instdwith && stdrandcall)) // if (nodep->varp()->rand().isRandomizable() || (instdwith && stdrandcall))
nodep->user1(true); nodep->user1(true);
if(instdwith && stdrandcall){
for (AstNode* pinp = stdrandcall->pinsp(); pinp; pinp = pinp->nextp()) {
if(VN_IS(pinp, With)) continue;
AstArg* const argp = VN_CAST(pinp, Arg);
AstNodeExpr* exprp = argp->exprp();
if( VN_IS(exprp, NodeVarRef) && nodep->varp() == VN_CAST(exprp, NodeVarRef)->varp()){
cout<<" LLLLLOOOOOOLLLLLLLOOOOOOLLLLL OKKKK"<< nodep->varp()->name()<<endl;
nodep->user1(true);
}
else{
cout<<" NEEEEIIIIINNNNN"<<endl;
// nodep->user1(false);
}
}
}
} }
void visit(AstMemberSel* nodep) override { void visit(AstMemberSel* nodep) override {
if (!m_constraintExprGenp) return; if (!m_constraintExprGenp) return;
@ -490,9 +510,26 @@ class RandomizeMarkVisitor final : public VNVisitor {
// of type AstLambdaArgRef. They are randomized too. // of type AstLambdaArgRef. They are randomized too.
const bool randObject = nodep->fromp()->user1() || VN_IS(nodep->fromp(), LambdaArgRef); const bool randObject = nodep->fromp()->user1() || VN_IS(nodep->fromp(), LambdaArgRef);
// nodep->user1((randObject && nodep->varp()->rand().isRandomizable())); // nodep->user1((randObject && nodep->varp()->rand().isRandomizable()));
nodep->user1((randObject && nodep->varp()->rand().isRandomizable()) nodep->user1((randObject && nodep->varp()->rand().isRandomizable() && !(instdwith && stdrandcall))); // nodep->user1((randObject && nodep->varp()->rand().isRandomizable()) || (instdwith && stdrandcall));
|| (instdwith && stdrandcall));
nodep->user2p(m_modp); nodep->user2p(m_modp);
if(instdwith && stdrandcall){
for (AstNode* pinp = stdrandcall->pinsp() ; pinp; pinp = pinp->nextp()) {
if(VN_IS(pinp, With)) continue;
AstArg* const argp = VN_CAST(pinp, Arg);
AstNodeExpr* exprp = argp->exprp();
if( VN_IS(exprp, MemberSel) && nodep->varp()== VN_CAST(exprp, MemberSel)->varp()){
cout<<" LLLLLOOOOOOLLLLLLLOOOOOOLLLLL"<<endl;
nodep->user1(true);
if(VN_IS(nodep->fromp(), VarRef)) nodep->fromp()->user1(true); /// need more smart way for this, It is neded when membersel is iterated in constraint visitor, var ref in the fromp of membersel req as in vARREF visitor checks for it.
}
else{
cout<<" NEEEEIIIIINNNNN"<<endl;
// nodep->user1(false);
}
}
}
} }
void visit(AstNodeModule* nodep) override { void visit(AstNodeModule* nodep) override {
VL_RESTORER(m_modp); VL_RESTORER(m_modp);
@ -943,16 +980,17 @@ class ConstraintExprVisitor final : public VNVisitor {
if (nodep->user1()) { if (nodep->user1()) {
// nodep->v3warn(CONSTRAINTIGN, "Global constraints ignored (unsupported)"); // nodep->v3warn(CONSTRAINTIGN, "Global constraints ignored (unsupported)");
cout << " WOWOWOWOWOWWOWOWOWOWO" << endl; cout << " WOWOWOWOWOWWOWOWOWOWO" << endl;
iterateChildren(nodep);
nodep->replaceWith(nodep->fromp()->unlinkFrBack());
return;
}
if (VN_IS(nodep->fromp(), NodeVarRef) && nodep->varp()->isRand() && m_inlineInitTaskp) {
iterateChildren(nodep); iterateChildren(nodep);
nodep->replaceWith(nodep->fromp()->unlinkFrBack()); nodep->replaceWith(nodep->fromp()->unlinkFrBack());
VL_DO_DANGLING(nodep->deleteTree(), nodep); VL_DO_DANGLING(nodep->deleteTree(), nodep);
return; return;
} }
// if (VN_IS(nodep->fromp(), NodeVarRef) && nodep->varp()->isRand() && m_inlineInitTaskp) {
// iterateChildren(nodep);
// nodep->replaceWith(nodep->fromp()->unlinkFrBack());
// VL_DO_DANGLING(nodep->deleteTree(), nodep);
// return;
// }
editFormat(nodep); editFormat(nodep);
} }
void visit(AstSFormatF* nodep) override {} void visit(AstSFormatF* nodep) override {}