luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 10:03:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Move Postponed logic after the eval loop (#3673)

Browse Source 
Signed-off-by: Krzysztof Bieganski <[email protected]>
This commit is contained in:
Krzysztof Bieganski
2022-10-13 21:04:43 +02:00
committed by GitHub
parent 68927d4fd3
commit caed086516
11 changed files with 106 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Order.cpp
+1 -20
View File
@@ -181,7 +181,6 @@ class OrderBuildVisitor final : public VNVisitor {
bool m_inClocked = false; // Underneath clocked AstActive
bool m_inPre = false; // Underneath AstAssignPre
bool m_inPost = false; // Underneath AstAssignPost/AstAlwaysPost
bool m_inPostponed = false; // Underneath AstAlwaysPostponed
std::function<bool(const AstVarScope*)> m_readTriggersCombLogic;
// METHODS
@@ -265,19 +264,7 @@ class OrderBuildVisitor final : public VNVisitor {
const bool prevCon = varscp->user2() & VU_CON;
// Compute whether the variable is produced (written) here
bool gen = false;
if (!prevGen && nodep->access().isWriteOrRW()) {
gen = true;
if (m_inPostponed) {
// IEEE 1800-2017 (4.2.9) forbids any value updates in the postponed region, but
// Verilator generated trigger signals for $strobe are cleared after the
// display is executed. This is both safe to ignore (because their single read
// is in the same AstAlwaysPostponed, just prior to the clear), and is
// necessary to ignore to avoid a circular logic (UNOPTFLAT) warning.
UASSERT_OBJ(prevCon, nodep, "Should have been consumed in same process");
gen = false;
}
}
bool gen = !prevGen && nodep->access().isWriteOrRW();
// Compute whether the value is consumed (read) here
bool con = false;
@@ -398,12 +385,6 @@ class OrderBuildVisitor final : public VNVisitor {
iterateLogic(nodep);
m_inPost = false;
}
void visit(AstAlwaysPostponed* nodep) override {
UASSERT_OBJ(!m_inPostponed, nodep, "Should not nest");
m_inPostponed = true;
iterateLogic(nodep);
m_inPostponed = false;
}
void visit(AstFinal* nodep) override { // LCOV_EXCL_START
nodep->v3fatalSrc("AstFinal should not need ordering");
} // LCOV_EXCL_STOP