Fix clang and cppcheck warnings.

Makefile.in

@@ -423,7 +423,7 @@ CPPCHECK_INC = -I$(srcdir)/include -I$(srcdir)/src/obj_dbg -I$(srcdir)/src
 
 cppcheck: $(CPPCHECK_DEP)
 %.cppcheck: %.cpp
-	$(CPPCHECK) $(CPPCHECK_FLAGS) -DVL_DEBUG=1 $(CPPCHECK_INC) $<
+	$(CPPCHECK) $(CPPCHECK_FLAGS) -DVL_DEBUG=1 -DVL_CPPCHECK=1 $(CPPCHECK_INC) $<
 
 ftp: info
 

src/V3Ast.h

@@ -734,6 +734,7 @@ class VNUser {
 public:
     VNUser() {}
     // non-explicit:
+    // cppcheck-suppress noExplicitConstructor
     VNUser(int i) { m_u.up = 0; m_u.ui = i; }
     explicit VNUser(void* p) { m_u.up = p; }
     ~VNUser() {}

src/V3AstNodes.h

@@ -1510,6 +1510,7 @@ public:
 class AstPackageExportStarStar : public AstNode {
     // A package export *::* declaration
 public:
+    // cppcheck-suppress noExplicitConstructor
     AstPackageExportStarStar(FileLine* fl)
 	: AstNode (fl) {}
     ASTNODE_NODE_FUNCS(PackageExportStarStar)

src/V3CCtors.cpp

@@ -95,6 +95,8 @@ public:
 	m_modp->addStmtp(m_tlFuncp);
     }
     ~V3CCtorsVisitor() {}
+private:
+    explicit V3CCtorsVisitor(const V3CCtorsVisitor&);  ///< N/A, no copy constructor
 };
 
 //######################################################################

src/V3Os.cpp

@@ -215,8 +215,10 @@ uint64_t V3Os::memUsageBytes() {
     if (7 != fscanf(fp, "%" VL_PRI64 "d %" VL_PRI64 "d %" VL_PRI64 "d %"
 		    VL_PRI64 "d %" VL_PRI64 "d %" VL_PRI64 "d %" VL_PRI64 "d",
 		    &size, &resident, &share, &text, &lib, &data, &dt)) {
+	fclose(fp);
 	return 0;
     }
+    fclose(fp);
     return (text + data) * getpagesize();
 #endif
 }

test_regress/t/t_dpi_import_c.cpp

@@ -123,8 +123,6 @@ void dpii_v_struct (const svBitVecVal* i, svBitVecVal* o) {
     o[0] = ~i[0];
     o[1] = ~i[1];
     o[2] = ~i[2];
-    o[3] = ~i[3];
-    o[4] = ~i[4];
 }
 void dpii_v_substruct (const svBitVecVal* i, int* o) {
     // To be most like other tools, this should automagically take the substruct_t

test_regress/t/t_vgen.pl

@@ -7,6 +7,8 @@ if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); di
 # Lesser General Public License Version 3 or the Perl Artistic License
 # Version 2.0.
 
+if (eval "use Bit::Vector; return 2;" != 2) { $Self->error("Please install Bit::Vector"); }
+
 top_filename("$Self->{obj_dir}/vgen.v");
 
 $Self->run(cmd=>["./vgen.pl",