luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-02 10:48:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix internal error on multi-cycle SVA under default clocking (#7472) (#7506)

Browse Source
This commit is contained in:
Yilou Wang
2026-04-28 06:50:16 -04:00
committed by GitHub
parent 327fc4ffbe
commit bb1bfabab3
4 changed files with 191 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3AssertPre.cpp
+15 -22
View File
@@ -240,6 +240,15 @@ private:
VL_RESTORER(m_clockingp);
m_clockingp = nodep;
UINFO(8, " CLOCKING" << nodep);
if (nodep->isDefault()) {
if (m_defaultClockingp) {
nodep->v3error("Only one default clocking block allowed per module"
" (IEEE 1800-2023 14.12)");
} else {
m_defaultClockingp = nodep;
m_defaultClkEvtVarp = nodep->ensureEventp();
}
}
iterateChildren(nodep);
if (nodep->eventp()) nodep->addNextHere(nodep->eventp()->unlinkFrBack());
VL_DO_DANGLING(pushDeletep(nodep->unlinkFrBack()), nodep);
@@ -1182,7 +1191,12 @@ private:
}
void visit(AstDefaultDisable* nodep) override {
// Done with these
if (m_defaultDisablep) {
nodep->v3error("Only one 'default disable iff' allowed per module"
" (IEEE 1800-2023 16.15)");
} else {
m_defaultDisablep = nodep;
}
VL_DO_DANGLING(pushDeletep(nodep->unlinkFrBack()), nodep);
}
void visit(AstInferredDisable* nodep) override {
@@ -1293,29 +1307,8 @@ private:
VL_RESTORER(m_modp);
m_defaultClockingp = nullptr;
m_defaultClkEvtVarp = nullptr;
nodep->foreach([&](AstClocking* const clockingp) {
if (clockingp->isDefault()) {
if (m_defaultClockingp) {
clockingp->v3error("Only one default clocking block allowed per module"
" (IEEE 1800-2023 14.12)");
}
m_defaultClockingp = clockingp;
}
});
m_defaultDisablep = nullptr;
nodep->foreach([&](AstDefaultDisable* const disablep) {
if (m_defaultDisablep) {
disablep->v3error("Only one 'default disable iff' allowed per module"
" (IEEE 1800-2023 16.15)");
}
m_defaultDisablep = disablep;
});
m_modp = nodep;
// Pre-create and cache the clocking event var before iterating children.
// visit(AstClocking) will unlink the event from the clocking node and place it
// in the module tree, then delete the clocking. After that, ensureEventp() would
// create an orphaned var. Caching here avoids this.
m_defaultClkEvtVarp = m_defaultClockingp ? m_defaultClockingp->ensureEventp() : nullptr;
iterateChildren(nodep);
}
void visit(AstProperty* nodep) override {