Change `--lint-only` and `--json-only` to imply `--timing` (#6790).

Changes

@@ -15,6 +15,7 @@ Verilator 5.043 devel
 
 * This is the last release supporting the deprecated `--xml-only` and
   `--make cmake` options.
+* Change `--lint-only` and `--json-only` to imply `--timing` (#6790).
 
 **Other:**
 

docs/guide/exe_verilator.rst

@@ -1006,6 +1006,8 @@ Summary:
    You may also want the :vlopt:`-Wall` option to enable messages
    considered stylistic and not enabled by default.
 
+   Implies :vlopt:`--timing` unless :vlopt:`--no-timing` was used.
+
    If the design is not to be completely Verilated, see also the
    :vlopt:`--bbox-sys` and :vlopt:`--bbox-unsup` options.
 

src/V3Options.cpp

@@ -1039,6 +1039,10 @@ void V3Options::notify() VL_MT_DISABLED {
             && !v3Global.opt.serializeOnly());
     }
 
+    if (m_timing.isDefault()
+        && (v3Global.opt.jsonOnly() || v3Global.opt.lintOnly() || v3Global.opt.xmlOnly()))
+        v3Global.opt.m_timing.setTrueOrFalse(true);
+
     if (trace()) {
         // With --trace-vcd, --trace-threads is ignored
         if (traceEnabledVcd()) m_traceThreads = 1;

test_regress/t/t_class_new_supernfirst_bad.py

@@ -11,7 +11,7 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.extract(in_filename=test.top_filename,
              out_filename=test.root + "/docs/gen/ex_SUPERNFIRST_faulty.rst",

test_regress/t/t_clocking_bad1.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_clocking_bad2.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_clocking_bad3.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_clocking_bad4.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_clocking_bad5.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_clocking_unsup1.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_clocking_unsup2.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_config_libmap_inc.py

@@ -12,7 +12,7 @@ import vltest_bootstrap
 test.scenarios('simulator')
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--lint-only", "-libmap t/t_config_libmap_inc.map"],
+test.lint(verilator_flags2=["-libmap t/t_config_libmap_inc.map"],
           fails=test.vlt_all,
           expect_filename=test.golden_filename)
 

test_regress/t/t_debug_emitv.py

@@ -15,7 +15,7 @@ test.lint(
     # We also have dump-tree turned on, so hit a lot of AstNode*::dump() functions
     # Likewise XML
     v_flags=[
-        "--lint-only --timing",
+        "--lint-only",
         "--dumpi-tree 9 --dumpi-V3EmitV 9 --debug-emitv",  # Dev coverage of the V3EmitV code
         "--dump-graph --dumpi-tree-json 9 --no-json-ids"
     ])

test_regress/t/t_debug_emitv_addrids.py

@@ -15,6 +15,6 @@ test.top_filename = "t/t_debug_emitv.v"
 test.lint(
     # We also have dump-tree turned on, so hit a lot of AstNode*::dump() functions
     # Likewise XML
-    v_flags=["--lint-only --dumpi-tree 9 --dump-tree-addrids --timing"])
+    v_flags=["--lint-only --dumpi-tree 9 --dump-tree-addrids"])
 
 test.passes()

test_regress/t/t_disable.py

@@ -11,8 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--lint-only --timing'],
+test.lint(fails=True, expect_filename=test.golden_filename)
-          fails=True,
-          expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_disable_empty.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_disable_func_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_disable_genfor_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_disable_iff_multi_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_disable_task_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_disable_within_task_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_event_control_star.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('vlt')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_event_control_star_never_bad.py

@@ -12,7 +12,7 @@ import vltest_bootstrap
 test.scenarios('linter')
 test.top_filename = 't/t_event_control_star_never.v'
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.extract(in_filename=test.top_filename,
              out_filename=test.root + "/docs/gen/ex_ALWNEVER_faulty.rst",

test_regress/t/t_expect.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('vlt')
 
-test.lint(expect_filename=test.golden_filename, verilator_flags2=['--assert --timing'], fails=True)
+test.lint(expect_filename=test.golden_filename, verilator_flags2=['--assert'], fails=True)
 
 test.passes()

test_regress/t/t_force_complex_sel_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_force_readwrite_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_force_unpacked_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_fork_dynscope_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('simulator')
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_func_task_bad2.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_gate_basic_specify_bad.out

@@ -1,3 +1,8 @@
+%Warning-RISEFALLDLY: t/t_gate_basic.v:26:12: Unsupported: rising/falling/turn-off delays. Using the first delay
+   26 |    nand  #(2,3)   ND0 (nd0, a[0], b[0], b[1]);
+      |            ^
+                      ... For warning description see https://verilator.org/warn/RISEFALLDLY?v=latest
+                      ... Use "/* verilator lint_off RISEFALLDLY */" and lint_on around source to disable this message.
 %Warning-SPECIFYIGN: t/t_gate_basic.v:50:27: Ignoring unsupported: specify block construct
    50 |       (nt0 *> nt0) = (0, 0);
       |                           ^
@@ -6,17 +11,4 @@
 %Warning-SPECIFYIGN: t/t_gate_basic.v:60:32: Ignoring unsupported: specify block construct
    60 |     (A1 *> Q) = (a$A1$Y, a$A1$Y);
       |                                ^
-%Error-NEEDTIMINGOPT: t/t_gate_basic.v:24:10: Use --timing or --no-timing to specify how timing controls should be handled
-                                            : ... note: In instance 't'
-   24 |    not   #(0.108) NT0 (nt0, a[0]);
-      |          ^
-                      ... For error description see https://verilator.org/warn/NEEDTIMINGOPT?v=latest
-%Error-NEEDTIMINGOPT: t/t_gate_basic.v:25:10: Use --timing or --no-timing to specify how timing controls should be handled
-                                            : ... note: In instance 't'
-   25 |    and   #1       AN0 (an0, a[0], b[0]);
-      |          ^
-%Error-NEEDTIMINGOPT: t/t_gate_basic.v:26:10: Use --timing or --no-timing to specify how timing controls should be handled
-                                            : ... note: In instance 't'
-   26 |    nand  #(2,3)   ND0 (nd0, a[0], b[0], b[1]);
-      |          ^
 %Error: Exiting due to

test_regress/t/t_gate_delay_unsup.py

@@ -12,9 +12,7 @@ import vltest_bootstrap
 test.scenarios('linter')
 test.top_filename = "t/t_gate_basic.v"
 
-test.lint(verilator_flags2=[
+test.lint(verilator_flags2=["-Wall", "-Wno-DECLFILENAME -Wno-SPECIFYIGN -Wno-UNUSED"],
-    "--lint-only --timing -Wall", "-Wno-DECLFILENAME -Wno-SPECIFYIGN -Wno-UNUSED"
-],
           fails=True,
           expect_filename=test.golden_filename)
 

test_regress/t/t_interface_generic_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_bad2.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_bad3.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_bad4.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_function_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_modport_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_modport_bad2.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_modport_bad3.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_modport_task_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_interface_generic_task_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_lint_functimectl_bad.py

@@ -11,7 +11,7 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=test.vlt_all, expect_filename=test.golden_filename)
+test.lint(fails=test.vlt_all, expect_filename=test.golden_filename)
 
 test.extract(in_filename=test.top_filename,
              out_filename=test.root + "/docs/gen/ex_FUNCTIMECTL_faulty.rst",

test_regress/t/t_lint_waitconst_bad.py

@@ -12,6 +12,6 @@ import vltest_bootstrap
 test.scenarios('vlt')
 test.top_filename = "t/t_timing_wait1.v"
 
-test.lint(verilator_flags2=["--timing"], expect_filename=test.golden_filename, fails=True)
+test.lint(expect_filename=test.golden_filename, fails=True)
 
 test.passes()

test_regress/t/t_sequence_ref_unsup.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('vlt')
 
-test.lint(expect_filename=test.golden_filename, verilator_flags2=['--timing'], fails=True)
+test.lint(expect_filename=test.golden_filename, fails=True)
 
 test.passes()

test_regress/t/t_timing_clkgen_unsup.py

@@ -12,6 +12,6 @@ import vltest_bootstrap
 test.scenarios('linter')
 test.top_filename = "t/t_timing_clkgen1.v"
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_timing_dpi_unsup.py

@@ -12,6 +12,6 @@ import vltest_bootstrap
 test.scenarios('linter')
 test.top_filename = "t/t_timing_dpi_unsup.v"
 
-test.lint(verilator_flags2=["--timing"], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_varref_scope_in_interface.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('vlt')
 
-test.lint(verilator_flags2=["--timing"])
+test.lint()
 
 test.passes()

test_regress/t/t_vlt_match_error_3.py

@@ -12,9 +12,10 @@ import vltest_bootstrap
 test.scenarios('vlt')
 test.top_filename = "t/t_vlt_match_error.v"
 
-test.lint(
+test.compile(verilator_flags2=[
-    verilator_flags2=["-DT_VLT_MATCH_ERROR_3 -Wall t/t_vlt_match_error.v t/t_vlt_match_error.vlt"],
+    "-DT_VLT_MATCH_ERROR_3 --cc -Wall t/t_vlt_match_error.v t/t_vlt_match_error.vlt"
-    fails=True,
+],
-    expect_filename=test.golden_filename)
+             fails=True,
+             expect_filename=test.golden_filename)
 
 test.passes()

test_regress/t/t_wait_no_triggered_bad.py

@@ -11,6 +11,6 @@ import vltest_bootstrap
 
 test.scenarios('linter')
 
-test.lint(verilator_flags2=['--timing'], fails=True, expect_filename=test.golden_filename)
+test.lint(fails=True, expect_filename=test.golden_filename)
 
 test.passes()